From c2791db98b7913866c53c8de5b5d26a4e05f5178 Mon Sep 17 00:00:00 2001 From: Bharath Thiruveedula Date: Wed, 23 Dec 2015 19:14:22 +0530 Subject: [PATCH] Display missing key name in error message This patch will display the key name that is missing in the parameters while creating the VNF. Change-Id: I0629fec1be7cba8593c03c11de46f206023b3881 Closes-Bug: #1501858 --- tacker/extensions/vnfm.py | 2 +- tacker/vm/drivers/heat/heat.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tacker/extensions/vnfm.py b/tacker/extensions/vnfm.py index caddee9a4..bf7cc6d58 100644 --- a/tacker/extensions/vnfm.py +++ b/tacker/extensions/vnfm.py @@ -86,7 +86,7 @@ class ParamYAMLNotWellFormed(exceptions.InvalidInput): class InputValuesMissing(exceptions.InvalidInput): - message = _("Input values missing for 'get_input") + message = _("Parameter input values missing for the key '%(key)s'") class ParamYAMLInputMissing(exceptions.InvalidInput): diff --git a/tacker/vm/drivers/heat/heat.py b/tacker/vm/drivers/heat/heat.py index 3d600c877..5acdab6f3 100644 --- a/tacker/vm/drivers/heat/heat.py +++ b/tacker/vm/drivers/heat/heat.py @@ -111,13 +111,13 @@ class DeviceHeat(abstract_driver.DeviceAbstractDriver): self._update_params(value, paramvalues[key], False) else: LOG.debug('Key missing Value: %s', key) - raise vnfm.InputValuesMissing() + raise vnfm.InputValuesMissing(key=key) elif 'get_input' in value: if value['get_input'] in paramvalues: original[key] = paramvalues[value['get_input']] else: LOG.debug('Key missing Value: %s', key) - raise vnfm.InputValuesMissing() + raise vnfm.InputValuesMissing(key=key) else: self._update_params(value, paramvalues, True)