Update patch set 4
Patch Set 4: Code-Review-1 (3 comments) Patch-set: 4 Reviewer: Gerrit User 32102 <32102@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1 Attention: {"person_ident":"Gerrit User 32102 \u003c32102@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Manpreet Kaur replied on the change"} Attention: {"person_ident":"Gerrit User 33558 \u003c33558@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Manpreet Kaur replied on the change"}
This commit is contained in:
parent
d9f395f2e9
commit
c6ae783cef
|
@ -0,0 +1,67 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "432aa54e_47cd2a89",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 32102
|
||||
},
|
||||
"writtenOn": "2022-04-20T11:15:51Z",
|
||||
"side": 1,
|
||||
"message": "Thanks for your patch, it looks good to me. But there are nit comments. Please look into it.",
|
||||
"revId": "0994b8395d869df7412a2d27cb7543351453c440",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "8787ebe7_2c2d6f64",
|
||||
"filename": "doc/source/user/etsi_vnf_deployment_as_vm_with_user_data.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 171,
|
||||
"author": {
|
||||
"id": 32102
|
||||
},
|
||||
"writtenOn": "2022-04-20T11:15:51Z",
|
||||
"side": 1,
|
||||
"message": "Please add comment, such as \"#Set the fixed IP address to use\"",
|
||||
"range": {
|
||||
"startLine": 171,
|
||||
"startChar": 28,
|
||||
"endLine": 171,
|
||||
"endChar": 39
|
||||
},
|
||||
"revId": "0994b8395d869df7412a2d27cb7543351453c440",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "e023f08d_f598070f",
|
||||
"filename": "doc/source/user/etsi_vnf_deployment_as_vm_with_user_data.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 173,
|
||||
"author": {
|
||||
"id": 32102
|
||||
},
|
||||
"writtenOn": "2022-04-20T11:15:51Z",
|
||||
"side": 1,
|
||||
"message": "Could we keep comment description same as other docs, such as \"#Set the uuid of the subnet to use\" please refer https://docs.openstack.org/tacker/latest/user/practical_sample_package_usage_guide.html.",
|
||||
"range": {
|
||||
"startLine": 173,
|
||||
"startChar": 76,
|
||||
"endLine": 173,
|
||||
"endChar": 101
|
||||
},
|
||||
"revId": "0994b8395d869df7412a2d27cb7543351453c440",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue