From c8a16d752ca4724bb3ff65d371d0bc8155b2ec30 Mon Sep 17 00:00:00 2001 From: Gerrit User 31857 <31857@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Mon, 4 Sep 2023 09:55:55 +0000 Subject: [PATCH] Update patch set 2 Patch Set 2: Code-Review-1 (3 comments) Patch-set: 2 Reviewer: Gerrit User 31857 <31857@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1, 6eb03f4a71b9e41203f406c691118f443c5321a9 --- 1537706567ac1c77c8429ff0e18d7b724b49d9f8 | 63 ++++++++++++++++++++++++ 1 file changed, 63 insertions(+) diff --git a/1537706567ac1c77c8429ff0e18d7b724b49d9f8 b/1537706567ac1c77c8429ff0e18d7b724b49d9f8 index b1b114afe..e926f5d81 100644 --- a/1537706567ac1c77c8429ff0e18d7b724b49d9f8 +++ b/1537706567ac1c77c8429ff0e18d7b724b49d9f8 @@ -16,6 +16,69 @@ "message": "recheck infra-failure", "revId": "1537706567ac1c77c8429ff0e18d7b724b49d9f8", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": false, + "key": { + "uuid": "e3e0accd_06d9ccf5", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 2 + }, + "lineNbr": 0, + "author": { + "id": 31857 + }, + "writtenOn": "2023-09-04T09:55:55Z", + "side": 1, + "message": "Thanks for your patch, please kindly find my comments.", + "revId": "1537706567ac1c77c8429ff0e18d7b724b49d9f8", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "a6e1d778_4e0e0034", + "filename": "tacker/sol_refactored/infra_drivers/kubernetes/kubernetes_resource.py", + "patchSetId": 2 + }, + "lineNbr": 312, + "author": { + "id": 31857 + }, + "writtenOn": "2023-09-04T09:55:55Z", + "side": 1, + "message": "Don\u0027t you need the same fix for the v1 API [1]?\nOr does same problem not occur in v1 API?\n\n[1] https://opendev.org/openstack/tacker/src/branch/master/tacker/vnfm/infra_drivers/kubernetes/kubernetes_driver.py#L378", + "range": { + "startLine": 312, + "startChar": 12, + "endLine": 312, + "endChar": 50 + }, + "revId": "1537706567ac1c77c8429ff0e18d7b724b49d9f8", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "525f6c90_645b6553", + "filename": "tacker/sol_refactored/infra_drivers/kubernetes/kubernetes_resource.py", + "patchSetId": 2 + }, + "lineNbr": 470, + "author": { + "id": 31857 + }, + "writtenOn": "2023-09-04T09:55:55Z", + "side": 1, + "message": "ditto.\n\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/vnfm/infra_drivers/kubernetes/kubernetes_driver.py#L339-L341", + "range": { + "startLine": 466, + "startChar": 12, + "endLine": 470, + "endChar": 62 + }, + "revId": "1537706567ac1c77c8429ff0e18d7b724b49d9f8", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file