openstack
/
tacker
Code Issues Proposed changes

Update patch set 12 

Patch Set 12:

(2 comments)

Patch-set: 12
Attention: {"person_ident":"Gerrit User 25701 \u003c25701@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Yasufumi Ogawa replied on the change"}
Attention: {"person_ident":"Gerrit User 32102 \u003c32102@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Yasufumi Ogawa replied on the change"}
This commit is contained in:
Gerrit User 25701 2022-05-11 14:25:55 +00:00 committed by Gerrit Code Review
parent a117431d9b
commit cdd59fcbc9
1 changed files with 47 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
1dc24894ef8f4423b32066c11ea75f3fa12d116a
View File

@ -57,6 +57,53 @@
"revId": "1dc24894ef8f4423b32066c11ea75f3fa12d116a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "23592fdd_f3f57e70",
"filename": "tacker/api/vnfpkgm/v1/controller.py",
"patchSetId": 12
},
"lineNbr": 300,
"author": {
"id": 25701
},
"writtenOn": "2022-05-11T14:25:55Z",
"side": 1,
"message": "Agree. It\u0027s not wrong, but better to check with \"is not None\" contextually because webob.byterange.Range.parse() returns `end` as None in some cases.",
"parentUuid": "433f6ddf_c0a7a309",
"range": {
"startLine": 300,
"startChar": 12,
"endLine": 300,
"endChar": 26
},
"revId": "1dc24894ef8f4423b32066c11ea75f3fa12d116a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a0d3e736_08636f64",
"filename": "tacker/api/vnfpkgm/v1/controller.py",
"patchSetId": 12
},
"lineNbr": 304,
"author": {
"id": 25701
},
"writtenOn": "2022-05-11T14:25:55Z",
"side": 1,
"message": "nit: Why don\u0027t you use `%d` collectedly although it doable?",
"range": {
"startLine": 304,
"startChar": 32,
"endLine": 304,
"endChar": 34
},
"revId": "1dc24894ef8f4423b32066c11ea75f3fa12d116a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {