openstack
/
tacker
Code Issues Proposed changes

Update patch set 6 

Patch Set 6: Code-Review-1

(4 comments)

Patch-set: 6
Reviewer: Gerrit User 31857 <31857@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
Attention: {"person_ident":"Gerrit User 33492 \u003c33492@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Ayumu Ueha replied on the change"}
Attention: {"person_ident":"Gerrit User 31857 \u003c31857@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Ayumu Ueha replied on the change"}
This commit is contained in:
Gerrit User 31857 2022-04-18 08:58:53 +00:00 committed by Gerrit Code Review
parent bd3392acb9
commit d0644389a1
2 changed files with 88 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
0d3a9ba33f229f9ddf9557c24f79462edeb013b9
View File

@ -47,6 +47,30 @@
"revId": "0d3a9ba33f229f9ddf9557c24f79462edeb013b9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3bb5bf0c_f91ce2bc",
"filename": ".zuul.yaml",
"patchSetId": 5
},
"lineNbr": 442,
"author": {
"id": 31857
},
"writtenOn": "2022-04-18T08:58:53Z",
"side": 1,
"message": "Ack",
"parentUuid": "f54c3de2_b99ac8af",
"range": {
"startLine": 442,
"startChar": 10,
"endLine": 442,
"endChar": 42
},
"revId": "0d3a9ba33f229f9ddf9557c24f79462edeb013b9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -94,6 +118,30 @@
"revId": "0d3a9ba33f229f9ddf9557c24f79462edeb013b9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a0a2356c_d6518442",
"filename": "/COMMIT_MSG",
"patchSetId": 5
},
"lineNbr": 31,
"author": {
"id": 31857
},
"writtenOn": "2022-04-18T08:58:53Z",
"side": 1,
"message": "Ack",
"parentUuid": "f80c5591_7a43df8c",
"range": {
"startLine": 30,
"startChar": 18,
"endLine": 31,
"endChar": 16
},
"revId": "0d3a9ba33f229f9ddf9557c24f79462edeb013b9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {

40
c52343a974b05fe880bd01977bd82641cc0f2a8c
View File

@ -1,5 +1,28 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "298e622f_209c3caf",
"filename": ".zuul.yaml",
"patchSetId": 6
},
"lineNbr": 443,
"author": {
"id": 31857
},
"writtenOn": "2022-04-18T08:58:53Z",
"side": 1,
"message": "Could you wrap lines with 80 characters?",
"range": {
"startLine": 442,
"startChar": 0,
"endLine": 443,
"endChar": 105
},
"revId": "c52343a974b05fe880bd01977bd82641cc0f2a8c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
@ -16,6 +39,23 @@
"message": "To Ayumu Ueha:\nThank you for your comments. I fixed them in PS6.\nPlease kindly check them again.",
"revId": "c52343a974b05fe880bd01977bd82641cc0f2a8c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e1b4b22d_f6a42b47",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 6
},
"lineNbr": 0,
"author": {
"id": 31857
},
"writtenOn": "2022-04-18T08:58:53Z",
"side": 1,
"message": "Thanks for your patch, please kindly confirm additional comment.",
"revId": "c52343a974b05fe880bd01977bd82641cc0f2a8c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}