Update patch set 17
Patch Set 17:
(17 comments)
Patch-set: 17
Attention: {"person_ident":"Gerrit User 31668 \u003c31668@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_31668\u003e replied on the change"}
This commit is contained in:
Gerrit User 31668
Gerrit Code Review
parent
4658dd2da3
commit
d72660d82a
|
|
@ -35,6 +35,24 @@
|
|||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "63d7789b_9fecbee9",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 7,
|
||||
"author": {
|
||||
"id": 31668
|
||||
},
|
||||
"writtenOn": "2023-01-31T07:45:42Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "a2fc4735_65e8a979",
|
||||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -70,6 +88,24 @@
|
|||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "9a1a0fef_2d1d7de2",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 9,
|
||||
"author": {
|
||||
"id": 31668
|
||||
},
|
||||
"writtenOn": "2023-01-31T07:45:42Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "88cd7df5_35c3a26f",
|
||||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -105,6 +141,24 @@
|
|||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "2bbb5ace_6345537b",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 15,
|
||||
"author": {
|
||||
"id": 31668
|
||||
},
|
||||
"writtenOn": "2023-01-31T07:45:42Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "a62a6bbe_d01540ec",
|
||||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -209,6 +263,24 @@
|
|||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "2918e513_f6280395",
|
||||
"filename": "tacker/sol_refactored/common/config.py",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 70,
|
||||
"author": {
|
||||
"id": 31668
|
||||
},
|
||||
"writtenOn": "2023-01-31T07:45:42Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "69a6d1e5_7eeb1c68",
|
||||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -309,6 +381,24 @@
|
|||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "7389ffb9_c4d9a391",
|
||||
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 109,
|
||||
"author": {
|
||||
"id": 31668
|
||||
},
|
||||
"writtenOn": "2023-01-31T07:45:42Z",
|
||||
"side": 1,
|
||||
"message": "Thank you for your explanation. Let me ask you a few more questions.\nIs the stack_id set because there are cases where the stack_id of L.105 is not None?\nOr is it just setting stack_id according to L.114 and it will always be None?\n(I didn\u0027t understand why you didn\u0027t explicitly set None...)",
|
||||
"parentUuid": "93fde6e3_a0c01b72",
|
||||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -379,6 +469,24 @@
|
|||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "e7d0bfe3_8155efa1",
|
||||
"filename": "tacker/tests/functional/sol_v2_az_retry/test_az_retry.py",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 145,
|
||||
"author": {
|
||||
"id": 31668
|
||||
},
|
||||
"writtenOn": "2023-01-31T07:45:42Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "1762e641_94aa5c3a",
|
||||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -414,6 +522,24 @@
|
|||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "bf1458a0_14f7dea7",
|
||||
"filename": "tacker/tests/functional/sol_v2_common/paramgen.py",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 1345,
|
||||
"author": {
|
||||
"id": 31668
|
||||
},
|
||||
"writtenOn": "2023-01-31T07:45:42Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "8fa037c5_41400319",
|
||||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -449,6 +575,24 @@
|
|||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "fbec46c7_fa6bbff9",
|
||||
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/BaseHOT/simple/nested/VDU1.yaml",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 28,
|
||||
"author": {
|
||||
"id": 31668
|
||||
},
|
||||
"writtenOn": "2023-01-31T07:45:42Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "16b32748_50618a2a",
|
||||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -484,6 +628,24 @@
|
|||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "7d82c4c1_46f5e45f",
|
||||
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/BaseHOT/simple/nested/VDU1.yaml",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 29,
|
||||
"author": {
|
||||
"id": 31668
|
||||
},
|
||||
"writtenOn": "2023-01-31T07:45:42Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "82af14b6_30e9c383",
|
||||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -519,6 +681,24 @@
|
|||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "aef528b7_f97c710a",
|
||||
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/BaseHOT/simple/nested/VDU1.yaml",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 42,
|
||||
"author": {
|
||||
"id": 31668
|
||||
},
|
||||
"writtenOn": "2023-01-31T07:45:42Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "7719c89c_dea92df9",
|
||||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -554,6 +734,24 @@
|
|||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "5d967726_83ff6f2e",
|
||||
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/BaseHOT/simple/nested/VDU1.yaml",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 43,
|
||||
"author": {
|
||||
"id": 31668
|
||||
},
|
||||
"writtenOn": "2023-01-31T07:45:42Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "2c728e5d_9e6a3f0c",
|
||||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -589,6 +787,24 @@
|
|||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "d3260698_0619a6a5",
|
||||
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/BaseHOT/simple/sample6.yaml",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 19,
|
||||
"author": {
|
||||
"id": 31668
|
||||
},
|
||||
"writtenOn": "2023-01-31T07:45:42Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "3792ab12_c2ab479d",
|
||||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -624,6 +840,24 @@
|
|||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "97b84ed2_26cc3ec7",
|
||||
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/Definitions/v2_sample6_types.yaml",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 55,
|
||||
"author": {
|
||||
"id": 31668
|
||||
},
|
||||
"writtenOn": "2023-01-31T07:45:42Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "810817a2_d23fd36d",
|
||||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -659,6 +893,24 @@
|
|||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "eaaf4d59_9f75d339",
|
||||
"filename": "tacker/tests/unit/sol_refactored/infra_drivers/openstack/test_openstack.py",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 4216,
|
||||
"author": {
|
||||
"id": 31668
|
||||
},
|
||||
"writtenOn": "2023-01-31T07:45:42Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "5ad39b33_552306b1",
|
||||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -693,6 +945,24 @@
|
|||
"parentUuid": "21608c36_942c7175",
|
||||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "cfda3037_ab574cb8",
|
||||
"filename": "tacker/tests/unit/sol_refactored/infra_drivers/openstack/test_openstack.py",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 4372,
|
||||
"author": {
|
||||
"id": 31668
|
||||
},
|
||||
"writtenOn": "2023-01-31T07:45:42Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "ce25e231_dab09c9a",
|
||||
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
|
|
@ -0,0 +1,38 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "f14c3b23_440200a6",
|
||||
"filename": "roles/setup-multi-az/defaults/main.yaml",
|
||||
"patchSetId": 17
|
||||
},
|
||||
"lineNbr": 3,
|
||||
"author": {
|
||||
"id": 31668
|
||||
},
|
||||
"writtenOn": "2023-01-31T07:45:42Z",
|
||||
"side": 1,
|
||||
"message": "How about using m1.medium(RAM:4096/Disk:20/VCPUs:2)?\nShould the Disk value be 4 instead of 20?",
|
||||
"revId": "cb069e5dbbcb3b6df6ecb35c43bcc732c40d1453",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "3f4ae2bb_9a73cc0e",
|
||||
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/Definitions/v2_sample6_df_simple.yaml",
|
||||
"patchSetId": 17
|
||||
},
|
||||
"lineNbr": 82,
|
||||
"author": {
|
||||
"id": 31668
|
||||
},
|
||||
"writtenOn": "2023-01-31T07:45:42Z",
|
||||
"side": 1,
|
||||
"message": "Could you write a note about the need to review it along with the flavor if there is a change in the Zuul environment in the future?",
|
||||
"revId": "cb069e5dbbcb3b6df6ecb35c43bcc732c40d1453",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue