Update patch set 3

Patch Set 3: Code-Review+1

(4 comments)

Looks good to me Vish. Nicely captured. Few nits.

Patch-set: 3
Label: Code-Review=+1
This commit is contained in:
Gerrit User 13485 2015-10-18 23:43:47 +00:00 committed by Gerrit Code Review
parent 2a0d3d3559
commit e6ea46cebf
1 changed files with 72 additions and 0 deletions

View File

@ -0,0 +1,72 @@
{
"comments": [
{
"key": {
"uuid": "3a29b11f_2c63591c",
"filename": "doc/source/devref/vnfd_template_parameterization.rst",
"patchSetId": 3
},
"lineNbr": 11,
"author": {
"id": 13485
},
"writtenOn": "2015-10-18T23:43:47Z",
"side": 1,
"message": "can the last line be rephrased. i\u0027m unable to understand why deploying a non-parameterized template a second time results in an error? probably a bit elaborate example?",
"revId": "243cfd4578f81f06505f73cd6b1955f8f79b9a80",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a29b11f_2c31190c",
"filename": "doc/source/devref/vnfd_template_parameterization.rst",
"patchSetId": 3
},
"lineNbr": 178,
"author": {
"id": 13485
},
"writtenOn": "2015-10-18T23:43:47Z",
"side": 1,
"message": "can we extend this a bit more to talk about the param-file structure? like the param keyword and the tree structure of the vdus-\u003evdu1 -\u003e...",
"revId": "243cfd4578f81f06505f73cd6b1955f8f79b9a80",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a29b11f_cc7425d1",
"filename": "doc/source/devref/vnfd_template_parameterization.rst",
"patchSetId": 3
},
"lineNbr": 215,
"author": {
"id": 13485
},
"writtenOn": "2015-10-18T23:43:47Z",
"side": 1,
"message": "good to include a vnfd-create command too just to help users.",
"revId": "243cfd4578f81f06505f73cd6b1955f8f79b9a80",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a29b11f_ec43216b",
"filename": "doc/source/devref/vnfd_template_parameterization.rst",
"patchSetId": 3
},
"lineNbr": 216,
"author": {
"id": 13485
},
"writtenOn": "2015-10-18T23:43:47Z",
"side": 1,
"message": "we can mention here that param-file feature is supported on Horizon as well and can briefly describe the workflow. and we could one liner saying user_data and ip_addres templates and param files are provided in samples dir. to try out the feature as examples",
"revId": "243cfd4578f81f06505f73cd6b1955f8f79b9a80",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}