From e99738ff172bb4c656cdd885068122ef9b3407cc Mon Sep 17 00:00:00 2001 From: tpatil Date: Mon, 11 May 2020 08:40:10 +0000 Subject: [PATCH] Revert vim shell script file mode from 644 to 755 In patch [1], the mode of tools/test-setup-default-vim.sh shell script file was changed from 755 to 644 because of which it's fails to run the script which registers a default vim 'VIM0' needed to run for some of the functional tests. This patch reverts back the mode of test-setup-default-vim.sh from 644 to 755 and logs meaningful error message in case the script file doesn't exists or it doesn't have execute permission. [1] : https://review.opendev.org/#/c/674761 Change-Id: I4651bdd89da12720416e630173f80cc788911307 Closes-Bug: #1874007 --- roles/setup-default-vim/tasks/main.yaml | 5 +++++ tools/test-setup-default-vim.sh | 0 2 files changed, 5 insertions(+) mode change 100644 => 100755 tools/test-setup-default-vim.sh diff --git a/roles/setup-default-vim/tasks/main.yaml b/roles/setup-default-vim/tasks/main.yaml index f4f1f07bd..230d170d8 100644 --- a/roles/setup-default-vim/tasks/main.yaml +++ b/roles/setup-default-vim/tasks/main.yaml @@ -14,6 +14,11 @@ stat: path: "{{ zuul_work_dir }}/tools/test-setup-default-vim.sh" register: p +- fail: + msg: > + {{ zuul_work_dir }}/tools/test-setup-default-vim.sh doesn't exists + or it doesn't have execute permission. + when: p.stat.exists != True or p.stat.executable != True - name: Run tools/test-setup-default-vim.sh command: tools/test-setup-default-vim.sh diff --git a/tools/test-setup-default-vim.sh b/tools/test-setup-default-vim.sh old mode 100644 new mode 100755