From e9cb381fe388de174cd2ed4d64d2bda5bb853cb8 Mon Sep 17 00:00:00 2001 From: Gerrit User 34226 <34226@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Wed, 6 Sep 2023 03:59:10 +0000 Subject: [PATCH] Update patch set 2 Patch Set 2: (3 comments) Patch-set: 2 Attention: {"person_ident":"Gerrit User 31857 \u003c31857@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_34226\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 34226 \u003c34226@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_34226\u003e replied on the change"} --- 1537706567ac1c77c8429ff0e18d7b724b49d9f8 | 65 ++++++++++++++++++++++++ 1 file changed, 65 insertions(+) diff --git a/1537706567ac1c77c8429ff0e18d7b724b49d9f8 b/1537706567ac1c77c8429ff0e18d7b724b49d9f8 index e926f5d81..7a826b6d3 100644 --- a/1537706567ac1c77c8429ff0e18d7b724b49d9f8 +++ b/1537706567ac1c77c8429ff0e18d7b724b49d9f8 @@ -34,6 +34,23 @@ "revId": "1537706567ac1c77c8429ff0e18d7b724b49d9f8", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "2c21c7d1_0b4506aa", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 2 + }, + "lineNbr": 0, + "author": { + "id": 34226 + }, + "writtenOn": "2023-09-06T03:59:10Z", + "side": 1, + "message": "Thank you for the review.", + "revId": "1537706567ac1c77c8429ff0e18d7b724b49d9f8", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -57,6 +74,30 @@ "revId": "1537706567ac1c77c8429ff0e18d7b724b49d9f8", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": true, + "key": { + "uuid": "91b1acbe_4d5fecd8", + "filename": "tacker/sol_refactored/infra_drivers/kubernetes/kubernetes_resource.py", + "patchSetId": 2 + }, + "lineNbr": 312, + "author": { + "id": 34226 + }, + "writtenOn": "2023-09-06T03:59:10Z", + "side": 1, + "message": "I think the same fix is needed for the v1 API since the \"service.spec.cluster_ip\" check is the same. Should I fix it in the v1 API too?", + "parentUuid": "a6e1d778_4e0e0034", + "range": { + "startLine": 312, + "startChar": 12, + "endLine": 312, + "endChar": 50 + }, + "revId": "1537706567ac1c77c8429ff0e18d7b724b49d9f8", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -79,6 +120,30 @@ }, "revId": "1537706567ac1c77c8429ff0e18d7b724b49d9f8", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "10310659_5c81f2b8", + "filename": "tacker/sol_refactored/infra_drivers/kubernetes/kubernetes_resource.py", + "patchSetId": 2 + }, + "lineNbr": 470, + "author": { + "id": 34226 + }, + "writtenOn": "2023-09-06T03:59:10Z", + "side": 1, + "message": "I think the same fix is needed, since \"volume_claim_templates\" would be None if \"volume_claim_templates\" is not used in the v1 API too.", + "parentUuid": "525f6c90_645b6553", + "range": { + "startLine": 466, + "startChar": 12, + "endLine": 470, + "endChar": 62 + }, + "revId": "1537706567ac1c77c8429ff0e18d7b724b49d9f8", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file