openstack
/
tacker
Code Issues Proposed changes

Update patch set 11 

Patch Set 11: Code-Review+1

(3 comments)

Patch-set: 11
Reviewer: Gerrit User 31072 <31072@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1
Attention: {"person_ident":"Gerrit User 31072 \u003c31072@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Hiroo Kitamura replied on the change"}
This commit is contained in:
Gerrit User 31072 2022-01-11 01:40:12 +00:00 committed by Gerrit Code Review
parent 68050122f1
commit eb68927eba
2 changed files with 65 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
376324e9cbbf6d246a51021c741863a388b4e15b
View File

@ -81,6 +81,30 @@
"revId": "376324e9cbbf6d246a51021c741863a388b4e15b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "057751e0_09531d4f",
"filename": "tacker/sol_refactored/common/vnfd_utils.py",
"patchSetId": 9
},
"lineNbr": 370,
"author": {
"id": 31072
},
"writtenOn": "2022-01-11T01:40:12Z",
"side": 1,
"message": "Done",
"parentUuid": "c9070bf3_c45c574c",
"range": {
"startLine": 369,
"startChar": 16,
"endLine": 370,
"endChar": 48
},
"revId": "376324e9cbbf6d246a51021c741863a388b4e15b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -127,6 +151,30 @@
},
"revId": "376324e9cbbf6d246a51021c741863a388b4e15b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c177ec97_bb33994e",
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
"patchSetId": 9
},
"lineNbr": 197,
"author": {
"id": 31072
},
"writtenOn": "2022-01-11T01:40:12Z",
"side": 1,
"message": "I see. No problem.",
"parentUuid": "a697a6ec_9a3f33c1",
"range": {
"startLine": 197,
"startChar": 8,
"endLine": 197,
"endChar": 17
},
"revId": "376324e9cbbf6d246a51021c741863a388b4e15b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

17
521b10e36588a48396385e07e1b709a118764be8
View File

@ -16,6 +16,23 @@
"message": "recheck",
"revId": "521b10e36588a48396385e07e1b709a118764be8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "0f60efe3_d844231c",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 11
},
"lineNbr": 0,
"author": {
"id": 31072
},
"writtenOn": "2022-01-11T01:40:12Z",
"side": 1,
"message": "LGTM",
"revId": "521b10e36588a48396385e07e1b709a118764be8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}