openstack
/
tacker
Code Issues Proposed changes

Update patch set 4 

Patch Set 4: Code-Review+2

(4 comments)

Patch-set: 4
Reviewer: Gerrit User 31857 <31857@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2
Attention: {"person_ident":"Gerrit User 31857 \u003c31857@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Ayumu Ueha replied on the change"}
This commit is contained in:
Gerrit User 31857 2022-01-20 05:51:20 +00:00 committed by Gerrit Code Review
parent 0715dd32bf
commit ee574b8682
2 changed files with 83 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
3e029e698f403bd996f7994bbee6a833b69ac700
View File

@ -17,6 +17,24 @@
"revId": "3e029e698f403bd996f7994bbee6a833b69ac700",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "9b64faee_ecba2279",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 31857
},
"writtenOn": "2022-01-20T05:51:20Z",
"side": 1,
"message": "I\u0027ve confirmed in PS3.",
"parentUuid": "e82a7723_6da4f1cf",
"revId": "3e029e698f403bd996f7994bbee6a833b69ac700",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
@ -81,6 +99,30 @@
"revId": "3e029e698f403bd996f7994bbee6a833b69ac700",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f58bddfa_2e1e13ea",
"filename": "tacker/sol_refactored/controller/vnflcm_view.py",
"patchSetId": 2
},
"lineNbr": 96,
"author": {
"id": 31857
},
"writtenOn": "2022-01-20T05:51:20Z",
"side": 1,
"message": "I\u0027ve confirmed in PS3.",
"parentUuid": "9acb090a_1e68c8a7",
"range": {
"startLine": 96,
"startChar": 20,
"endLine": 96,
"endChar": 41
},
"revId": "3e029e698f403bd996f7994bbee6a833b69ac700",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -104,6 +146,30 @@
"revId": "3e029e698f403bd996f7994bbee6a833b69ac700",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2615526f_91263008",
"filename": "tacker/sol_refactored/controller/vnflcm_view.py",
"patchSetId": 2
},
"lineNbr": 100,
"author": {
"id": 31857
},
"writtenOn": "2022-01-20T05:51:20Z",
"side": 1,
"message": "I\u0027ve confirmed in PS3.",
"parentUuid": "7b6f7628_345dce37",
"range": {
"startLine": 100,
"startChar": 20,
"endLine": 100,
"endChar": 56
},
"revId": "3e029e698f403bd996f7994bbee6a833b69ac700",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {

17
f9547f5e433626e807dc151fb934f9d908c472cf
View File

@ -16,6 +16,23 @@
"message": "I tweaked the commit message. How about this?",
"revId": "f9547f5e433626e807dc151fb934f9d908c472cf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "5fcb2ce9_758bb349",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 4
},
"lineNbr": 0,
"author": {
"id": 31857
},
"writtenOn": "2022-01-20T05:51:20Z",
"side": 1,
"message": "LGTM, Thanks for your re-work.",
"revId": "f9547f5e433626e807dc151fb934f9d908c472cf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}