Update patch set 14

Patch Set 14:

(2 comments)

Patch-set: 14
Attention: {"person_ident":"Gerrit User 31668 \u003c31668@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_31857\u003e replied on the change"}
This commit is contained in:
Gerrit User 31857 2024-03-14 09:16:07 +00:00 committed by Gerrit Code Review
parent 4a15bbc1ba
commit f096ec21d5
1 changed files with 36 additions and 0 deletions

View File

@ -17,6 +17,24 @@
"revId": "a0005c860989a656f5fb6bb07715f469f35cb79e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6181c956_e717b539",
"filename": "/COMMIT_MSG",
"patchSetId": 12
},
"lineNbr": 19,
"author": {
"id": 31857
},
"writtenOn": "2024-03-14T09:16:07Z",
"side": 1,
"message": "I have fixed it in PatchSet13.",
"parentUuid": "00514fb8_a206c468",
"revId": "a0005c860989a656f5fb6bb07715f469f35cb79e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
@ -67,6 +85,24 @@
"message": "\"ceilometer\" is left in the comment below, is there no problem?\n* https://opendev.org/openstack/tacker/src/branch/master/roles/ensure-db-cli-installed/tasks/main.yaml#L3\n```\n# Currently the plugins which implicitly require db cli to be\n# pre-installed when the database is remote (i.e., MYSQL_HOST\n# !\u003d host-where-it-is-enabled) is only ceilometer. So it\u0027d be\n# more accurate to set the outermost \u0027when\u0027 condition like:\n#\n# when:\n# - devstack_plugins[\u0027ceilometer\u0027] | default(false)\n# - devstack_localrc[\u0027DATABASE_TYPE\u0027] is defined\n```\n\nIs it okay to leave the following settings as it is?\n* https://opendev.org/openstack/tacker/src/branch/master/doc/source/install/manual_installation.rst?display\u003dsource#L239\n```\n [tacker]\n monitor_driver \u003d ping,http_ping\n```",
"revId": "a0005c860989a656f5fb6bb07715f469f35cb79e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b5567b35_2d873a39",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 12
},
"lineNbr": 0,
"author": {
"id": 31857
},
"writtenOn": "2024-03-14T09:16:07Z",
"side": 1,
"message": "Thanks for your pointing out, I have removed the comment and the setting of document in PatchSet13.",
"parentUuid": "2afd07f9_ec096084",
"revId": "a0005c860989a656f5fb6bb07715f469f35cb79e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}