openstack
/
tacker
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(2 comments)

Few minor comments as below.

Patch-set: 1
Label: Code-Review=-1
This commit is contained in:
Gerrit User 17952 2015-10-17 06:19:44 +00:00 committed by Gerrit Code Review
parent 0d4840148e
commit f146d06e21
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
9df5d9fcc27202dbac8344b81e5aad55d8b0508b Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "5a2ca52d_e0a7e7ba",
"filename": "tacker/tests/etc/samples/sample_cirros_vnf_param.yaml",
"patchSetId": 1
},
"lineNbr": 8,
"author": {
"id": 17952
},
"writtenOn": "2015-10-17T06:19:44Z",
"side": 1,
"message": "Can you please remove the white spaces in end of yaml file",
"revId": "9df5d9fcc27202dbac8344b81e5aad55d8b0508b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a2ca52d_a0848f0a",
"filename": "tacker/tests/functional/vnfd/test_vnf_param.py",
"patchSetId": 1
},
"lineNbr": 55,
"author": {
"id": 17952
},
"writtenOn": "2015-10-17T06:19:44Z",
"side": 1,
"message": "Can you please move this constant \"VNF_CIRROS_CREATE_TIMEOUT\" as class constant declared above the class.",
"revId": "9df5d9fcc27202dbac8344b81e5aad55d8b0508b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}