Update patch set 5
Patch Set 5: Code-Review-1 (3 comments) Patch-set: 5 Reviewer: Gerrit User 31857 <31857@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1 Attention: {"person_ident":"Gerrit User 33558 \u003c33558@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Ayumu Ueha replied on the change"} Attention: {"person_ident":"Gerrit User 31857 \u003c31857@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Ayumu Ueha replied on the change"}
This commit is contained in:
parent
c8892bd09b
commit
f31542ac4b
|
@ -1,5 +1,51 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "10b2d8cb_538f1865",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 7,
|
||||
"author": {
|
||||
"id": 31857
|
||||
},
|
||||
"writtenOn": "2022-04-28T06:53:11Z",
|
||||
"side": 1,
|
||||
"message": "looking at your fix, I think `ipAddresses` is correct.\n\nI understand that when it in processing, it will be converted to snake_case and become \u0027ip_addresses\u0027, but I think \u0027ipAddresses\u0027 is correct to add to example file.",
|
||||
"range": {
|
||||
"startLine": 7,
|
||||
"startChar": 1,
|
||||
"endLine": 7,
|
||||
"endChar": 13
|
||||
},
|
||||
"revId": "38fe6304944c7058222493474c1a232978cc29cb",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "ff38a9a6_0c8d0a03",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 9,
|
||||
"author": {
|
||||
"id": 31857
|
||||
},
|
||||
"writtenOn": "2022-04-28T06:53:11Z",
|
||||
"side": 1,
|
||||
"message": "ditto.",
|
||||
"range": {
|
||||
"startLine": 9,
|
||||
"startChar": 5,
|
||||
"endLine": 9,
|
||||
"endChar": 17
|
||||
},
|
||||
"revId": "38fe6304944c7058222493474c1a232978cc29cb",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
|
@ -16,6 +62,23 @@
|
|||
"message": "Thanks for rework. LGTM!",
|
||||
"revId": "38fe6304944c7058222493474c1a232978cc29cb",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "861d20c2_ee969e01",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 31857
|
||||
},
|
||||
"writtenOn": "2022-04-28T06:53:11Z",
|
||||
"side": 1,
|
||||
"message": "Thanks for your patch, please kindly find my comment.",
|
||||
"revId": "38fe6304944c7058222493474c1a232978cc29cb",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue