openstack
/
tacker
Code Issues Proposed changes

Update patch set 9 

Patch Set 9: Code-Review-1

(16 comments)

Patch-set: 9
Reviewer: Gerrit User 31072 <31072@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
Attention: {"person_ident":"Gerrit User 31072 \u003c31072@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Hiroo Kitamura replied on the change"}
This commit is contained in:
Gerrit User 31072 2022-04-21 04:08:01 +00:00 committed by Gerrit Code Review
parent 2a9a842667
commit f466c965dd
2 changed files with 314 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

150
1489b2d91882ca44d446b5270ace3c094f22f770
View File

@ -35,6 +35,24 @@
"revId": "1489b2d91882ca44d446b5270ace3c094f22f770",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "de9e601c_77baed80",
"filename": ".zuul.yaml",
"patchSetId": 5
},
"lineNbr": 591,
"author": {
"id": 31072
},
"writtenOn": "2022-04-21T04:08:01Z",
"side": 1,
"message": "Done",
"parentUuid": "62b7a476_863aaa93",
"revId": "1489b2d91882ca44d446b5270ace3c094f22f770",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -82,6 +100,30 @@
"revId": "1489b2d91882ca44d446b5270ace3c094f22f770",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "25598b70_65c886fe",
"filename": "/COMMIT_MSG",
"patchSetId": 5
},
"lineNbr": 24,
"author": {
"id": 31072
},
"writtenOn": "2022-04-21T04:08:01Z",
"side": 1,
"message": "Done",
"parentUuid": "1ed76c1a_fc68c8c7",
"range": {
"startLine": 18,
"startChar": 0,
"endLine": 24,
"endChar": 20
},
"revId": "1489b2d91882ca44d446b5270ace3c094f22f770",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -117,6 +159,42 @@
"revId": "1489b2d91882ca44d446b5270ace3c094f22f770",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "54783987_3ca8a039",
"filename": "tacker/tests/functional/common/fake_grant_server.py",
"patchSetId": 5
},
"lineNbr": 1,
"author": {
"id": 31072
},
"writtenOn": "2022-04-21T04:08:01Z",
"side": 1,
"message": "Done",
"parentUuid": "ff618792_d5f27ecd",
"revId": "1489b2d91882ca44d446b5270ace3c094f22f770",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "4d8d516c_74d353be",
"filename": "tacker/tests/functional/common/fake_grant_server.py",
"patchSetId": 5
},
"lineNbr": 1,
"author": {
"id": 31072
},
"writtenOn": "2022-04-21T04:08:01Z",
"side": 1,
"message": "Done",
"parentUuid": "ff618792_d5f27ecd",
"revId": "1489b2d91882ca44d446b5270ace3c094f22f770",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -152,6 +230,24 @@
"revId": "1489b2d91882ca44d446b5270ace3c094f22f770",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "02817c08_c5a65090",
"filename": "tacker/tests/functional/common/fake_nfvo_config.yaml",
"patchSetId": 5
},
"lineNbr": 1,
"author": {
"id": 31072
},
"writtenOn": "2022-04-21T04:08:01Z",
"side": 1,
"message": "Done",
"parentUuid": "4ed37f15_923fa3b4",
"revId": "1489b2d91882ca44d446b5270ace3c094f22f770",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -187,6 +283,24 @@
"revId": "1489b2d91882ca44d446b5270ace3c094f22f770",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a54f725d_cb71c357",
"filename": "tacker/tests/functional/sol_separated_nfvo_v2/fake_grant_v2.py",
"patchSetId": 5
},
"lineNbr": 1,
"author": {
"id": 31072
},
"writtenOn": "2022-04-21T04:08:01Z",
"side": 1,
"message": "Done",
"parentUuid": "d30d9d07_f503e300",
"revId": "1489b2d91882ca44d446b5270ace3c094f22f770",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -222,6 +336,24 @@
"revId": "1489b2d91882ca44d446b5270ace3c094f22f770",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d9521b4d_37fe5b85",
"filename": "tacker/tests/functional/sol_separated_nfvo_v2/fake_vnfpkgm_v2.py",
"patchSetId": 5
},
"lineNbr": 1,
"author": {
"id": 31072
},
"writtenOn": "2022-04-21T04:08:01Z",
"side": 1,
"message": "Done",
"parentUuid": "5d82b350_6a9c4a4c",
"revId": "1489b2d91882ca44d446b5270ace3c094f22f770",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -256,6 +388,24 @@
"parentUuid": "804c895a_da6bad49",
"revId": "1489b2d91882ca44d446b5270ace3c094f22f770",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a27fc38c_ca2dff25",
"filename": "tacker/tests/functional/sol_separated_nfvo_v2/test_nfvo_separate_v2.py",
"patchSetId": 5
},
"lineNbr": 1,
"author": {
"id": 31072
},
"writtenOn": "2022-04-21T04:08:01Z",
"side": 1,
"message": "Done",
"parentUuid": "cf7f7699_013c95db",
"revId": "1489b2d91882ca44d446b5270ace3c094f22f770",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

164
3e7a5834c29d7a920d4dde327e65514abd618e43 Normal file
View File

@ -0,0 +1,164 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "05a60879_e4e52275",
"filename": "tacker/tests/functional/sol_v2/test_vnflcm_basic.py",
"patchSetId": 9
},
"lineNbr": 218,
"author": {
"id": 31072
},
"writtenOn": "2022-04-21T04:08:01Z",
"side": 1,
"message": "I think it is better to delete this description and describe it in \"test_vnflcm_basic_common.py\".",
"range": {
"startLine": 175,
"startChar": 8,
"endLine": 218,
"endChar": 15
},
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "66258914_b3bc7d6a",
"filename": "tacker/tests/functional/sol_v2/test_vnflcm_basic.py",
"patchSetId": 9
},
"lineNbr": 252,
"author": {
"id": 31072
},
"writtenOn": "2022-04-21T04:08:01Z",
"side": 1,
"message": "ditto",
"range": {
"startLine": 222,
"startChar": 8,
"endLine": 252,
"endChar": 11
},
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0a7faeec_0d7de416",
"filename": "tacker/tests/functional/sol_v2/test_vnflcm_error_handling.py",
"patchSetId": 9
},
"lineNbr": 102,
"author": {
"id": 31072
},
"writtenOn": "2022-04-21T04:08:01Z",
"side": 1,
"message": "I think it is better to delete this description and describe it in \"test_vnflcm_basic_common.py\".",
"range": {
"startLine": 74,
"startChar": 8,
"endLine": 102,
"endChar": 11
},
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3f616720_a02c6193",
"filename": "tacker/tests/functional/sol_v2/test_vnflcm_error_handling.py",
"patchSetId": 9
},
"lineNbr": 301,
"author": {
"id": 31072
},
"writtenOn": "2022-04-21T04:08:01Z",
"side": 1,
"message": "ditto",
"range": {
"startLine": 281,
"startChar": 8,
"endLine": 301,
"endChar": 11
},
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "77fd1244_dbca4f99",
"filename": "tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py",
"patchSetId": 9
},
"lineNbr": 89,
"author": {
"id": 31072
},
"writtenOn": "2022-04-21T04:08:01Z",
"side": 1,
"message": "How about setting the default argument \"is_nfvo\u003dFalse\"?\nThen you can omit the argument in the test under \"sol_v2\".",
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "24248035_d52b12aa",
"filename": "tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py",
"patchSetId": 9
},
"lineNbr": 328,
"author": {
"id": 31072
},
"writtenOn": "2022-04-21T04:08:01Z",
"side": 1,
"message": "It branches according to the value of \"is_nfvo\", but unlike other places, I don\u0027t think it is a necessary branch.\nIf \"is_nfvo\u003dTrue\", there is no special confirmation point of view compared to \"is_nfvo\u003dFalse\", so it is omitted.\nI think the execution time of this process is short, so it\u0027s better to delete this branch for the purpose of simplification of the test.\nWhat do you think?",
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a1aa34b8_807b295e",
"filename": "tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py",
"patchSetId": 9
},
"lineNbr": 413,
"author": {
"id": 31072
},
"writtenOn": "2022-04-21T04:08:01Z",
"side": 1,
"message": "ditto",
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4e985288_429695ba",
"filename": "tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py",
"patchSetId": 9
},
"lineNbr": 1185,
"author": {
"id": 31072
},
"writtenOn": "2022-04-21T04:08:01Z",
"side": 1,
"message": "There are many if branches based on the value of \"is_nfvo\", which makes readability worse.\nIt\u0027s better to move the process to \"Pre setting\" whenever possible, as shown below.\n```\ndiff --git a/tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py b/tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py\nindex 2e6f2d82..106c3c60 100644\n--- a/tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py\n+++ b/tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py\n@@ -1205,6 +1205,67 @@ class CommonVnfLcmTest(base_v2.BaseSolV2Test):\n basic_lcms_min_path, vnfd_path)\n zone_name_list \u003d self.get_zone_list()\n\n+ # Set Fake server response for Grant-Req(Instantiate)\n+ base_v2.FAKE_SERVER_MANAGER.set_callback(\u0027POST\u0027,\n+ fake_grant_v2.GrantV2.GRANT_REQ_PATH,\n+ status_code\u003d201,\n+ response_headers\u003d{\"Content-Type\": \"application/json\"},\n+ callback\u003dlambda req_headers,\n+ req_body: fake_grant_v2.GrantV2.make_inst_response_body(\n+ req_body, glance_image, flavour_vdu_dict, zone_name_list))\n...snip...\n+ # Set Fake server response for Grant-Req(Terminate)\n+ base_v2.FAKE_SERVER_MANAGER.set_callback(\u0027POST\u0027,\n+ fake_grant_v2.GrantV2.GRANT_REQ_PATH,\n+ status_code\u003d201,\n+ response_headers\u003d{\"Content-Type\": \"application/json\"},\n+ callback\u003dlambda req_headers,\n+ req_body: fake_grant_v2.GrantV2.make_term_response_body(\n+ req_body))\n+\n+ # create requests\n+ create_req \u003d paramgen.create_vnf_min(vnfd_id_1)\n+ update_req \u003d paramgen.update_vnf_min_with_parameter(vnfd_id_2)\n+ else:\n+ # create requests\n+ create_req \u003d paramgen.create_vnf_min(self.vnfd_id_2)\n+ update_req \u003d paramgen.update_vnf_min_with_parameter(self.vnfd_id_3)\n+\n # 1. Create subscription\n callback_url \u003d os.path.join(base_v2.MOCK_NOTIFY_CALLBACK_URL,\n self._testMethodName)\n```",
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}