Remove the skip line in this file, and make some changes to
make them pass.
Partially Implements: blueprint test-addition-refactoring
Change-Id: I6b747da14bc743dbd2b79a6629e761d316de629f
oslo_messaging's rpc_backend setting, which is set by
ConfFixture.transport_driver has been deprecated since Newton. To allow
oslo_messaging to remove it, switch to setting transport_url instead.
Change-Id: Ic8a137794ac0805a4e5890bda9eb2740f2bf9d76
Partial-Bug: #1712399
In case of create VIM API, is_default_parameter accepts any string
values like "abc" or "1234" and set the value as True. It should
strictly check for valid boolean values.
Fixed this issue by using convert_to_boolean validator. so now, if
you pass any non-boolean value, it will return 400 error to the user.
NOTE:
The below test case fails if we inherit the test class
'..tests.unit.base.TestCase' from '..tests.base.BaseTestCase' with
KeyError:
tacker.tests.unit.nfvo.test_nfvo_plugin.TestNfvoPlugin.
test_create_ns_workflow_no_task_exception
The reason behind the failure is, the raised exception
'..extensions.nfvo.NoTasksException' expects that the 'action' and
'resource' should be passed as arguments to the exception while raising
it to form the exception message. If you don't pass these two arguments
then it fails to form the exception message and raises KeyError.
This happens because the '..tests.base.BaseTestCase' test class uses
exception fixture and sets 'use_fatal_exceptions' to True always which
results into not raising the raised exception again and it tries to
form the exception message and pass it to the base class __init__ for
further processing. It fails and raises KeyError while forming that
exception message because in 'test_create_ns_workflow_no_task_exception'
test case these arguments are not passed to the exception while
raising.
To fix this test case, passed the required 'action' and 'resource'
arguments to the exception while raising it.
DocImpact
Closes-Bug: #1746538
Change-Id: Ib533b38a48d31cb26eecdc546b20b0f99beeaa34
1.As mentioned in [1], we should avoid using
six.iteritems to achieve iterators.
We can use dict.items instead, as it will return
iterators in PY3 as well. And dict.items/keys will more readable.
2.In py2, the performance about list should be negligible, see the link [2].
[1] https://wiki.openstack.org/wiki/Python3
[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html
Fixed the Error in the file openwrt.py continuation line over-indented
for visual indent.
Change-Id: Ia1d5e6a73112f7093fccc4aa0d541250439193be
This Patch fixes all E265 errors and
enables this test for all new patches to tacker.
E265 block comment should start with ‘# ‘
see OpenStack Style Guidelines
http://docs.openstack.org/developer/hacking/
Change-Id: I4b1234fab420174d99b2c13a5b25c1f7c5d4909f
Related-Bug: 1515930
Zuul