# Copyright (c) 2014 OpenStack Foundation. # # Licensed under the Apache License, Version 2.0 (the "License"); you may # not use this file except in compliance with the License. You may obtain # a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, WITHOUT # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. import pycodestyle import re from hacking import core """ Guidelines for writing new hacking checks - Use only for Tacker specific tests. OpenStack general tests should be submitted to the common 'hacking' module. - Pick numbers in the range N3xx. Find the current test with the highest allocated number and then pick the next value. - Keep the test method code in the source file ordered based on the N3xx value. - List the new rule in the top level HACKING.rst file - Add test cases for each new rule to tacker/tests/unit/test_hacking.py """ log_translation = re.compile( r"(.)*LOG\.(audit|error|info|warn|warning|critical|exception)\(\s*('|\")") @core.flake8ext def validate_log_translations(physical_line, logical_line, filename): # Translations are not required in the test directory if "tacker/tests" in filename: return if pycodestyle.noqa(physical_line): return msg = "N320: Log messages require translations!" if log_translation.match(logical_line): yield (0, msg)