{ "comments": [ { "unresolved": true, "key": { "uuid": "ad2224e9_4c407632", "filename": ".zuul.yaml", "patchSetId": 5 }, "lineNbr": 591, "author": { "id": 31072 }, "writtenOn": "2022-04-07T02:40:35Z", "side": 1, "message": "Nit: It’s better to define it one line above according to the order of V1 jobs.", "revId": "1489b2d91882ca44d446b5270ace3c094f22f770", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "62b7a476_863aaa93", "filename": ".zuul.yaml", "patchSetId": 5 }, "lineNbr": 591, "author": { "id": 33492 }, "writtenOn": "2022-04-18T05:45:56Z", "side": 1, "message": "I fixed it in PS7.", "parentUuid": "ad2224e9_4c407632", "revId": "1489b2d91882ca44d446b5270ace3c094f22f770", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "de9e601c_77baed80", "filename": ".zuul.yaml", "patchSetId": 5 }, "lineNbr": 591, "author": { "id": 31072 }, "writtenOn": "2022-04-21T04:08:01Z", "side": 1, "message": "Done", "parentUuid": "62b7a476_863aaa93", "revId": "1489b2d91882ca44d446b5270ace3c094f22f770", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "4142533c_d8f93966", "filename": "/COMMIT_MSG", "patchSetId": 5 }, "lineNbr": 24, "author": { "id": 31072 }, "writtenOn": "2022-04-07T02:40:35Z", "side": 1, "message": "These bugs are fixed in the below patch.\nhttps://review.opendev.org/c/openstack/tacker/+/835784\nSo, you don\u0027t have to fix these in this patch.", "range": { "startLine": 18, "startChar": 0, "endLine": 24, "endChar": 20 }, "revId": "1489b2d91882ca44d446b5270ace3c094f22f770", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "1ed76c1a_fc68c8c7", "filename": "/COMMIT_MSG", "patchSetId": 5 }, "lineNbr": 24, "author": { "id": 33492 }, "writtenOn": "2022-04-18T05:45:56Z", "side": 1, "message": "I deleted this change and added a dependency for my patch.", "parentUuid": "4142533c_d8f93966", "range": { "startLine": 18, "startChar": 0, "endLine": 24, "endChar": 20 }, "revId": "1489b2d91882ca44d446b5270ace3c094f22f770", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "25598b70_65c886fe", "filename": "/COMMIT_MSG", "patchSetId": 5 }, "lineNbr": 24, "author": { "id": 31072 }, "writtenOn": "2022-04-21T04:08:01Z", "side": 1, "message": "Done", "parentUuid": "1ed76c1a_fc68c8c7", "range": { "startLine": 18, "startChar": 0, "endLine": 24, "endChar": 20 }, "revId": "1489b2d91882ca44d446b5270ace3c094f22f770", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "9a65358d_c2e7d91c", "filename": "tacker/tests/functional/common/fake_grant_server.py", "patchSetId": 5 }, "lineNbr": 1, "author": { "id": 31072 }, "writtenOn": "2022-04-07T02:40:35Z", "side": 1, "message": "It seems that the Copyright notation is missing.", "revId": "1489b2d91882ca44d446b5270ace3c094f22f770", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "ff618792_d5f27ecd", "filename": "tacker/tests/functional/common/fake_grant_server.py", "patchSetId": 5 }, "lineNbr": 1, "author": { "id": 33492 }, "writtenOn": "2022-04-18T05:45:56Z", "side": 1, "message": "I fixed it in PS7.", "parentUuid": "9a65358d_c2e7d91c", "revId": "1489b2d91882ca44d446b5270ace3c094f22f770", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "54783987_3ca8a039", "filename": "tacker/tests/functional/common/fake_grant_server.py", "patchSetId": 5 }, "lineNbr": 1, "author": { "id": 31072 }, "writtenOn": "2022-04-21T04:08:01Z", "side": 1, "message": "Done", "parentUuid": "ff618792_d5f27ecd", "revId": "1489b2d91882ca44d446b5270ace3c094f22f770", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "4d8d516c_74d353be", "filename": "tacker/tests/functional/common/fake_grant_server.py", "patchSetId": 5 }, "lineNbr": 1, "author": { "id": 31072 }, "writtenOn": "2022-04-21T04:08:01Z", "side": 1, "message": "Done", "parentUuid": "ff618792_d5f27ecd", "revId": "1489b2d91882ca44d446b5270ace3c094f22f770", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "d17ca125_d7476c05", "filename": "tacker/tests/functional/common/fake_nfvo_config.yaml", "patchSetId": 5 }, "lineNbr": 1, "author": { "id": 31072 }, "writtenOn": "2022-04-07T02:40:35Z", "side": 1, "message": "Why manage this information in a yaml file?\nUnless you have a specific reason, you can define it directly in \"tacker/tests/functional/common/fake_grant_server.py\".", "revId": "1489b2d91882ca44d446b5270ace3c094f22f770", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "4ed37f15_923fa3b4", "filename": "tacker/tests/functional/common/fake_nfvo_config.yaml", "patchSetId": 5 }, "lineNbr": 1, "author": { "id": 33492 }, "writtenOn": "2022-04-18T05:45:56Z", "side": 1, "message": "I deleted this file in PS7.\nWhen we use sperated NFVO in local, we should know which vnf package we should return to tacker. so I set this config file.\nI have moved this parameter to fake_grant_server.py", "parentUuid": "d17ca125_d7476c05", "revId": "1489b2d91882ca44d446b5270ace3c094f22f770", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "02817c08_c5a65090", "filename": "tacker/tests/functional/common/fake_nfvo_config.yaml", "patchSetId": 5 }, "lineNbr": 1, "author": { "id": 31072 }, "writtenOn": "2022-04-21T04:08:01Z", "side": 1, "message": "Done", "parentUuid": "4ed37f15_923fa3b4", "revId": "1489b2d91882ca44d446b5270ace3c094f22f770", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "ed2a16d5_f4a8b6b2", "filename": "tacker/tests/functional/sol_separated_nfvo_v2/fake_grant_v2.py", "patchSetId": 5 }, "lineNbr": 1, "author": { "id": 31072 }, "writtenOn": "2022-04-07T02:40:35Z", "side": 1, "message": "It seems that the Copyright notation is missing.", "revId": "1489b2d91882ca44d446b5270ace3c094f22f770", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "d30d9d07_f503e300", "filename": "tacker/tests/functional/sol_separated_nfvo_v2/fake_grant_v2.py", "patchSetId": 5 }, "lineNbr": 1, "author": { "id": 33492 }, "writtenOn": "2022-04-18T05:45:56Z", "side": 1, "message": "I fixed it in PS7.", "parentUuid": "ed2a16d5_f4a8b6b2", "revId": "1489b2d91882ca44d446b5270ace3c094f22f770", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "a54f725d_cb71c357", "filename": "tacker/tests/functional/sol_separated_nfvo_v2/fake_grant_v2.py", "patchSetId": 5 }, "lineNbr": 1, "author": { "id": 31072 }, "writtenOn": "2022-04-21T04:08:01Z", "side": 1, "message": "Done", "parentUuid": "d30d9d07_f503e300", "revId": "1489b2d91882ca44d446b5270ace3c094f22f770", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "787604d7_2dd57672", "filename": "tacker/tests/functional/sol_separated_nfvo_v2/fake_vnfpkgm_v2.py", "patchSetId": 5 }, "lineNbr": 1, "author": { "id": 31072 }, "writtenOn": "2022-04-07T02:40:35Z", "side": 1, "message": "It seems that the Copyright notation is missing.", "revId": "1489b2d91882ca44d446b5270ace3c094f22f770", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "5d82b350_6a9c4a4c", "filename": "tacker/tests/functional/sol_separated_nfvo_v2/fake_vnfpkgm_v2.py", "patchSetId": 5 }, "lineNbr": 1, "author": { "id": 33492 }, "writtenOn": "2022-04-18T05:45:56Z", "side": 1, "message": "I fixed it in PS7.", "parentUuid": "787604d7_2dd57672", "revId": "1489b2d91882ca44d446b5270ace3c094f22f770", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "d9521b4d_37fe5b85", "filename": "tacker/tests/functional/sol_separated_nfvo_v2/fake_vnfpkgm_v2.py", "patchSetId": 5 }, "lineNbr": 1, "author": { "id": 31072 }, "writtenOn": "2022-04-21T04:08:01Z", "side": 1, "message": "Done", "parentUuid": "5d82b350_6a9c4a4c", "revId": "1489b2d91882ca44d446b5270ace3c094f22f770", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "804c895a_da6bad49", "filename": "tacker/tests/functional/sol_separated_nfvo_v2/test_nfvo_separate_v2.py", "patchSetId": 5 }, "lineNbr": 1, "author": { "id": 31072 }, "writtenOn": "2022-04-07T02:40:35Z", "side": 1, "message": "It seems that the Copyright notation is missing.", "revId": "1489b2d91882ca44d446b5270ace3c094f22f770", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "cf7f7699_013c95db", "filename": "tacker/tests/functional/sol_separated_nfvo_v2/test_nfvo_separate_v2.py", "patchSetId": 5 }, "lineNbr": 1, "author": { "id": 33492 }, "writtenOn": "2022-04-18T05:45:56Z", "side": 1, "message": "I fixed it in PS7.", "parentUuid": "804c895a_da6bad49", "revId": "1489b2d91882ca44d446b5270ace3c094f22f770", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "a27fc38c_ca2dff25", "filename": "tacker/tests/functional/sol_separated_nfvo_v2/test_nfvo_separate_v2.py", "patchSetId": 5 }, "lineNbr": 1, "author": { "id": 31072 }, "writtenOn": "2022-04-21T04:08:01Z", "side": 1, "message": "Done", "parentUuid": "cf7f7699_013c95db", "revId": "1489b2d91882ca44d446b5270ace3c094f22f770", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] }