815 lines
24 KiB
Plaintext
815 lines
24 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "64c2ab06_be6134b6",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 4149
|
|
},
|
|
"writtenOn": "2022-01-05T01:52:39Z",
|
|
"side": 1,
|
|
"message": "recheck",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "7bacc44b_a52c5ef6",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 4149
|
|
},
|
|
"writtenOn": "2022-01-06T00:13:49Z",
|
|
"side": 1,
|
|
"message": "Thank you for the review.",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "a3e38c70_3a306ce5",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 4149
|
|
},
|
|
"writtenOn": "2022-01-06T02:57:05Z",
|
|
"side": 1,
|
|
"message": "Thank you for the review.",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "8411c8e3_03b28e70",
|
|
"filename": "tacker/sol_refactored/common/lcm_op_occ_utils.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 229,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2022-01-06T02:03:04Z",
|
|
"side": 1,
|
|
"message": "typo: resoueceHandle -\u003e resourceHandle",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "847c21cf_739c3072",
|
|
"filename": "tacker/sol_refactored/common/lcm_op_occ_utils.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 229,
|
|
"author": {
|
|
"id": 4149
|
|
},
|
|
"writtenOn": "2022-01-06T02:57:05Z",
|
|
"side": 1,
|
|
"message": "Thank you for pointing it out. I will fix.",
|
|
"parentUuid": "8411c8e3_03b28e70",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "c6bb995b_84caca33",
|
|
"filename": "tacker/sol_refactored/common/lcm_op_occ_utils.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 229,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2022-01-06T04:56:43Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "847c21cf_739c3072",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "d0daf6d8_73f0745b",
|
|
"filename": "tacker/sol_refactored/common/lcm_op_occ_utils.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 243,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2022-01-06T02:03:04Z",
|
|
"side": 1,
|
|
"message": "typo: resoueceHandle -\u003e resourceHandle",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "92d609d3_47593465",
|
|
"filename": "tacker/sol_refactored/common/lcm_op_occ_utils.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 243,
|
|
"author": {
|
|
"id": 4149
|
|
},
|
|
"writtenOn": "2022-01-06T02:57:05Z",
|
|
"side": 1,
|
|
"message": "I will fix.",
|
|
"parentUuid": "d0daf6d8_73f0745b",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "211c3bd1_21165b64",
|
|
"filename": "tacker/sol_refactored/common/lcm_op_occ_utils.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 243,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2022-01-06T04:56:43Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "92d609d3_47593465",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "56e2e019_e90ef20b",
|
|
"filename": "tacker/sol_refactored/common/lcm_op_occ_utils.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 266,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2022-01-06T02:03:04Z",
|
|
"side": 1,
|
|
"message": "typo: intead -\u003e instead",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "d7a5d3b9_48d2e4dd",
|
|
"filename": "tacker/sol_refactored/common/lcm_op_occ_utils.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 266,
|
|
"author": {
|
|
"id": 4149
|
|
},
|
|
"writtenOn": "2022-01-06T02:57:05Z",
|
|
"side": 1,
|
|
"message": "I noticed it too... I will fix.",
|
|
"parentUuid": "56e2e019_e90ef20b",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "6889fa47_b1aa4b08",
|
|
"filename": "tacker/sol_refactored/common/lcm_op_occ_utils.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 266,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2022-01-06T04:56:43Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "d7a5d3b9_48d2e4dd",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f1fcfbd9_5c4fcf25",
|
|
"filename": "tacker/sol_refactored/common/lcm_op_occ_utils.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 365,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2022-01-06T02:03:04Z",
|
|
"side": 1,
|
|
"message": "typo: exculed -\u003e excluded\n\nCould you fix this as well?",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "86e88fd0_2b721301",
|
|
"filename": "tacker/sol_refactored/common/lcm_op_occ_utils.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 365,
|
|
"author": {
|
|
"id": 4149
|
|
},
|
|
"writtenOn": "2022-01-06T02:57:05Z",
|
|
"side": 1,
|
|
"message": "I will fix.",
|
|
"parentUuid": "f1fcfbd9_5c4fcf25",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "ee9766b5_c2e13e75",
|
|
"filename": "tacker/sol_refactored/common/lcm_op_occ_utils.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 365,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2022-01-06T04:56:43Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "86e88fd0_2b721301",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "438d467f_bf67cedd",
|
|
"filename": "tacker/sol_refactored/infra_drivers/openstack/heat_utils.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 139,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2022-01-06T02:03:04Z",
|
|
"side": 1,
|
|
"message": "Why not use python-heatclient for Heat API calls?\npython-heatclient was used in v1, but it has been changed to its own code in v2.\n\n[v1]\nhttps://opendev.org/openstack/tacker/src/branch/stable/xena/tacker/common/clients.py\nhttps://opendev.org/openstack/tacker/src/branch/stable/xena/tacker/vnfm/infra_drivers/openstack/heat_client.py",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "acdaada4_a5f2af75",
|
|
"filename": "tacker/sol_refactored/infra_drivers/openstack/heat_utils.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 139,
|
|
"author": {
|
|
"id": 4149
|
|
},
|
|
"writtenOn": "2022-01-06T02:57:05Z",
|
|
"side": 1,
|
|
"message": "I don\u0027t adopt python-heatclient because it returns own object which does not follow REST API exactly. So I thought it is risky to depend on it.",
|
|
"parentUuid": "438d467f_bf67cedd",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "f76df655_bcdab4ec",
|
|
"filename": "tacker/sol_refactored/infra_drivers/openstack/heat_utils.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 139,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2022-01-06T04:56:43Z",
|
|
"side": 1,
|
|
"message": "Thank you for your explanation. I understand.\n(Although the argument of \"return_raw\" is prepared, it cannot be set when using stack create…\nhttps://opendev.org/openstack/python-heatclient/src/branch/stable/xena/heatclient/common/base.py#L149\nhttps://opendev.org/openstack/python-heatclient/src/branch/stable/xena/heatclient/common/base.py#L307-L310 )\n\nEven if we use python-heatclient, the amount of code will not be greatly reduced, so I think there is no problem.",
|
|
"parentUuid": "acdaada4_a5f2af75",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2de5f913_2d40e83e",
|
|
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 160,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2022-01-05T07:50:26Z",
|
|
"side": 1,
|
|
"message": "\"userdata_utils\" is a utils for calling from a userdata-scripts, and I felt it was not so good to call from this \"infra_drivers\", but what do you think?",
|
|
"range": {
|
|
"startLine": 160,
|
|
"startChar": 19,
|
|
"endLine": 160,
|
|
"endChar": 33
|
|
},
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "6eac483c_f04718f2",
|
|
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 160,
|
|
"author": {
|
|
"id": 4149
|
|
},
|
|
"writtenOn": "2022-01-06T00:13:49Z",
|
|
"side": 1,
|
|
"message": "I think it is better that the part of making \u0027fields\u0027 is in userdata_default.py although it is not called by userdata script. I will change. Please check it.",
|
|
"parentUuid": "2de5f913_2d40e83e",
|
|
"range": {
|
|
"startLine": 160,
|
|
"startChar": 19,
|
|
"endLine": 160,
|
|
"endChar": 33
|
|
},
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "e309065f_cb64d091",
|
|
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 160,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2022-01-06T05:38:45Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "6eac483c_f04718f2",
|
|
"range": {
|
|
"startLine": 160,
|
|
"startChar": 19,
|
|
"endLine": 160,
|
|
"endChar": 33
|
|
},
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "50ff5ec0_3dd1d14f",
|
|
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 165,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2022-01-05T07:50:26Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "d30114ec_17a20dc4",
|
|
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 165,
|
|
"author": {
|
|
"id": 4149
|
|
},
|
|
"writtenOn": "2022-01-06T00:13:49Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"parentUuid": "50ff5ec0_3dd1d14f",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "bbdb477f_ce1b5c33",
|
|
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 165,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2022-01-06T05:38:45Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "d30114ec_17a20dc4",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "1831424b_93070f1a",
|
|
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 334,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2022-01-05T07:50:26Z",
|
|
"side": 1,
|
|
"message": "Since there are multiple places that are aware that id starts with \u0027req-\u0027, so I recommend to define as a constant like follows.\n---\nPREFIX \u003d \u0027req-\u0027",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2e7255f2_8b346b36",
|
|
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 334,
|
|
"author": {
|
|
"id": 4149
|
|
},
|
|
"writtenOn": "2022-01-06T00:13:49Z",
|
|
"side": 1,
|
|
"message": "I see. I think it is better to make id generation method. I will fix.",
|
|
"parentUuid": "1831424b_93070f1a",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "b928d2ef_98167e9d",
|
|
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 334,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2022-01-06T05:38:45Z",
|
|
"side": 1,
|
|
"message": "Thanks for your fix!\nI think it\u0027s a better fix than I recommended.",
|
|
"parentUuid": "2e7255f2_8b346b36",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "65053f3a_f602e2e7",
|
|
"filename": "tacker/sol_refactored/infra_drivers/openstack/userdata_default.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 94,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2022-01-06T02:03:04Z",
|
|
"side": 1,
|
|
"message": "typo: insterested -\u003e interested",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "1727d7dc_c5566228",
|
|
"filename": "tacker/sol_refactored/infra_drivers/openstack/userdata_default.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 94,
|
|
"author": {
|
|
"id": 4149
|
|
},
|
|
"writtenOn": "2022-01-06T02:57:05Z",
|
|
"side": 1,
|
|
"message": "I will fix.",
|
|
"parentUuid": "65053f3a_f602e2e7",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "e4713622_d67d05e2",
|
|
"filename": "tacker/sol_refactored/infra_drivers/openstack/userdata_default.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 94,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2022-01-06T04:56:43Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "1727d7dc_c5566228",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "32e24e37_134f30bf",
|
|
"filename": "tacker/sol_refactored/infra_drivers/openstack/userdata_utils.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 154,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2022-01-06T02:03:04Z",
|
|
"side": 1,
|
|
"message": "typo: interpretaion -\u003e interpretation",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "bb09601d_c3dc8f12",
|
|
"filename": "tacker/sol_refactored/infra_drivers/openstack/userdata_utils.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 154,
|
|
"author": {
|
|
"id": 4149
|
|
},
|
|
"writtenOn": "2022-01-06T02:57:05Z",
|
|
"side": 1,
|
|
"message": "I will fix.",
|
|
"parentUuid": "32e24e37_134f30bf",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "d93deee4_f613adf5",
|
|
"filename": "tacker/sol_refactored/infra_drivers/openstack/userdata_utils.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 154,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2022-01-06T04:56:43Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "bb09601d_c3dc8f12",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "5acbe585_9ae41e6c",
|
|
"filename": "tacker/tests/functional/sol_v2/samples/sample2/contents/UserData/userdata_default.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 94,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2022-01-06T02:03:04Z",
|
|
"side": 1,
|
|
"message": "typo: insterested -\u003e interested",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "d2665a6a_e23f47b9",
|
|
"filename": "tacker/tests/functional/sol_v2/samples/sample2/contents/UserData/userdata_default.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 94,
|
|
"author": {
|
|
"id": 4149
|
|
},
|
|
"writtenOn": "2022-01-06T02:57:05Z",
|
|
"side": 1,
|
|
"message": "I will fix.",
|
|
"parentUuid": "5acbe585_9ae41e6c",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "23d2ad3f_b68585a2",
|
|
"filename": "tacker/tests/functional/sol_v2/samples/sample2/contents/UserData/userdata_default.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 94,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2022-01-06T04:56:43Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "d2665a6a_e23f47b9",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "fc8c88e9_4acc2cc4",
|
|
"filename": "tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 133,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2022-01-06T02:03:04Z",
|
|
"side": 1,
|
|
"message": "typo: retuest -\u003e request\n\nCould you fix this as well?",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "94688737_6d48b32f",
|
|
"filename": "tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 133,
|
|
"author": {
|
|
"id": 4149
|
|
},
|
|
"writtenOn": "2022-01-06T02:57:05Z",
|
|
"side": 1,
|
|
"message": "I will fix.",
|
|
"parentUuid": "fc8c88e9_4acc2cc4",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "0b70252e_43f3f695",
|
|
"filename": "tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 133,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2022-01-06T04:56:43Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "94688737_6d48b32f",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "32850dda_20901465",
|
|
"filename": "tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 389,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2022-01-06T02:03:04Z",
|
|
"side": 1,
|
|
"message": "typo: extVitualLinks -\u003e extVirtualLinks",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "52be6303_9bb3511e",
|
|
"filename": "tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 389,
|
|
"author": {
|
|
"id": 4149
|
|
},
|
|
"writtenOn": "2022-01-06T02:57:05Z",
|
|
"side": 1,
|
|
"message": "I will fix.",
|
|
"parentUuid": "32850dda_20901465",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "1b4eb06c_c66c5a8c",
|
|
"filename": "tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 389,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2022-01-06T04:56:43Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "52be6303_9bb3511e",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "133dc3b1_47f34c29",
|
|
"filename": "tacker/tests/unit/sol_refactored/controller/test_vnflcm_v2.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 54,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2022-01-06T02:03:04Z",
|
|
"side": 1,
|
|
"message": "typo: instantate -\u003e instantiate\n\nCould you fix this as well?",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "00038c91_f1d1f8d2",
|
|
"filename": "tacker/tests/unit/sol_refactored/controller/test_vnflcm_v2.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 54,
|
|
"author": {
|
|
"id": 4149
|
|
},
|
|
"writtenOn": "2022-01-06T02:57:05Z",
|
|
"side": 1,
|
|
"message": "I will fix.",
|
|
"parentUuid": "133dc3b1_47f34c29",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "22d6e3dd_1745a6b8",
|
|
"filename": "tacker/tests/unit/sol_refactored/controller/test_vnflcm_v2.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 54,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2022-01-06T04:56:43Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "00038c91_f1d1f8d2",
|
|
"revId": "93c308be0ba46faae92f0b7a1ef8e5d9a4ccf4e6",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |