1546 lines
50 KiB
Plaintext
1546 lines
50 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "119e0462_684474f3",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "Thank you for the patch.\n\nPlease kindly find my comments below.",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "d2af9295_dc581238",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 33292
|
|
},
|
|
"writtenOn": "2021-12-13T09:07:21Z",
|
|
"side": 1,
|
|
"message": "Thank you for your work. I\u0027ve added comments to your code, please kindly find them.",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "12f3d78d_1ebdf60b",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 142,
|
|
"author": {
|
|
"id": 33292
|
|
},
|
|
"writtenOn": "2021-12-13T09:07:21Z",
|
|
"side": 1,
|
|
"message": "Could you please replace backslash with parentheses? (As Hiromu Asahina pointed out at L195)\n\n```\n elif (result.get_return_code() !\u003d 0 and\n \"kubectl: command not found\" in err):\n```",
|
|
"range": {
|
|
"startLine": 141,
|
|
"startChar": 0,
|
|
"endLine": 142,
|
|
"endChar": 56
|
|
},
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "e6b8c596_976f4781",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 142,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I replaced the backslashes with parentheses.",
|
|
"parentUuid": "12f3d78d_1ebdf60b",
|
|
"range": {
|
|
"startLine": 141,
|
|
"startChar": 0,
|
|
"endLine": 142,
|
|
"endChar": 56
|
|
},
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "673dd2b0_5bcd15d9",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 190,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "Maybe I just don\u0027t understand it, but, are ``created_vim_info`` and ``get_vim`` different?\nIt looks like they are obtained from the same DB table.",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "63891906_6ef6b603",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 190,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "Their data sources are the same, but ``created_vim_info`` only has the contents of the vim table. And ``get_vim`` has the contents of vim and vimauths table. The following processing needs to use the auth_url field in the vimauths table.",
|
|
"parentUuid": "673dd2b0_5bcd15d9",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "fceff3fa_6560f366",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 191,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "Maybe we can remove this var by making this block a method.\n\nPlease check the following a pseudo code. \n\n```\n def get_or_create_vim(context, vim_name, server):\n created_vim_info \u003d self._get_vim_by_name(context, vim_name)\n if created_vim_info:\n vim_info \u003d self.nfvo_plugin.get_vim(context, created_vim_info[\u0027id\u0027])\n if (vim_info[\u0027auth_url\u0027] \u003d\u003d server and\n created_vim_info.get(\u0027status\u0027) \u003d\u003d \u0027REACHABLE\u0027):\n return created_vim_info\n try:\n return nfvo_plugin.create_vim(context, vim_info)\n except Exception as e:\n LOG.error(\"Failed to register kubernetes vim: %s\" % e)\n raise exceptions.MgmtDriverOtherError(\n error_message\u003d\"Failed to register \"\n \"kubernetes vim: %s\" % e)\n\n\n```",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f694c4f9_a388109a",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 191,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I removed this var and extracted this part into a method.",
|
|
"parentUuid": "fceff3fa_6560f366",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2cfe2087_e4e0a3b4",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 192,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "A ``nfvo_plugin`` instance is not always needed, so, could you please move it inside the if block below?\n\nOr, maybe it\u0027s better to make it a member variable (i.e., self.nfvo_plugin) since the ``nfvo_plugin`` is created in many places.",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "a48d1007_338f0641",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 192,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I used ``self.nfvo_plugin \u003d NfvoPlugin()`` in place of nfvo_plugin here.",
|
|
"parentUuid": "2cfe2087_e4e0a3b4",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "9dc81cde_2afcec7a",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 194,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "I suppose you can write ``create_vim_info[\u0027id\u0027]``.\nThe ``get_vim`` method doesn\u0027t consider a case where ``vim_id`` arg is empty, which means the ``get_vim`` will raise an exception when the ``vim_id`` is None.\nRaising an exception from ``get_vim`` and raising it from here are not a big difference.\n\nIf I\u0027m wrong, please ignore it.",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "d2078aec_9ddd7069",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 194,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "Sorry, I wrote wrong here, ``create_vim_info`` should be an object, so it is changed to ``create_vim_info.id`` here.",
|
|
"parentUuid": "9dc81cde_2afcec7a",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "5c02f0f4_a7b04fcf",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 195,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "Could you please use parentheses instead of a backslash?\n\nc.f., https://docs.openstack.org/hacking/latest/user/hacking.html#general\n\u003e It is preferred to wrap long lines in parentheses and not a backslash for line continuation.\n\n\n```\n if (get_vim[\u0027auth_url\u0027] \u003d\u003d server and \n created_vim_info.get(\u0027status\u0027) \u003d\u003d \u0027REACHABLE\u0027):\n```\n\nFor the consistency of codeing, maybe it\u0027s a good idea to follow the coding style of the codes under the ``sol_refactored`` directory [1].\nI know it\u0027s not a matter of right or wrong, but keeping the same style will help other developers to understand the codes.\n\n[1] https://github.com/openstack/tacker/tree/master/tacker/sol_refactored",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "e456d290_90ad8695",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 195,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I used parentheses instead of backslashes.",
|
|
"parentUuid": "5c02f0f4_a7b04fcf",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "d8416827_6078e12b",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 205,
|
|
"author": {
|
|
"id": 33292
|
|
},
|
|
"writtenOn": "2021-12-13T09:07:21Z",
|
|
"side": 1,
|
|
"message": "I think f-literal string is ideal in this context for short code.\n\n```\n LOG.error(f\"Failed to register kubernetes vim: {e}\")\n raise exceptions.MgmtDriverOtherError(\n error_message\u003d\"Failed to register \"\n f\"kubernetes vim: {e}\")\n```",
|
|
"range": {
|
|
"startLine": 202,
|
|
"startChar": 0,
|
|
"endLine": 205,
|
|
"endChar": 64
|
|
},
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "d6c20299_d3eb2532",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 205,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I will fix it in the 9 patch.",
|
|
"parentUuid": "d8416827_6078e12b",
|
|
"range": {
|
|
"startLine": 202,
|
|
"startChar": 0,
|
|
"endLine": 205,
|
|
"endChar": 64
|
|
},
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4027a59c_826882ee",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 781,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "Could you please consider to make this block a method?\n\nAlthough using a user-defined method in the for-loop incurs overhead, an abstraction like the following increases the readability.\n\n\n```\n for vm_dict in master_vm_dict_list:\n if is_master_installed(SOME ARGS):\n continue\n```",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "a55afdf1_ea935a96",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 781,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I moved this block of code into a method.",
|
|
"parentUuid": "4027a59c_826882ee",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "7d708696_68d7ef80",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 782,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "Reading the ll.339-430, it seems that if ``master_vm_dict_list`` is NOT empty, ``vm_dict`` always has the key ``ssh`` and ``nic_ip``.\nThus, we don\u0027t have to do ``get(\u0027ssh\u0027)`` and ``get(\u0027nic_ip\u0027)`` here.\nAlso, you do ``nic_ip.split(\u0027.\u0027)[-1]`` just below this line, which will cause an error if ``nic_ip`` is None even if doing ``get(\u0027nic_ip\u0027)`` here. \n\nIt\u0027s just a minor comment so you can ignore it, but I think it\u0027s ideally better to make ``vm_dict`` a class so that you can add any property to get an attribute easily. \nSomething like this.\n\n```\nclass VM:\n ...\n\n @property\n def nic_ip(self):\n return self._ssh[\u0027nic_ip\u0027]\n \n @property\n def master_name(self):\n return \u0027master\u0027 + self.nic_ip.split(\u0027.\u0027)[-1]\n\nvm \u003d VM(username, password, ipaddr, nic_ip)\nprint(vm.nic_ip)\n# Output: 192.168.0.1\n\n```\n\nthough I\u0027m not sure defining ``master_name`` property in the above class makes sense...",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f3c500a6_a652c0df",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 782,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I replaced ``get(\u0027ssh\u0027)`` and ``get(\u0027nic_ip\u0027)`` with ``vm_dict[\u0027ssh\u0027][\u0027nic_ip\u0027]``.",
|
|
"parentUuid": "7d708696_68d7ef80",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "cfddc059_a1d9487c",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 791,
|
|
"author": {
|
|
"id": 33292
|
|
},
|
|
"writtenOn": "2021-12-13T09:07:21Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "d9385b0e_cc46aadc",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 791,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I fixed it in patch 9.",
|
|
"parentUuid": "cfddc059_a1d9487c",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "cd97551b_edb5aead",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 938,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "Could you please consider to make this block a method and use parentheses instead of a backslash?\n\nAnd use that method like this.\n```\n if not has_secret(SOME ARGS):\n ssh_command \u003d \\\n \"kubectl create -f /tmp/create_admin_token.yaml\"\n self._execute_command(\n commander, ssh_command, K8S_CMD_TIMEOUT, \u0027common\u0027, 0)\n else:\n...\n```",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "a7963125_cf856335",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 938,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I fixed it in patch 9.",
|
|
"parentUuid": "cd97551b_edb5aead",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "03b0ba62_29622d69",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 943,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "Could you please use parentheses instead of a backslash?",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "5e57ad2b_76a565d6",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 943,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I fixed it in patch 9.",
|
|
"parentUuid": "03b0ba62_29622d69",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2e95c179_2fe53c70",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 947,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "Maybe I just don\u0027t understand it, but is waiting 30 seconds to create a secret really enough?",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "59795b05_b5fe8810",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 947,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "Here is another 30 seconds to wait, ``_execute_command`` has already waited 30 seconds.\nGenerally, secret is created in an instant. I think these times should be enough.",
|
|
"parentUuid": "2e95c179_2fe53c70",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "6d8c7294_387f7f6e",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1002,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "Could you please use parentheses instead of a backslash?",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "9f547212_bbcd0bd0",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1002,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I replaced the backslashes with parentheses.",
|
|
"parentUuid": "6d8c7294_387f7f6e",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b874df55_e5b83d59",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1467,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "According to the PEP8 [1], it should be this.\n\n```\n if daemonset_content[\u0027items\u0027]:\n```\n\n\n\n[1] https://www.python.org/dev/peps/pep-0008/#programming-recommendations\n\n\n\u003e For sequences, (strings, lists, tuples), use the fact that empty sequences are false:\n\u003e \n\u003e # Correct:\n\u003e if not seq:\n\u003e if seq:\n\u003e \n\u003e # Wrong:\n\u003e if len(seq):\n\u003e if not len(seq):",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "891659b0_1890188b",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1467,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-13T00:08:54Z",
|
|
"side": 1,
|
|
"message": "Sorry\n\n```\n if not daemonset_content[\u0027items\u0027]:\n```",
|
|
"parentUuid": "b874df55_e5b83d59",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "58115793_edc2fdf0",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1467,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I will fix it in the 9 patch.",
|
|
"parentUuid": "891659b0_1890188b",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "7fa28f9f_612180db",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 2075,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "Could you please consider to make this block a method?\n\nAnd use that method like this.\n```\n if not is_worker_node_installed(SOME ARGS):\n continue\n\n...\n```",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "1cf47071_f7342acd",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 2075,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I fixed it in patch 9.",
|
|
"parentUuid": "7fa28f9f_612180db",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b6650a64_5f9cae2c",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 2076,
|
|
"author": {
|
|
"id": 33292
|
|
},
|
|
"writtenOn": "2021-12-13T09:07:21Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"range": {
|
|
"startLine": 2075,
|
|
"startChar": 0,
|
|
"endLine": 2076,
|
|
"endChar": 34
|
|
},
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "212ae9d2_c5ed38c8",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 2076,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I will fix it in the 9 patch.",
|
|
"parentUuid": "b6650a64_5f9cae2c",
|
|
"range": {
|
|
"startLine": 2075,
|
|
"startChar": 0,
|
|
"endLine": 2076,
|
|
"endChar": 34
|
|
},
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "18a90860_f9762998",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 2151,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "According to the PEP8 [1], it should be this.\n\n```\n if worker_node_pod_info[\u0027items\u0027]:\n```",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "535e789e_31091fcb",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 2151,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-13T00:08:54Z",
|
|
"side": 1,
|
|
"message": "Sorry.\n\n```\n if not worker_node_pod_info[\u0027items\u0027]:\n```",
|
|
"parentUuid": "18a90860_f9762998",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "c04ac1a8_45517f84",
|
|
"filename": "samples/mgmt_driver/kubernetes_mgmt.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 2151,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I will fix it in the 9 patch.",
|
|
"parentUuid": "535e789e_31091fcb",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "9dddbc59_242e6cf4",
|
|
"filename": "tacker/api/vnflcm/v1/controller.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1200,
|
|
"author": {
|
|
"id": 33292
|
|
},
|
|
"writtenOn": "2021-12-13T09:07:21Z",
|
|
"side": 1,
|
|
"message": "typo: kubernetes?",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "379baad3_73c95e10",
|
|
"filename": "tacker/api/vnflcm/v1/controller.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1200,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "This is a spelling error, I will change it to kubernetes.",
|
|
"parentUuid": "9dddbc59_242e6cf4",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "aeaf8b13_b521cd66",
|
|
"filename": "tacker/conductor/conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1957,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "Could you please use parentheses instead of a backslash?\n\nBTW, why don\u0027t you use the alias ``EP`` imported at l.62",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f198ab64_8249ef8d",
|
|
"filename": "tacker/conductor/conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1957,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "Backslashes have been removed.\nSince it is existing code, it has not been changed.\nI modified them in patch 9.",
|
|
"parentUuid": "aeaf8b13_b521cd66",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "14ee1d60_8e65e008",
|
|
"filename": "tacker/conductor/conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 2050,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "348cd9e7_b537687a",
|
|
"filename": "tacker/conductor/conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 2050,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I modified them in patch 9.",
|
|
"parentUuid": "14ee1d60_8e65e008",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "e6dc7196_39ac3656",
|
|
"filename": "tacker/conductor/conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 2153,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "e99e0df0_262554dd",
|
|
"filename": "tacker/conductor/conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 2153,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I modified them in patch 9.",
|
|
"parentUuid": "e6dc7196_39ac3656",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "aba0b560_04cc4fda",
|
|
"filename": "tacker/tests/unit/conductor/test_conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 923,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "nits, but could you please create dict as a dictionary literal?\n\n```\n vnf_dict \u003d {\n **db_utils.get_dummy_vnf(instance_id\u003dself.instance_uuid),\n \u0027before_error_point\u0027: fields.ErrorPoint.INITIAL,\n \u0027status\u0027: \u0027\u0027\n }\n\n```",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "72aed94d_32a0cb30",
|
|
"filename": "tacker/tests/unit/conductor/test_conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 923,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I fixed it in patch 9.",
|
|
"parentUuid": "aba0b560_04cc4fda",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "6a8a88e3_a1413624",
|
|
"filename": "tacker/tests/unit/conductor/test_conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1471,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "eca3da3b_8f5bad18",
|
|
"filename": "tacker/tests/unit/conductor/test_conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1471,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I fixed it in patch 9.",
|
|
"parentUuid": "6a8a88e3_a1413624",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "aec273b8_8b4df493",
|
|
"filename": "tacker/tests/unit/conductor/test_conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1515,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f1916e03_b5f6d450",
|
|
"filename": "tacker/tests/unit/conductor/test_conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1515,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I fixed it in patch 9.",
|
|
"parentUuid": "aec273b8_8b4df493",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "ab62d152_2b0bb0a1",
|
|
"filename": "tacker/tests/unit/conductor/test_conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1561,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "08a18f60_f35681f5",
|
|
"filename": "tacker/tests/unit/conductor/test_conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1561,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I fixed it in patch 9.",
|
|
"parentUuid": "ab62d152_2b0bb0a1",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4cec71a1_3eaa7747",
|
|
"filename": "tacker/tests/unit/conductor/test_conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1604,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f521ad43_66397cac",
|
|
"filename": "tacker/tests/unit/conductor/test_conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1604,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I fixed it in patch 9.",
|
|
"parentUuid": "4cec71a1_3eaa7747",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "9e5cdfef_120463e5",
|
|
"filename": "tacker/tests/unit/conductor/test_conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1670,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "1f5000d8_43a8a911",
|
|
"filename": "tacker/tests/unit/conductor/test_conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1670,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I fixed it in patch 9.",
|
|
"parentUuid": "9e5cdfef_120463e5",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f6c102d6_ae7560a0",
|
|
"filename": "tacker/tests/unit/conductor/test_conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1814,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "95934aa8_d37a5ea9",
|
|
"filename": "tacker/tests/unit/conductor/test_conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1814,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I fixed it in patch 9.",
|
|
"parentUuid": "f6c102d6_ae7560a0",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "0586c635_5e8de069",
|
|
"filename": "tacker/tests/unit/conductor/test_conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1993,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "8991baa2_4a006c4d",
|
|
"filename": "tacker/tests/unit/conductor/test_conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1993,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I fixed it in patch 9.",
|
|
"parentUuid": "0586c635_5e8de069",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "e5c520c7_386aa264",
|
|
"filename": "tacker/tests/unit/conductor/test_conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 2095,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "99b56dc3_8049c8ed",
|
|
"filename": "tacker/tests/unit/conductor/test_conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 2095,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I fixed it in patch 9.",
|
|
"parentUuid": "e5c520c7_386aa264",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "74fdae91_a1013d91",
|
|
"filename": "tacker/tests/unit/conductor/test_conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 2153,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "ab1d21af_fee2dde4",
|
|
"filename": "tacker/tests/unit/conductor/test_conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 2153,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I fixed it in patch 9.",
|
|
"parentUuid": "74fdae91_a1013d91",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2aba463d_014c8821",
|
|
"filename": "tacker/tests/unit/conductor/test_conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 2184,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "584cff59_f84d65ef",
|
|
"filename": "tacker/tests/unit/conductor/test_conductor_server.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 2184,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I fixed it in patch 9.",
|
|
"parentUuid": "2aba463d_014c8821",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "14c8cfad_3ece4b8b",
|
|
"filename": "tacker/tests/unit/vnfm/infra_drivers/openstack/test_openstack_driver.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1998,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "9ebf7514_11a43b20",
|
|
"filename": "tacker/tests/unit/vnfm/infra_drivers/openstack/test_openstack_driver.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1998,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I fixed it in patch 9.",
|
|
"parentUuid": "14c8cfad_3ece4b8b",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "694b0862_56036a94",
|
|
"filename": "tacker/vnflcm/vnflcm_driver.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1228,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "If I\u0027m right, this if block can be rewritten as follows \n\n```\n resource_changes \u003d vnf_info.get(\u0027resource_changes\u0027)\n if not resource_changes:\n resource_changes \u003d self._scale_resource_update(\n ...\n```",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "307e0a2c_c8448c18",
|
|
"filename": "tacker/vnflcm/vnflcm_driver.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1228,
|
|
"author": {
|
|
"id": 33292
|
|
},
|
|
"writtenOn": "2021-12-13T09:07:21Z",
|
|
"side": 1,
|
|
"message": "I think the below seems to be better for refactoring:\n\n```\n resource_changes \u003d vnf_info.get(\u0027resource_changes\u0027,\n self._scale_resource_update(\n context,\n vnf_info,\n vnf_instance,\n scale_vnf_request,\n vim_connection_info,\n error\u003dTrue))\n```",
|
|
"parentUuid": "694b0862_56036a94",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "8dac41b5_8ecabff2",
|
|
"filename": "tacker/vnflcm/vnflcm_driver.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1228,
|
|
"author": {
|
|
"id": 33292
|
|
},
|
|
"writtenOn": "2021-12-13T09:26:31Z",
|
|
"side": 1,
|
|
"message": "Callable in default value will be evaluated even if the key exists, thus my recommendation is not a good one. Please follow Hiromu\u0027s code sample.",
|
|
"parentUuid": "307e0a2c_c8448c18",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "9df7ab42_52cab2fe",
|
|
"filename": "tacker/vnflcm/vnflcm_driver.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1228,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I will fix it in the 9 patch.",
|
|
"parentUuid": "8dac41b5_8ecabff2",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "61f61384_b3dcadde",
|
|
"filename": "tacker/vnflcm/vnflcm_driver.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1231,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "Could you please use parentheses instead of a backslash?",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "cf5d9443_c748ceac",
|
|
"filename": "tacker/vnflcm/vnflcm_driver.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 1231,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I changed the position of the line break and removed the backslash.",
|
|
"parentUuid": "61f61384_b3dcadde",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "af097fb3_7d7c1918",
|
|
"filename": "tacker/vnfm/infra_drivers/openstack/openstack.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 524,
|
|
"author": {
|
|
"id": 33292
|
|
},
|
|
"writtenOn": "2021-12-13T09:07:21Z",
|
|
"side": 1,
|
|
"message": "I think f-literal string is better in this context:\n\n```\n filters \u003d {\"name\": f\"vnflcm_{vnf[\u0027id\u0027]}\"}\n```",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "87c873cc_897bf688",
|
|
"filename": "tacker/vnfm/infra_drivers/openstack/openstack.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 524,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I will fix it in the 9 patch.",
|
|
"parentUuid": "af097fb3_7d7c1918",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "3e3bcb72_3d243624",
|
|
"filename": "tacker/vnfm/infra_drivers/openstack/openstack.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 526,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "fc039929_c5835099",
|
|
"filename": "tacker/vnfm/infra_drivers/openstack/openstack.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 526,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I deleted the backslashes here to make them one line.",
|
|
"parentUuid": "3e3bcb72_3d243624",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4cf1eeaf_e31d1af8",
|
|
"filename": "tacker/vnfm/infra_drivers/openstack/openstack.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 566,
|
|
"author": {
|
|
"id": 33292
|
|
},
|
|
"writtenOn": "2021-12-13T09:07:21Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "dc958082_f019fb5d",
|
|
"filename": "tacker/vnfm/infra_drivers/openstack/openstack.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 566,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I will fix it in the 9 patch.",
|
|
"parentUuid": "4cf1eeaf_e31d1af8",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f12f7261_ee9a4a7c",
|
|
"filename": "tacker/vnfm/infra_drivers/openstack/openstack.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 568,
|
|
"author": {
|
|
"id": 33455
|
|
},
|
|
"writtenOn": "2021-12-12T23:23:17Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "8bd50f28_82024238",
|
|
"filename": "tacker/vnfm/infra_drivers/openstack/openstack.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 568,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-01-19T11:26:50Z",
|
|
"side": 1,
|
|
"message": "I deleted the backslashes here to make them one line.",
|
|
"parentUuid": "f12f7261_ee9a4a7c",
|
|
"revId": "db33d3bb756223ee67fbfb0d963dca76b51f65ae",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |