openstack
/
tacker
Code Issues Proposed changes
tacker/cf64c8a83bbd4aa7f5d59b9963d...

475 lines
14 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "09175e28_9d9a31d6",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 7
},
"lineNbr": 0,
"author": {
"id": 4149
},
"writtenOn": "2021-12-26T23:36:55Z",
"side": 1,
"message": "Thank you for the review.",
"revId": "cf64c8a83bbd4aa7f5d59b9963d97cff09409583",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "314bcc7f_70efd68b",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 7
},
"lineNbr": 0,
"author": {
"id": 4149
},
"writtenOn": "2021-12-27T02:32:53Z",
"side": 1,
"message": "recheck",
"revId": "cf64c8a83bbd4aa7f5d59b9963d97cff09409583",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2bf6f69d_adb904b7",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 7
},
"lineNbr": 0,
"author": {
"id": 4149
},
"writtenOn": "2022-01-04T22:17:34Z",
"side": 1,
"message": "Thank you for the review.",
"revId": "cf64c8a83bbd4aa7f5d59b9963d97cff09409583",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "55eb76c6_2609a5ad",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 7
},
"lineNbr": 0,
"author": {
"id": 4149
},
"writtenOn": "2022-01-04T22:29:00Z",
"side": 1,
"message": "Thank you for the review.",
"revId": "cf64c8a83bbd4aa7f5d59b9963d97cff09409583",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4dc1f4e3_85cac1be",
"filename": "tacker/sol_refactored/common/vnfd_utils.py",
"patchSetId": 7
},
"lineNbr": 369,
"author": {
"id": 31072
},
"writtenOn": "2022-01-04T08:14:16Z",
"side": 1,
"message": "\"aspects\" which is the property of \"ScalingAspects\" is required\u003dtrue, so it can be modified as follows.\n---\n value \u003d (aspect[\u0027properties\u0027][\u0027aspects\u0027]\n .get(aspect_id))",
"range": {
"startLine": 367,
"startChar": 12,
"endLine": 369,
"endChar": 43
},
"revId": "cf64c8a83bbd4aa7f5d59b9963d97cff09409583",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "60c86e1d_8981c7b3",
"filename": "tacker/sol_refactored/common/vnfd_utils.py",
"patchSetId": 7
},
"lineNbr": 369,
"author": {
"id": 4149
},
"writtenOn": "2022-01-04T22:29:00Z",
"side": 1,
"message": "I see. I will fix.",
"parentUuid": "4dc1f4e3_85cac1be",
"range": {
"startLine": 367,
"startChar": 12,
"endLine": 369,
"endChar": 43
},
"revId": "cf64c8a83bbd4aa7f5d59b9963d97cff09409583",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "4fedc0b5_1b7fd4e9",
"filename": "tacker/sol_refactored/common/vnfd_utils.py",
"patchSetId": 7
},
"lineNbr": 369,
"author": {
"id": 31072
},
"writtenOn": "2022-01-05T06:45:19Z",
"side": 1,
"message": "Done",
"parentUuid": "60c86e1d_8981c7b3",
"range": {
"startLine": 367,
"startChar": 12,
"endLine": 369,
"endChar": 43
},
"revId": "cf64c8a83bbd4aa7f5d59b9963d97cff09409583",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "32029b91_e21569e7",
"filename": "tacker/sol_refactored/common/vnfd_utils.py",
"patchSetId": 7
},
"lineNbr": 404,
"author": {
"id": 31072
},
"writtenOn": "2022-01-04T08:14:16Z",
"side": 1,
"message": "\"levels\" which is the property of \"InstantiationLevels\" is required\u003dtrue, so it can be modified as follows.\n---\n return (policy[\u0027properties\u0027][\u0027levels\u0027]\n .get(inst_level, {})\n .get(\u0027scale_info\u0027, {}))",
"range": {
"startLine": 401,
"startChar": 0,
"endLine": 404,
"endChar": 49
},
"revId": "cf64c8a83bbd4aa7f5d59b9963d97cff09409583",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "095f6d96_1bd41c7b",
"filename": "tacker/sol_refactored/common/vnfd_utils.py",
"patchSetId": 7
},
"lineNbr": 404,
"author": {
"id": 4149
},
"writtenOn": "2022-01-04T22:29:00Z",
"side": 1,
"message": "I see. I will fix.",
"parentUuid": "32029b91_e21569e7",
"range": {
"startLine": 401,
"startChar": 0,
"endLine": 404,
"endChar": 49
},
"revId": "cf64c8a83bbd4aa7f5d59b9963d97cff09409583",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "51179cd3_06de6022",
"filename": "tacker/sol_refactored/common/vnfd_utils.py",
"patchSetId": 7
},
"lineNbr": 404,
"author": {
"id": 31072
},
"writtenOn": "2022-01-05T06:45:19Z",
"side": 1,
"message": "Done",
"parentUuid": "095f6d96_1bd41c7b",
"range": {
"startLine": 401,
"startChar": 0,
"endLine": 404,
"endChar": 49
},
"revId": "cf64c8a83bbd4aa7f5d59b9963d97cff09409583",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "04c816b1_51c52fd2",
"filename": "tacker/sol_refactored/common/vnfd_utils.py",
"patchSetId": 7
},
"lineNbr": 413,
"author": {
"id": 31072
},
"writtenOn": "2022-01-04T08:14:16Z",
"side": 1,
"message": "\"aspects\" which is the property of \"ScalingAspects\" is required\u003dtrue, so it can be modified as follows.\n---\n value \u003d (aspect[\u0027properties\u0027][\u0027aspects\u0027]\n .get(aspect_id))",
"range": {
"startLine": 411,
"startChar": 0,
"endLine": 413,
"endChar": 43
},
"revId": "cf64c8a83bbd4aa7f5d59b9963d97cff09409583",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4a10ad43_4ffc82f3",
"filename": "tacker/sol_refactored/common/vnfd_utils.py",
"patchSetId": 7
},
"lineNbr": 413,
"author": {
"id": 4149
},
"writtenOn": "2022-01-04T22:29:00Z",
"side": 1,
"message": "I see. I will fix.",
"parentUuid": "04c816b1_51c52fd2",
"range": {
"startLine": 411,
"startChar": 0,
"endLine": 413,
"endChar": 43
},
"revId": "cf64c8a83bbd4aa7f5d59b9963d97cff09409583",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "7640c64d_d59bba9c",
"filename": "tacker/sol_refactored/common/vnfd_utils.py",
"patchSetId": 7
},
"lineNbr": 413,
"author": {
"id": 31072
},
"writtenOn": "2022-01-05T06:45:19Z",
"side": 1,
"message": "Done",
"parentUuid": "4a10ad43_4ffc82f3",
"range": {
"startLine": 411,
"startChar": 0,
"endLine": 413,
"endChar": 43
},
"revId": "cf64c8a83bbd4aa7f5d59b9963d97cff09409583",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "172c1e3b_fc945b4a",
"filename": "tacker/tests/functional/sol_v2/samples/sample1/contents/BaseHOT/simple/sample1.yaml",
"patchSetId": 7
},
"lineNbr": 41,
"author": {
"id": 32581
},
"writtenOn": "2021-12-27T09:16:43Z",
"side": 1,
"message": "Since the implementation of v2-Scale-API does not use AutoScalingPolicy, I think this definition is not necessary.\nOr is it better to leave it for manual operation?\nPlease tell me your opinion.",
"range": {
"startLine": 28,
"startChar": 0,
"endLine": 41,
"endChar": 41
},
"revId": "cf64c8a83bbd4aa7f5d59b9963d97cff09409583",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "04fd36a8_176fc9bd",
"filename": "tacker/tests/functional/sol_v2/samples/sample1/contents/BaseHOT/simple/sample1.yaml",
"patchSetId": 7
},
"lineNbr": 41,
"author": {
"id": 4149
},
"writtenOn": "2021-12-27T22:21:31Z",
"side": 1,
"message": "It is not used by current implementation surely. I think it is OK to delete it if it runs OK without this definition actually. I think it is OK to leave it too.",
"parentUuid": "172c1e3b_fc945b4a",
"range": {
"startLine": 28,
"startChar": 0,
"endLine": 41,
"endChar": 41
},
"revId": "cf64c8a83bbd4aa7f5d59b9963d97cff09409583",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5e57d3a1_999a8a33",
"filename": "tacker/tests/functional/sol_v2/samples/sample1/contents/BaseHOT/simple/sample1.yaml",
"patchSetId": 7
},
"lineNbr": 41,
"author": {
"id": 32581
},
"writtenOn": "2022-01-04T08:40:31Z",
"side": 1,
"message": "I have confirmed that omitting the OS::Heat::ScalingPolicy did not affect the behavior of HEAT.\nIn my opinion, it should be removed from HOT because unused definitions may confuse users. Especially if it does not match the definition in VNFD, users may misunderstand the value used for LCM.\n\nIf you remove it, I think it is better to show the reason for it as a comment in the HOT. As you know, v1 API needs OS::Heat::ScalingPolicy. It is better to explicitly show the difference from the v1 API to the user.",
"parentUuid": "04fd36a8_176fc9bd",
"range": {
"startLine": 28,
"startChar": 0,
"endLine": 41,
"endChar": 41
},
"revId": "cf64c8a83bbd4aa7f5d59b9963d97cff09409583",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "26412f22_a0ba3620",
"filename": "tacker/tests/functional/sol_v2/samples/sample1/contents/BaseHOT/simple/sample1.yaml",
"patchSetId": 7
},
"lineNbr": 41,
"author": {
"id": 4149
},
"writtenOn": "2022-01-04T22:17:34Z",
"side": 1,
"message": "Thank you for the confirmation. OK, I see. I will remove them and add a comment.",
"parentUuid": "5e57d3a1_999a8a33",
"range": {
"startLine": 28,
"startChar": 0,
"endLine": 41,
"endChar": 41
},
"revId": "cf64c8a83bbd4aa7f5d59b9963d97cff09409583",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ed233200_3ecee0d3",
"filename": "tacker/tests/functional/sol_v2/samples/sample1/contents/BaseHOT/simple/sample1.yaml",
"patchSetId": 7
},
"lineNbr": 41,
"author": {
"id": 31668
},
"writtenOn": "2022-01-06T09:27:16Z",
"side": 1,
"message": "It may be better to modify the following as well.\nhttps://opendev.org/openstack/tacker/src/branch/stable/xena/tacker/tests/unit/sol_refactored/samples/sample1/BaseHOT/simple/ut_sample1.yaml#L27-L40",
"parentUuid": "26412f22_a0ba3620",
"range": {
"startLine": 28,
"startChar": 0,
"endLine": 41,
"endChar": 41
},
"revId": "cf64c8a83bbd4aa7f5d59b9963d97cff09409583",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f64bfb2a_d096f09d",
"filename": "tacker/tests/functional/sol_v2/samples/sample1/contents/BaseHOT/simple/sample1.yaml",
"patchSetId": 7
},
"lineNbr": 41,
"author": {
"id": 4149
},
"writtenOn": "2022-01-06T23:36:57Z",
"side": 1,
"message": "I see. I will remove it.",
"parentUuid": "ed233200_3ecee0d3",
"range": {
"startLine": 28,
"startChar": 0,
"endLine": 41,
"endChar": 41
},
"revId": "cf64c8a83bbd4aa7f5d59b9963d97cff09409583",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ec107323_7d288496",
"filename": "tacker/tests/functional/sol_v2/samples/sample1/contents/BaseHOT/simple/sample1.yaml",
"patchSetId": 7
},
"lineNbr": 41,
"author": {
"id": 32581
},
"writtenOn": "2022-01-07T02:18:25Z",
"side": 1,
"message": "Thank you for the modification.",
"parentUuid": "f64bfb2a_d096f09d",
"range": {
"startLine": 28,
"startChar": 0,
"endLine": 41,
"endChar": 41
},
"revId": "cf64c8a83bbd4aa7f5d59b9963d97cff09409583",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3a873c7e_b8f1ee00",
"filename": "tacker/tests/functional/sol_v2/samples/sample2/contents/BaseHOT/simple/sample2.yaml",
"patchSetId": 7
},
"lineNbr": 41,
"author": {
"id": 32581
},
"writtenOn": "2021-12-27T09:16:43Z",
"side": 1,
"message": "ditto.",
"range": {
"startLine": 28,
"startChar": 0,
"endLine": 41,
"endChar": 41
},
"revId": "cf64c8a83bbd4aa7f5d59b9963d97cff09409583",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink