500 lines
17 KiB
Plaintext
500 lines
17 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "05a60879_e4e52275",
|
|
"filename": "tacker/tests/functional/sol_v2/test_vnflcm_basic.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 218,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2022-04-21T04:08:01Z",
|
|
"side": 1,
|
|
"message": "I think it is better to delete this description and describe it in \"test_vnflcm_basic_common.py\".",
|
|
"range": {
|
|
"startLine": 175,
|
|
"startChar": 8,
|
|
"endLine": 218,
|
|
"endChar": 15
|
|
},
|
|
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "bca3972c_e575a5d5",
|
|
"filename": "tacker/tests/functional/sol_v2/test_vnflcm_basic.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 218,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-04-25T06:46:49Z",
|
|
"side": 1,
|
|
"message": "I fixed it in PS11.",
|
|
"parentUuid": "05a60879_e4e52275",
|
|
"range": {
|
|
"startLine": 175,
|
|
"startChar": 8,
|
|
"endLine": 218,
|
|
"endChar": 15
|
|
},
|
|
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "783e177d_43a8439c",
|
|
"filename": "tacker/tests/functional/sol_v2/test_vnflcm_basic.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 218,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2022-04-27T00:29:43Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "bca3972c_e575a5d5",
|
|
"range": {
|
|
"startLine": 175,
|
|
"startChar": 8,
|
|
"endLine": 218,
|
|
"endChar": 15
|
|
},
|
|
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "66258914_b3bc7d6a",
|
|
"filename": "tacker/tests/functional/sol_v2/test_vnflcm_basic.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 252,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2022-04-21T04:08:01Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"range": {
|
|
"startLine": 222,
|
|
"startChar": 8,
|
|
"endLine": 252,
|
|
"endChar": 11
|
|
},
|
|
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "6525b19a_231f889a",
|
|
"filename": "tacker/tests/functional/sol_v2/test_vnflcm_basic.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 252,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-04-25T06:46:49Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"parentUuid": "66258914_b3bc7d6a",
|
|
"range": {
|
|
"startLine": 222,
|
|
"startChar": 8,
|
|
"endLine": 252,
|
|
"endChar": 11
|
|
},
|
|
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "434da248_d26f1753",
|
|
"filename": "tacker/tests/functional/sol_v2/test_vnflcm_basic.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 252,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2022-04-27T00:29:43Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "6525b19a_231f889a",
|
|
"range": {
|
|
"startLine": 222,
|
|
"startChar": 8,
|
|
"endLine": 252,
|
|
"endChar": 11
|
|
},
|
|
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "0a7faeec_0d7de416",
|
|
"filename": "tacker/tests/functional/sol_v2/test_vnflcm_error_handling.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 102,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2022-04-21T04:08:01Z",
|
|
"side": 1,
|
|
"message": "I think it is better to delete this description and describe it in \"test_vnflcm_basic_common.py\".",
|
|
"range": {
|
|
"startLine": 74,
|
|
"startChar": 8,
|
|
"endLine": 102,
|
|
"endChar": 11
|
|
},
|
|
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "fbbc0dd3_cb65a6d4",
|
|
"filename": "tacker/tests/functional/sol_v2/test_vnflcm_error_handling.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 102,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-04-25T06:46:49Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"parentUuid": "0a7faeec_0d7de416",
|
|
"range": {
|
|
"startLine": 74,
|
|
"startChar": 8,
|
|
"endLine": 102,
|
|
"endChar": 11
|
|
},
|
|
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "8a2c8167_8441df9b",
|
|
"filename": "tacker/tests/functional/sol_v2/test_vnflcm_error_handling.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 102,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2022-04-27T00:29:43Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "fbbc0dd3_cb65a6d4",
|
|
"range": {
|
|
"startLine": 74,
|
|
"startChar": 8,
|
|
"endLine": 102,
|
|
"endChar": 11
|
|
},
|
|
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "3f616720_a02c6193",
|
|
"filename": "tacker/tests/functional/sol_v2/test_vnflcm_error_handling.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 301,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2022-04-21T04:08:01Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"range": {
|
|
"startLine": 281,
|
|
"startChar": 8,
|
|
"endLine": 301,
|
|
"endChar": 11
|
|
},
|
|
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "a86df338_54e8b82b",
|
|
"filename": "tacker/tests/functional/sol_v2/test_vnflcm_error_handling.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 301,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-04-25T06:46:49Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"parentUuid": "3f616720_a02c6193",
|
|
"range": {
|
|
"startLine": 281,
|
|
"startChar": 8,
|
|
"endLine": 301,
|
|
"endChar": 11
|
|
},
|
|
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "a512e4a1_90b451a0",
|
|
"filename": "tacker/tests/functional/sol_v2/test_vnflcm_error_handling.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 301,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2022-04-27T00:29:43Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "a86df338_54e8b82b",
|
|
"range": {
|
|
"startLine": 281,
|
|
"startChar": 8,
|
|
"endLine": 301,
|
|
"endChar": 11
|
|
},
|
|
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "77fd1244_dbca4f99",
|
|
"filename": "tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 89,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2022-04-21T04:08:01Z",
|
|
"side": 1,
|
|
"message": "How about setting the default argument \"is_nfvo\u003dFalse\"?\nThen you can omit the argument in the test under \"sol_v2\".",
|
|
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "33c5d567_4b1e1710",
|
|
"filename": "tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 89,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-04-25T06:46:49Z",
|
|
"side": 1,
|
|
"message": "I fixed it in PS11.",
|
|
"parentUuid": "77fd1244_dbca4f99",
|
|
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "74786614_99c15fd3",
|
|
"filename": "tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 89,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2022-04-27T00:29:43Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "33c5d567_4b1e1710",
|
|
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "24248035_d52b12aa",
|
|
"filename": "tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 328,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2022-04-21T04:08:01Z",
|
|
"side": 1,
|
|
"message": "It branches according to the value of \"is_nfvo\", but unlike other places, I don\u0027t think it is a necessary branch.\nIf \"is_nfvo\u003dTrue\", there is no special confirmation point of view compared to \"is_nfvo\u003dFalse\", so it is omitted.\nI think the execution time of this process is short, so it\u0027s better to delete this branch for the purpose of simplification of the test.\nWhat do you think?",
|
|
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "325006dd_96a22a67",
|
|
"filename": "tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 328,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-04-25T06:46:49Z",
|
|
"side": 1,
|
|
"message": "I fixed it in PS11.",
|
|
"parentUuid": "24248035_d52b12aa",
|
|
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "92b932c2_12ac3c18",
|
|
"filename": "tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 328,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2022-04-27T00:29:43Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "325006dd_96a22a67",
|
|
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "a1aa34b8_807b295e",
|
|
"filename": "tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 413,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2022-04-21T04:08:01Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "d22c9689_e2856d53",
|
|
"filename": "tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 413,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-04-25T06:46:49Z",
|
|
"side": 1,
|
|
"message": "I fixed it in PS11.",
|
|
"parentUuid": "a1aa34b8_807b295e",
|
|
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "08e0434b_ed832440",
|
|
"filename": "tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 413,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2022-04-27T00:29:43Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "d22c9689_e2856d53",
|
|
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4e985288_429695ba",
|
|
"filename": "tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 1185,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2022-04-21T04:08:01Z",
|
|
"side": 1,
|
|
"message": "There are many if branches based on the value of \"is_nfvo\", which makes readability worse.\nIt\u0027s better to move the process to \"Pre setting\" whenever possible, as shown below.\n```\ndiff --git a/tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py b/tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py\nindex 2e6f2d82..106c3c60 100644\n--- a/tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py\n+++ b/tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py\n@@ -1205,6 +1205,67 @@ class CommonVnfLcmTest(base_v2.BaseSolV2Test):\n basic_lcms_min_path, vnfd_path)\n zone_name_list \u003d self.get_zone_list()\n\n+ # Set Fake server response for Grant-Req(Instantiate)\n+ base_v2.FAKE_SERVER_MANAGER.set_callback(\u0027POST\u0027,\n+ fake_grant_v2.GrantV2.GRANT_REQ_PATH,\n+ status_code\u003d201,\n+ response_headers\u003d{\"Content-Type\": \"application/json\"},\n+ callback\u003dlambda req_headers,\n+ req_body: fake_grant_v2.GrantV2.make_inst_response_body(\n+ req_body, glance_image, flavour_vdu_dict, zone_name_list))\n...snip...\n+ # Set Fake server response for Grant-Req(Terminate)\n+ base_v2.FAKE_SERVER_MANAGER.set_callback(\u0027POST\u0027,\n+ fake_grant_v2.GrantV2.GRANT_REQ_PATH,\n+ status_code\u003d201,\n+ response_headers\u003d{\"Content-Type\": \"application/json\"},\n+ callback\u003dlambda req_headers,\n+ req_body: fake_grant_v2.GrantV2.make_term_response_body(\n+ req_body))\n+\n+ # create requests\n+ create_req \u003d paramgen.create_vnf_min(vnfd_id_1)\n+ update_req \u003d paramgen.update_vnf_min_with_parameter(vnfd_id_2)\n+ else:\n+ # create requests\n+ create_req \u003d paramgen.create_vnf_min(self.vnfd_id_2)\n+ update_req \u003d paramgen.update_vnf_min_with_parameter(self.vnfd_id_3)\n+\n # 1. Create subscription\n callback_url \u003d os.path.join(base_v2.MOCK_NOTIFY_CALLBACK_URL,\n self._testMethodName)\n```",
|
|
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "52fdf8e4_1b3d9998",
|
|
"filename": "tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 1185,
|
|
"author": {
|
|
"id": 33492
|
|
},
|
|
"writtenOn": "2022-04-25T06:46:49Z",
|
|
"side": 1,
|
|
"message": "I put the processing of the branches that can be put into the pre into the `pre`. For some branches, they must be processed in the middle of the lifecycle, and they are not put into the pre. In order to enhance readability, I extracted some processing out of common methods and reduced the if branch in the main function.",
|
|
"parentUuid": "4e985288_429695ba",
|
|
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "4edd322d_9218edb6",
|
|
"filename": "tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 1185,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2022-04-27T00:29:43Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "52fdf8e4_1b3d9998",
|
|
"revId": "3e7a5834c29d7a920d4dde327e65514abd618e43",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |