109 lines
4.2 KiB
Plaintext
109 lines
4.2 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "f49106ed_8b4b6ee3",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 9200
|
|
},
|
|
"writtenOn": "2022-01-19T01:14:25Z",
|
|
"side": 1,
|
|
"message": "I tweaked the commit message. How about this?",
|
|
"revId": "f9547f5e433626e807dc151fb934f9d908c472cf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "5fcb2ce9_758bb349",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 31857
|
|
},
|
|
"writtenOn": "2022-01-20T05:51:20Z",
|
|
"side": 1,
|
|
"message": "LGTM, Thanks for your re-work.",
|
|
"revId": "f9547f5e433626e807dc151fb934f9d908c472cf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "943a2a57_5189ccff",
|
|
"filename": "tacker/sol_refactored/controller/vnflcm_view.py",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 112,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2022-01-20T08:56:03Z",
|
|
"side": 1,
|
|
"message": "In the case of \"neq\" and \"nin\", if there is even one key different from the one specified by filter, it will be True.\nFor example, if the key of \"vimConnectionInfo\" is \"vim1\" and \"vim2\", it is not excluded by the filter\u003d\"(neq,vimConnectionInfo/@key,vim1)\".\nIs this the intended specification?",
|
|
"revId": "f9547f5e433626e807dc151fb934f9d908c472cf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "cb105a0d_bc9374e5",
|
|
"filename": "tacker/sol_refactored/controller/vnflcm_view.py",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 112,
|
|
"author": {
|
|
"id": 9200
|
|
},
|
|
"writtenOn": "2022-01-20T09:20:34Z",
|
|
"side": 1,
|
|
"message": "The spec for AttributeFilter is only concisely written in SOL013 5.2.2.\nThe spec doesn\u0027t say much when the dict in question has more than one key.\n\nAs the spec isn\u0027t very clear, I think it is better to be permissive and return maybe extra results.",
|
|
"parentUuid": "943a2a57_5189ccff",
|
|
"revId": "f9547f5e433626e807dc151fb934f9d908c472cf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "a9ca81b4_addcbb09",
|
|
"filename": "tacker/sol_refactored/controller/vnflcm_view.py",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 112,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2022-01-21T07:02:56Z",
|
|
"side": 1,
|
|
"message": "Thank you for sharing your thoughts.\n(I also think that the description of SOL013 is not clear…)\nI understand that the specifications of \"@key\" in Tacker are as follows.\n-----\neq, in -\u003e Return record if even one key contains the same value\nneq, nin -\u003e Return record if even one key contains different value\n-----\n\nI tried the following filter and it returned a 500 error.\n-----\nfilter\u003d\"(eq,instantiatedVnfInfo/extVirtualLinkInfo/currentVnfExtCpData/cpConfig/@key,VDU1_CP1)\"\n-----\nIf it\u0027s not supported, could you please add a comment and return a 400 error instead of a 500 error?",
|
|
"parentUuid": "cb105a0d_bc9374e5",
|
|
"revId": "f9547f5e433626e807dc151fb934f9d908c472cf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "3fd7fd3a_f0bf25b5",
|
|
"filename": "tacker/sol_refactored/controller/vnflcm_view.py",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 112,
|
|
"author": {
|
|
"id": 9200
|
|
},
|
|
"writtenOn": "2022-01-21T08:22:04Z",
|
|
"side": 1,
|
|
"message": "Thanks for testing.\n\nThat\u0027s because currentVnfExtCpData is a list, and unfortunately the spec isn\u0027t clear how the code should behave.\nI think it\u0027s better to return a 400 error in such cases.\nPlease wait for the next patchset.",
|
|
"parentUuid": "a9ca81b4_addcbb09",
|
|
"revId": "f9547f5e433626e807dc151fb934f9d908c472cf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |