openstack
/
tacker
Code Issues Proposed changes
tacker/14fed99218fae96c567a7918e6b...

340 lines
11 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "8c44c5f5_303094d5",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 4149
},
"writtenOn": "2021-12-23T00:43:01Z",
"side": 1,
"message": "Thank you for the comment.",
"revId": "14fed99218fae96c567a7918e6bb1d4393274487",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b46c9b9d_85b90c46",
"filename": "tacker/sol_refactored/common/vnfd_utils.py",
"patchSetId": 5
},
"lineNbr": 385,
"author": {
"id": 31072
},
"writtenOn": "2021-12-23T05:32:36Z",
"side": 1,
"message": "Is it unnecessary to consider the case where this \"delta\" set in \u0027tosca.policies.nfv.ScalingAspects\u0027 is not set in \u0027tosca.policies.nfv.VduScalingAspectDeltas\u0027 due to a VNFD defect?",
"range": {
"startLine": 385,
"startChar": 41,
"endLine": 385,
"endChar": 46
},
"revId": "14fed99218fae96c567a7918e6bb1d4393274487",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "614aebf9_9226a6e3",
"filename": "tacker/sol_refactored/common/vnfd_utils.py",
"patchSetId": 5
},
"lineNbr": 385,
"author": {
"id": 4149
},
"writtenOn": "2021-12-26T23:36:55Z",
"side": 1,
"message": "You are right. I found it is not checked that \u0027delta\u0027 exists in VNFD or not at vnf package loading. I will add the check.",
"parentUuid": "b46c9b9d_85b90c46",
"range": {
"startLine": 385,
"startChar": 41,
"endLine": 385,
"endChar": 46
},
"revId": "14fed99218fae96c567a7918e6bb1d4393274487",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ba52f788_9d775052",
"filename": "tacker/sol_refactored/common/vnfd_utils.py",
"patchSetId": 5
},
"lineNbr": 385,
"author": {
"id": 31072
},
"writtenOn": "2021-12-27T00:30:18Z",
"side": 1,
"message": "Done",
"parentUuid": "614aebf9_9226a6e3",
"range": {
"startLine": 385,
"startChar": 41,
"endLine": 385,
"endChar": 46
},
"revId": "14fed99218fae96c567a7918e6bb1d4393274487",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "98435dac_0cde5ffd",
"filename": "tacker/sol_refactored/conductor/vnflcm_driver_v2.py",
"patchSetId": 5
},
"lineNbr": 234,
"author": {
"id": 31072
},
"writtenOn": "2021-12-23T05:32:36Z",
"side": 1,
"message": "What is the benefit of having this naming convention for this ID?",
"range": {
"startLine": 234,
"startChar": 24,
"endLine": 234,
"endChar": 62
},
"revId": "14fed99218fae96c567a7918e6bb1d4393274487",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "af1a5c51_35d42b65",
"filename": "tacker/sol_refactored/conductor/vnflcm_driver_v2.py",
"patchSetId": 5
},
"lineNbr": 234,
"author": {
"id": 4149
},
"writtenOn": "2021-12-26T23:36:55Z",
"side": 1,
"message": "I think it is easy to understand the correspondence of VDU and the CP than making it random (generate_uuid).",
"parentUuid": "98435dac_0cde5ffd",
"range": {
"startLine": 234,
"startChar": 24,
"endLine": 234,
"endChar": 62
},
"revId": "14fed99218fae96c567a7918e6bb1d4393274487",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "028cebc1_3ecbf86c",
"filename": "tacker/sol_refactored/conductor/vnflcm_driver_v2.py",
"patchSetId": 5
},
"lineNbr": 234,
"author": {
"id": 31072
},
"writtenOn": "2021-12-27T00:30:18Z",
"side": 1,
"message": "Okay, I got it.",
"parentUuid": "af1a5c51_35d42b65",
"range": {
"startLine": 234,
"startChar": 24,
"endLine": 234,
"endChar": 62
},
"revId": "14fed99218fae96c567a7918e6bb1d4393274487",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "cce8b823_16a7e9fb",
"filename": "tacker/sol_refactored/conductor/vnflcm_driver_v2.py",
"patchSetId": 5
},
"lineNbr": 508,
"author": {
"id": 31072
},
"writtenOn": "2021-12-23T00:06:33Z",
"side": 1,
"message": "tacker/sol_refactored/conductor/vnflcm_driver_v2.py L156\ntacker/sol_refactored/conductor/vnflcm_driver_v2.py L506\ntacker/sol_refactored/controller/vnflcm_v2.py L244\n---\nAlthough it is related to what I have already commented on, I think that the code considering the following is defined in the above 3 points about \"numberOfSteps\".\n* 1 is set as the initial value and it will be overwrited when it is set in the request-body\n* For Scale-in, multiply by -1\nIs it possible to eliminate the need for consideration in each code by commonizing this process as a new util function?",
"range": {
"startLine": 506,
"startChar": 8,
"endLine": 508,
"endChar": 41
},
"revId": "14fed99218fae96c567a7918e6bb1d4393274487",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4e888e29_98e93e99",
"filename": "tacker/sol_refactored/conductor/vnflcm_driver_v2.py",
"patchSetId": 5
},
"lineNbr": 508,
"author": {
"id": 4149
},
"writtenOn": "2021-12-23T00:43:01Z",
"side": 1,
"message": "Hmm, about the first item I think it is better to set the value in the controller so that it is not necessary to check the conductor. I will change the code.\nAbout the second item I think it is not necessary to make it method because it is only convenience for the calculation.",
"parentUuid": "cce8b823_16a7e9fb",
"range": {
"startLine": 506,
"startChar": 8,
"endLine": 508,
"endChar": 41
},
"revId": "14fed99218fae96c567a7918e6bb1d4393274487",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "473ac551_9ea13a35",
"filename": "tacker/sol_refactored/conductor/vnflcm_driver_v2.py",
"patchSetId": 5
},
"lineNbr": 508,
"author": {
"id": 31072
},
"writtenOn": "2021-12-23T05:32:36Z",
"side": 1,
"message": "Thank you for the modification.\nI confirmed that.",
"parentUuid": "4e888e29_98e93e99",
"range": {
"startLine": 506,
"startChar": 8,
"endLine": 508,
"endChar": 41
},
"revId": "14fed99218fae96c567a7918e6bb1d4393274487",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "efcd3ba5_554383b2",
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
"patchSetId": 5
},
"lineNbr": 47,
"author": {
"id": 31072
},
"writtenOn": "2021-12-23T05:32:36Z",
"side": 1,
"message": "Since this function is only called from within this class, can it be \"_make_hot\"?\nOr do you expect to be called from another class in the future?\nIn addition, unless there is a special reason, I thought that the definition location of this function should be after \"scale_rollback\" with following existing code, but what do you think?",
"revId": "14fed99218fae96c567a7918e6bb1d4393274487",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "8c6d3322_228a68ac",
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
"patchSetId": 5
},
"lineNbr": 47,
"author": {
"id": 4149
},
"writtenOn": "2021-12-26T23:36:55Z",
"side": 1,
"message": "I don\u0027t have a strong reason of method naming and place of methods. Ok, I will change the name and place.",
"parentUuid": "efcd3ba5_554383b2",
"revId": "14fed99218fae96c567a7918e6bb1d4393274487",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "24607f3e_90fa9e6d",
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
"patchSetId": 5
},
"lineNbr": 47,
"author": {
"id": 31072
},
"writtenOn": "2021-12-27T00:30:18Z",
"side": 1,
"message": "Done",
"parentUuid": "8c6d3322_228a68ac",
"revId": "14fed99218fae96c567a7918e6bb1d4393274487",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "fee9fde9_67f5dde0",
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
"patchSetId": 5
},
"lineNbr": 552,
"author": {
"id": 31072
},
"writtenOn": "2021-12-23T05:32:36Z",
"side": 1,
"message": "Same with \"make_hot\".\nSince this function is only called from within this class, can it be \"_make_instantiated_vnf_info\"?",
"revId": "14fed99218fae96c567a7918e6bb1d4393274487",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "391bbb9a_034ebd4e",
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
"patchSetId": 5
},
"lineNbr": 552,
"author": {
"id": 4149
},
"writtenOn": "2021-12-26T23:36:55Z",
"side": 1,
"message": "Ok, I will change.",
"parentUuid": "fee9fde9_67f5dde0",
"revId": "14fed99218fae96c567a7918e6bb1d4393274487",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1fbf2379_ac1c8442",
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
"patchSetId": 5
},
"lineNbr": 552,
"author": {
"id": 31072
},
"writtenOn": "2021-12-27T00:30:18Z",
"side": 1,
"message": "Done",
"parentUuid": "391bbb9a_034ebd4e",
"revId": "14fed99218fae96c567a7918e6bb1d4393274487",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink