234 lines
7.0 KiB
Plaintext
234 lines
7.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "3b8647b4_14db1e40",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2021-12-22T00:14:29Z",
|
|
"side": 1,
|
|
"message": "Do you have a plan to support generating scale_req in \"pkggen.py\" of sample1 and sample2?",
|
|
"revId": "5fe32c386a1207294b8a1c5ea35274556d7d4b44",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "bc13a3ed_bc2aecb7",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 4149
|
|
},
|
|
"writtenOn": "2021-12-22T00:27:07Z",
|
|
"side": 1,
|
|
"message": "No, at least in this patch because FT of scale is not included in this patch. I think it will be supported in the patch of scale FT.",
|
|
"parentUuid": "3b8647b4_14db1e40",
|
|
"revId": "5fe32c386a1207294b8a1c5ea35274556d7d4b44",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "920d180f_42779bfb",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2021-12-22T01:29:17Z",
|
|
"side": 1,
|
|
"message": "Okay, I got it.",
|
|
"parentUuid": "bc13a3ed_bc2aecb7",
|
|
"revId": "5fe32c386a1207294b8a1c5ea35274556d7d4b44",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "36f1b773_e1039884",
|
|
"filename": "tacker/sol_refactored/conductor/vnflcm_driver_v2.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 152,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2021-12-22T05:30:18Z",
|
|
"side": 1,
|
|
"message": "inst_saved \u003d inst.obj_clone()\n---\nThe contents of instantiatedVnfInfo were also cloned by the above process of \"process()\" which is the caller of this function, and I thought that this process was unnecessary.\nYou need it?",
|
|
"range": {
|
|
"startLine": 149,
|
|
"startChar": 0,
|
|
"endLine": 152,
|
|
"endChar": 73
|
|
},
|
|
"revId": "5fe32c386a1207294b8a1c5ea35274556d7d4b44",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "974c11f1_f8e15d9d",
|
|
"filename": "tacker/sol_refactored/conductor/vnflcm_driver_v2.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 152,
|
|
"author": {
|
|
"id": 4149
|
|
},
|
|
"writtenOn": "2021-12-22T23:16:33Z",
|
|
"side": 1,
|
|
"message": "instantiatedVnfInfo may be re-created by infra_driver. so it is not guaranteed that scaleStatus is left. (see. infra_drivers/openstack/openstack.py L.699)",
|
|
"parentUuid": "36f1b773_e1039884",
|
|
"range": {
|
|
"startLine": 149,
|
|
"startChar": 0,
|
|
"endLine": 152,
|
|
"endChar": 73
|
|
},
|
|
"revId": "5fe32c386a1207294b8a1c5ea35274556d7d4b44",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "980c3ac9_7e67a4a0",
|
|
"filename": "tacker/sol_refactored/conductor/vnflcm_driver_v2.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 152,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2021-12-23T00:06:33Z",
|
|
"side": 1,
|
|
"message": "Okay, I see.",
|
|
"parentUuid": "974c11f1_f8e15d9d",
|
|
"range": {
|
|
"startLine": 149,
|
|
"startChar": 0,
|
|
"endLine": 152,
|
|
"endChar": 73
|
|
},
|
|
"revId": "5fe32c386a1207294b8a1c5ea35274556d7d4b44",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "43b727cf_8c6ee167",
|
|
"filename": "tacker/sol_refactored/conductor/vnflcm_driver_v2.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 156,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2021-12-22T05:30:18Z",
|
|
"side": 1,
|
|
"message": "I think that the initial value is 1 because the default value according to the SOL definition is 1, so it\u0027s better to write a comment.",
|
|
"revId": "5fe32c386a1207294b8a1c5ea35274556d7d4b44",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4d189574_247d3213",
|
|
"filename": "tacker/sol_refactored/conductor/vnflcm_driver_v2.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 156,
|
|
"author": {
|
|
"id": 4149
|
|
},
|
|
"writtenOn": "2021-12-22T23:16:33Z",
|
|
"side": 1,
|
|
"message": "I see. I will add a comment.",
|
|
"parentUuid": "43b727cf_8c6ee167",
|
|
"revId": "5fe32c386a1207294b8a1c5ea35274556d7d4b44",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "995f0833_f37c587e",
|
|
"filename": "tacker/sol_refactored/conductor/vnflcm_driver_v2.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 156,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2021-12-23T00:06:33Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "4d189574_247d3213",
|
|
"revId": "5fe32c386a1207294b8a1c5ea35274556d7d4b44",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "0e4a0d8d_6e50c8c8",
|
|
"filename": "tacker/sol_refactored/controller/vnflcm_v2.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 244,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2021-12-22T05:30:18Z",
|
|
"side": 1,
|
|
"message": "I think that the initial value is 1 because the default value according to the SOL definition is 1, so it\u0027s better to write a comment.",
|
|
"revId": "5fe32c386a1207294b8a1c5ea35274556d7d4b44",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "adf8a118_bca4028e",
|
|
"filename": "tacker/sol_refactored/controller/vnflcm_v2.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 244,
|
|
"author": {
|
|
"id": 4149
|
|
},
|
|
"writtenOn": "2021-12-22T23:16:33Z",
|
|
"side": 1,
|
|
"message": "I see. I will add a comment.",
|
|
"parentUuid": "0e4a0d8d_6e50c8c8",
|
|
"revId": "5fe32c386a1207294b8a1c5ea35274556d7d4b44",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "dffaf29d_5376e13e",
|
|
"filename": "tacker/sol_refactored/controller/vnflcm_v2.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 244,
|
|
"author": {
|
|
"id": 31072
|
|
},
|
|
"writtenOn": "2021-12-23T00:06:33Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "adf8a118_bca4028e",
|
|
"revId": "5fe32c386a1207294b8a1c5ea35274556d7d4b44",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |