openstack
/
tacker
Code Issues Proposed changes
tacker/e3e00a9ab17f6c3a2689351ab93...

357 lines
10 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "a7abbe0b_09d3dbbd",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 4149
},
"writtenOn": "2021-12-20T22:25:48Z",
"side": 1,
"message": "Thank you for the review.",
"revId": "e3e00a9ab17f6c3a2689351ab93cb875daec8e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3a1e51a7_4bca9786",
"filename": "tacker/sol_refactored/common/exceptions.py",
"patchSetId": 1
},
"lineNbr": 230,
"author": {
"id": 31072
},
"writtenOn": "2021-12-20T08:08:16Z",
"side": 1,
"message": "Currently, only one pattern of message is set in openstack.py, so I think it can be defined as follows.\nIs the current definition better for future expansion?\n---\nclass UnexpectedParentResourceDefinition(SolHttpError422):\n message \u003d _(\"Parent resource is necessary for VDU \"\n \"definition.\")",
"range": {
"startLine": 228,
"startChar": 0,
"endLine": 230,
"endChar": 8
},
"revId": "e3e00a9ab17f6c3a2689351ab93cb875daec8e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "107ba21d_c83dfb63",
"filename": "tacker/sol_refactored/common/exceptions.py",
"patchSetId": 1
},
"lineNbr": 230,
"author": {
"id": 4149
},
"writtenOn": "2021-12-20T22:25:48Z",
"side": 1,
"message": "I see. I will fix.",
"parentUuid": "3a1e51a7_4bca9786",
"range": {
"startLine": 228,
"startChar": 0,
"endLine": 230,
"endChar": 8
},
"revId": "e3e00a9ab17f6c3a2689351ab93cb875daec8e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "6f8ec248_7b973464",
"filename": "tacker/sol_refactored/common/exceptions.py",
"patchSetId": 1
},
"lineNbr": 230,
"author": {
"id": 31072
},
"writtenOn": "2021-12-21T00:19:24Z",
"side": 1,
"message": "Done",
"parentUuid": "107ba21d_c83dfb63",
"range": {
"startLine": 228,
"startChar": 0,
"endLine": 230,
"endChar": 8
},
"revId": "e3e00a9ab17f6c3a2689351ab93cb875daec8e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6960e13c_00b46321",
"filename": "tacker/sol_refactored/common/exceptions.py",
"patchSetId": 1
},
"lineNbr": 234,
"author": {
"id": 31072
},
"writtenOn": "2021-12-20T08:08:16Z",
"side": 1,
"message": "It\u0027s better to output the value of aspectId.",
"revId": "e3e00a9ab17f6c3a2689351ab93cb875daec8e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d06791b5_4a90a3ff",
"filename": "tacker/sol_refactored/common/exceptions.py",
"patchSetId": 1
},
"lineNbr": 234,
"author": {
"id": 4149
},
"writtenOn": "2021-12-20T22:25:48Z",
"side": 1,
"message": "I see. I will fix.",
"parentUuid": "6960e13c_00b46321",
"revId": "e3e00a9ab17f6c3a2689351ab93cb875daec8e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3d902bd1_4efb1e61",
"filename": "tacker/sol_refactored/common/exceptions.py",
"patchSetId": 1
},
"lineNbr": 234,
"author": {
"id": 31072
},
"writtenOn": "2021-12-21T00:19:24Z",
"side": 1,
"message": "Done",
"parentUuid": "d06791b5_4a90a3ff",
"revId": "e3e00a9ab17f6c3a2689351ab93cb875daec8e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "fb51cdc4_a4761d96",
"filename": "tacker/sol_refactored/common/exceptions.py",
"patchSetId": 1
},
"lineNbr": 238,
"author": {
"id": 31072
},
"writtenOn": "2021-12-20T08:08:16Z",
"side": 1,
"message": "It\u0027s better to output the value of numberOfSteps.",
"revId": "e3e00a9ab17f6c3a2689351ab93cb875daec8e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a37972b3_6d25e549",
"filename": "tacker/sol_refactored/common/exceptions.py",
"patchSetId": 1
},
"lineNbr": 238,
"author": {
"id": 4149
},
"writtenOn": "2021-12-20T22:25:48Z",
"side": 1,
"message": "I see. I will fix.",
"parentUuid": "fb51cdc4_a4761d96",
"revId": "e3e00a9ab17f6c3a2689351ab93cb875daec8e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b4af3d3b_0d3b9a40",
"filename": "tacker/sol_refactored/common/exceptions.py",
"patchSetId": 1
},
"lineNbr": 238,
"author": {
"id": 31072
},
"writtenOn": "2021-12-21T00:19:24Z",
"side": 1,
"message": "Done",
"parentUuid": "a37972b3_6d25e549",
"revId": "e3e00a9ab17f6c3a2689351ab93cb875daec8e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0bc107f0_09b0cd02",
"filename": "tacker/sol_refactored/common/vnfd_utils.py",
"patchSetId": 1
},
"lineNbr": 371,
"author": {
"id": 31072
},
"writtenOn": "2021-12-20T08:08:16Z",
"side": 1,
"message": "This is a limitation in the current implementation, so could you emphasize it in \"NOTE\"?",
"revId": "e3e00a9ab17f6c3a2689351ab93cb875daec8e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "101ea155_49382945",
"filename": "tacker/sol_refactored/common/vnfd_utils.py",
"patchSetId": 1
},
"lineNbr": 371,
"author": {
"id": 4149
},
"writtenOn": "2021-12-20T22:25:48Z",
"side": 1,
"message": "I see. I will fix.",
"parentUuid": "0bc107f0_09b0cd02",
"revId": "e3e00a9ab17f6c3a2689351ab93cb875daec8e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1264b9be_da88913f",
"filename": "tacker/sol_refactored/common/vnfd_utils.py",
"patchSetId": 1
},
"lineNbr": 371,
"author": {
"id": 31072
},
"writtenOn": "2021-12-21T00:19:24Z",
"side": 1,
"message": "Done",
"parentUuid": "101ea155_49382945",
"revId": "e3e00a9ab17f6c3a2689351ab93cb875daec8e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5f97d931_0baeabea",
"filename": "tacker/sol_refactored/conductor/vnflcm_driver_v2.py",
"patchSetId": 1
},
"lineNbr": 203,
"author": {
"id": 31072
},
"writtenOn": "2021-12-20T08:08:16Z",
"side": 1,
"message": "Did you change the data type from list to set because you want to eliminate duplicate elements?",
"revId": "e3e00a9ab17f6c3a2689351ab93cb875daec8e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "bbabc153_1c1f5ab2",
"filename": "tacker/sol_refactored/conductor/vnflcm_driver_v2.py",
"patchSetId": 1
},
"lineNbr": 203,
"author": {
"id": 4149
},
"writtenOn": "2021-12-20T22:25:48Z",
"side": 1,
"message": "see L.273. it is changed to set to take difference between another set(list).",
"parentUuid": "5f97d931_0baeabea",
"revId": "e3e00a9ab17f6c3a2689351ab93cb875daec8e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "21d71fb5_4f07b086",
"filename": "tacker/sol_refactored/conductor/vnflcm_driver_v2.py",
"patchSetId": 1
},
"lineNbr": 203,
"author": {
"id": 31072
},
"writtenOn": "2021-12-21T00:19:24Z",
"side": 1,
"message": "Thank you for the answer. I got it.",
"parentUuid": "bbabc153_1c1f5ab2",
"revId": "e3e00a9ab17f6c3a2689351ab93cb875daec8e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0b87682c_37249ef7",
"filename": "tacker/tests/unit/sol_refactored/infra_drivers/openstack/test_userdata_utils.py",
"patchSetId": 1
},
"lineNbr": 149,
"author": {
"id": 31072
},
"writtenOn": "2021-12-20T08:08:16Z",
"side": 1,
"message": "I think it would be better to add an assert for VDU2 below.\n---\n result \u003d userdata_utils.get_param_capacity(\u0027VDU2\u0027, inst, grant_req)\n self.assertEqual(1, result)",
"revId": "e3e00a9ab17f6c3a2689351ab93cb875daec8e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "edfd24dc_08e9527c",
"filename": "tacker/tests/unit/sol_refactored/infra_drivers/openstack/test_userdata_utils.py",
"patchSetId": 1
},
"lineNbr": 149,
"author": {
"id": 4149
},
"writtenOn": "2021-12-20T22:25:48Z",
"side": 1,
"message": "I see. I will fix.",
"parentUuid": "0b87682c_37249ef7",
"revId": "e3e00a9ab17f6c3a2689351ab93cb875daec8e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "11ea5767_508bc24c",
"filename": "tacker/tests/unit/sol_refactored/infra_drivers/openstack/test_userdata_utils.py",
"patchSetId": 1
},
"lineNbr": 149,
"author": {
"id": 31072
},
"writtenOn": "2021-12-21T00:19:24Z",
"side": 1,
"message": "Done",
"parentUuid": "edfd24dc_08e9527c",
"revId": "e3e00a9ab17f6c3a2689351ab93cb875daec8e43",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink