968 lines
30 KiB
Plaintext
968 lines
30 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4302d060_f51882da",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 7,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-25T09:55:01Z",
|
|
"side": 1,
|
|
"message": "typo: enable -\u003e enables",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "a2fc4735_65e8a979",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 7,
|
|
"author": {
|
|
"id": 34226
|
|
},
|
|
"writtenOn": "2023-01-26T04:05:28Z",
|
|
"side": 1,
|
|
"message": "I will fix.",
|
|
"parentUuid": "4302d060_f51882da",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "63d7789b_9fecbee9",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 7,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-31T07:45:42Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "a2fc4735_65e8a979",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2b8006cd_23fb9b26",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 9,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-25T09:55:01Z",
|
|
"side": 1,
|
|
"message": "typo: enable -\u003e enables",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "88cd7df5_35c3a26f",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 9,
|
|
"author": {
|
|
"id": 34226
|
|
},
|
|
"writtenOn": "2023-01-26T04:05:28Z",
|
|
"side": 1,
|
|
"message": "I will fix.",
|
|
"parentUuid": "2b8006cd_23fb9b26",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "9a1a0fef_2d1d7de2",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 9,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-31T07:45:42Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "88cd7df5_35c3a26f",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "1f816f77_6a229e95",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 15,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-25T09:55:01Z",
|
|
"side": 1,
|
|
"message": "Please add the following.\nImplements: blueprint enhance-placement\n\nAlso, please change the Topic to the following.\nbp/enhance-placement",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "a62a6bbe_d01540ec",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 15,
|
|
"author": {
|
|
"id": 34226
|
|
},
|
|
"writtenOn": "2023-01-26T04:05:28Z",
|
|
"side": 1,
|
|
"message": "I will add. Also I will change the Topic.",
|
|
"parentUuid": "1f816f77_6a229e95",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "2bbb5ace_6345537b",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 15,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-31T07:45:42Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "a62a6bbe_d01540ec",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "7566c59d_615dde69",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 34226
|
|
},
|
|
"writtenOn": "2023-01-26T04:05:28Z",
|
|
"side": 1,
|
|
"message": "Thank you for the review.",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "067d4cd4_8ef3176d",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 34226
|
|
},
|
|
"writtenOn": "2023-01-26T05:47:18Z",
|
|
"side": 1,
|
|
"message": "Thank you for the review.",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "86f0e5b4_d68cce1f",
|
|
"filename": "roles/setup-multi-az/tasks/main.yaml",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 14,
|
|
"author": {
|
|
"id": 34712
|
|
},
|
|
"writtenOn": "2023-01-27T12:56:21Z",
|
|
"side": 1,
|
|
"message": "Please add Note that why the ram needs 4096.\nI think that this is to generate an insufficient resource error, and it is useful for developers if the compute resources of Zuul envs will change in the future.",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b296fc0b_dd782f75",
|
|
"filename": "roles/setup-multi-az/tasks/main.yaml",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 14,
|
|
"author": {
|
|
"id": 34226
|
|
},
|
|
"writtenOn": "2023-01-30T06:32:15Z",
|
|
"side": 1,
|
|
"message": "I wil add comments.",
|
|
"parentUuid": "86f0e5b4_d68cce1f",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "ae088be0_d66d9a7a",
|
|
"filename": "tacker/sol_refactored/common/config.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 70,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-25T09:55:01Z",
|
|
"side": 1,
|
|
"message": "It is better not to have \"a\" to match the others.\na Availability Zone reselection -\u003e Availability Zone reselection",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "69a6d1e5_7eeb1c68",
|
|
"filename": "tacker/sol_refactored/common/config.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 70,
|
|
"author": {
|
|
"id": 34226
|
|
},
|
|
"writtenOn": "2023-01-26T04:05:28Z",
|
|
"side": 1,
|
|
"message": "I will fix.",
|
|
"parentUuid": "ae088be0_d66d9a7a",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "2918e513_f6280395",
|
|
"filename": "tacker/sol_refactored/common/config.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 70,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-31T07:45:42Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "69a6d1e5_7eeb1c68",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "29f3e989_ba08dc12",
|
|
"filename": "tacker/sol_refactored/common/config.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 80,
|
|
"author": {
|
|
"id": 34712
|
|
},
|
|
"writtenOn": "2023-01-27T12:56:21Z",
|
|
"side": 1,
|
|
"message": "Please add `These configs are regular expressions to detect error messages from OpenStack Heat.` to the help message.",
|
|
"range": {
|
|
"startLine": 80,
|
|
"startChar": 23,
|
|
"endLine": 80,
|
|
"endChar": 71
|
|
},
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b51a6fd2_3b9ddd4a",
|
|
"filename": "tacker/sol_refactored/common/config.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 80,
|
|
"author": {
|
|
"id": 34226
|
|
},
|
|
"writtenOn": "2023-01-30T06:32:15Z",
|
|
"side": 1,
|
|
"message": "I will add a message.",
|
|
"parentUuid": "29f3e989_ba08dc12",
|
|
"range": {
|
|
"startLine": 80,
|
|
"startChar": 23,
|
|
"endLine": 80,
|
|
"endChar": 71
|
|
},
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b90d1615_9c0dce4d",
|
|
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 109,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-25T09:55:01Z",
|
|
"side": 1,
|
|
"message": "Will the stack_id in L.105 and L.107 be changed to different values?\nIf the values are the same, I think this process is unnecessary...\nIs it assumed that None is set to stack_id like heal L.307?",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "0e36d31f_7a1bc576",
|
|
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 109,
|
|
"author": {
|
|
"id": 34226
|
|
},
|
|
"writtenOn": "2023-01-26T04:05:28Z",
|
|
"side": 1,
|
|
"message": "The first time stack_create is run, stack_id is None and must be set if it fails.",
|
|
"parentUuid": "b90d1615_9c0dce4d",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "93fde6e3_a0c01b72",
|
|
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 109,
|
|
"author": {
|
|
"id": 34226
|
|
},
|
|
"writtenOn": "2023-01-26T05:47:18Z",
|
|
"side": 1,
|
|
"message": "As a supplement, the stack_id\u0027s of L.105 and L.107 are the same.\nBut in the L.107, stack_id is None, so stack_id is retrieved after processing.\n\"_update_stack_retry\" allows stack_id to be \"None\".",
|
|
"parentUuid": "0e36d31f_7a1bc576",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "7389ffb9_c4d9a391",
|
|
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 109,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-31T07:45:42Z",
|
|
"side": 1,
|
|
"message": "Thank you for your explanation. Let me ask you a few more questions.\nIs the stack_id set because there are cases where the stack_id of L.105 is not None?\nOr is it just setting stack_id according to L.114 and it will always be None?\n(I didn\u0027t understand why you didn\u0027t explicitly set None...)",
|
|
"parentUuid": "93fde6e3_a0c01b72",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "6a3f9d79_94748639",
|
|
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 640,
|
|
"author": {
|
|
"id": 34712
|
|
},
|
|
"writtenOn": "2023-01-27T12:56:21Z",
|
|
"side": 1,
|
|
"message": "It is easily understood to add Note that `If fallback_best_effort is False, AZ reselection is not executed.`",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2e8fd619_d5961557",
|
|
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 640,
|
|
"author": {
|
|
"id": 34226
|
|
},
|
|
"writtenOn": "2023-01-30T06:32:15Z",
|
|
"side": 1,
|
|
"message": "I will add.",
|
|
"parentUuid": "6a3f9d79_94748639",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f4ee7a87_91707df2",
|
|
"filename": "tacker/tests/functional/sol_v2_az_retry/test_az_retry.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 145,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-25T09:55:01Z",
|
|
"side": 1,
|
|
"message": "How about changing the following and deleting L.143-144 and L.166-168?\n```\nwhile self._get_vnfc_zone(inst_result[vdu_idx], \u0027VDU1\u0027, vdu_idx) !\u003d \u0027nova\u0027 and vdu_idx \u003c MAX_SCALE_COUNT:\n```",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "1762e641_94aa5c3a",
|
|
"filename": "tacker/tests/functional/sol_v2_az_retry/test_az_retry.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 145,
|
|
"author": {
|
|
"id": 34226
|
|
},
|
|
"writtenOn": "2023-01-26T04:05:28Z",
|
|
"side": 1,
|
|
"message": "That\u0027s better. I will change it to that.",
|
|
"parentUuid": "f4ee7a87_91707df2",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "e7d0bfe3_8155efa1",
|
|
"filename": "tacker/tests/functional/sol_v2_az_retry/test_az_retry.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 145,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-31T07:45:42Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "1762e641_94aa5c3a",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "60c6dab8_18efb311",
|
|
"filename": "tacker/tests/functional/sol_v2_common/paramgen.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 1345,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-25T09:55:01Z",
|
|
"side": 1,
|
|
"message": "Why don\u0027t you fix it as follows according to the description of sample4 and sample5?\n```\nsample6 is for retry AZ selection test of StandardUserData\n```",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "8fa037c5_41400319",
|
|
"filename": "tacker/tests/functional/sol_v2_common/paramgen.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 1345,
|
|
"author": {
|
|
"id": 34226
|
|
},
|
|
"writtenOn": "2023-01-26T04:05:28Z",
|
|
"side": 1,
|
|
"message": "I will fix.",
|
|
"parentUuid": "60c6dab8_18efb311",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "bf1458a0_14f7dea7",
|
|
"filename": "tacker/tests/functional/sol_v2_common/paramgen.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 1345,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-31T07:45:42Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "8fa037c5_41400319",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "80446525_3afffc7e",
|
|
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/BaseHOT/simple/nested/VDU1.yaml",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 28,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-25T09:55:01Z",
|
|
"side": 1,
|
|
"message": "\"extManagedVLs\" is easier to read.",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "16b32748_50618a2a",
|
|
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/BaseHOT/simple/nested/VDU1.yaml",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 28,
|
|
"author": {
|
|
"id": 34226
|
|
},
|
|
"writtenOn": "2023-01-26T04:05:28Z",
|
|
"side": 1,
|
|
"message": "I will fix.",
|
|
"parentUuid": "80446525_3afffc7e",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "fbec46c7_fa6bbff9",
|
|
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/BaseHOT/simple/nested/VDU1.yaml",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 28,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-31T07:45:42Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "16b32748_50618a2a",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "61cefb54_efcb3994",
|
|
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/BaseHOT/simple/nested/VDU1.yaml",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 29,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-25T09:55:01Z",
|
|
"side": 1,
|
|
"message": "\"InstantiateVnfRequest\" is better according to SOL.",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "82af14b6_30e9c383",
|
|
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/BaseHOT/simple/nested/VDU1.yaml",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 29,
|
|
"author": {
|
|
"id": 34226
|
|
},
|
|
"writtenOn": "2023-01-26T04:05:28Z",
|
|
"side": 1,
|
|
"message": "I will fix.",
|
|
"parentUuid": "61cefb54_efcb3994",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "7d82c4c1_46f5e45f",
|
|
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/BaseHOT/simple/nested/VDU1.yaml",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 29,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-31T07:45:42Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "82af14b6_30e9c383",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "69c97ad0_05da333b",
|
|
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/BaseHOT/simple/nested/VDU1.yaml",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 42,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-25T09:55:01Z",
|
|
"side": 1,
|
|
"message": "\"extManagedVLs\" is easier to read.",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "7719c89c_dea92df9",
|
|
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/BaseHOT/simple/nested/VDU1.yaml",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 42,
|
|
"author": {
|
|
"id": 34226
|
|
},
|
|
"writtenOn": "2023-01-26T04:05:28Z",
|
|
"side": 1,
|
|
"message": "I will fix.",
|
|
"parentUuid": "69c97ad0_05da333b",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "aef528b7_f97c710a",
|
|
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/BaseHOT/simple/nested/VDU1.yaml",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 42,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-31T07:45:42Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "7719c89c_dea92df9",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "28041710_e90ba49b",
|
|
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/BaseHOT/simple/nested/VDU1.yaml",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 43,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-25T09:55:01Z",
|
|
"side": 1,
|
|
"message": "\"InstantiateVnfRequest\" is better according to SOL.",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2c728e5d_9e6a3f0c",
|
|
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/BaseHOT/simple/nested/VDU1.yaml",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 43,
|
|
"author": {
|
|
"id": 34226
|
|
},
|
|
"writtenOn": "2023-01-26T04:05:28Z",
|
|
"side": 1,
|
|
"message": "I will fix.",
|
|
"parentUuid": "28041710_e90ba49b",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "5d967726_83ff6f2e",
|
|
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/BaseHOT/simple/nested/VDU1.yaml",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 43,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-31T07:45:42Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "2c728e5d_9e6a3f0c",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "88d3fb41_2e5e4500",
|
|
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/BaseHOT/simple/sample6.yaml",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 19,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-25T09:55:01Z",
|
|
"side": 1,
|
|
"message": "\"extManagedVLs\" is easier to read.\n\"InstantiateVnfRequest\" is better according to SOL.",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "3792ab12_c2ab479d",
|
|
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/BaseHOT/simple/sample6.yaml",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 19,
|
|
"author": {
|
|
"id": 34226
|
|
},
|
|
"writtenOn": "2023-01-26T04:05:28Z",
|
|
"side": 1,
|
|
"message": "I will fix.",
|
|
"parentUuid": "88d3fb41_2e5e4500",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "d3260698_0619a6a5",
|
|
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/BaseHOT/simple/sample6.yaml",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 19,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-31T07:45:42Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "3792ab12_c2ab479d",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "da3089af_eaf87ca3",
|
|
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/Definitions/v2_sample6_types.yaml",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 55,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-25T09:55:01Z",
|
|
"side": 1,
|
|
"message": "Could you please add a blank line at the end according to the other files?",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "810817a2_d23fd36d",
|
|
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/Definitions/v2_sample6_types.yaml",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 55,
|
|
"author": {
|
|
"id": 34226
|
|
},
|
|
"writtenOn": "2023-01-26T04:05:28Z",
|
|
"side": 1,
|
|
"message": "I wil fix.",
|
|
"parentUuid": "da3089af_eaf87ca3",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "97b84ed2_26cc3ec7",
|
|
"filename": "tacker/tests/functional/sol_v2_common/samples/userdata_standard_az_retry/contents/Definitions/v2_sample6_types.yaml",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 55,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-31T07:45:42Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "810817a2_d23fd36d",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2abf0496_5ed57ca0",
|
|
"filename": "tacker/tests/unit/sol_refactored/infra_drivers/openstack/test_openstack.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 4216,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-25T09:55:01Z",
|
|
"side": 1,
|
|
"message": "There doesn\u0027t seem to be a test for cases where the \"placement_az_select_retry\" limit has been reached, so how about adding it separately from this test?",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "5ad39b33_552306b1",
|
|
"filename": "tacker/tests/unit/sol_refactored/infra_drivers/openstack/test_openstack.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 4216,
|
|
"author": {
|
|
"id": 34226
|
|
},
|
|
"writtenOn": "2023-01-26T04:05:28Z",
|
|
"side": 1,
|
|
"message": "I understand. I will add that test case.",
|
|
"parentUuid": "2abf0496_5ed57ca0",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "eaaf4d59_9f75d339",
|
|
"filename": "tacker/tests/unit/sol_refactored/infra_drivers/openstack/test_openstack.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 4216,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-31T07:45:42Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "5ad39b33_552306b1",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "21608c36_942c7175",
|
|
"filename": "tacker/tests/unit/sol_refactored/infra_drivers/openstack/test_openstack.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 4372,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-25T09:55:01Z",
|
|
"side": 1,
|
|
"message": "I think it also is better to check the following.\n```\nself.assertEqual(use_zone_list[2][\u0027VDU1-1\u0027], use_zone_list[2][\u0027VDU1-2\u0027])\n```",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "ce25e231_dab09c9a",
|
|
"filename": "tacker/tests/unit/sol_refactored/infra_drivers/openstack/test_openstack.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 4372,
|
|
"author": {
|
|
"id": 34226
|
|
},
|
|
"writtenOn": "2023-01-26T04:05:28Z",
|
|
"side": 1,
|
|
"message": "I will add that check.",
|
|
"parentUuid": "21608c36_942c7175",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "cfda3037_ab574cb8",
|
|
"filename": "tacker/tests/unit/sol_refactored/infra_drivers/openstack/test_openstack.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 4372,
|
|
"author": {
|
|
"id": 31668
|
|
},
|
|
"writtenOn": "2023-01-31T07:45:42Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "ce25e231_dab09c9a",
|
|
"revId": "2610295d100682dc13e3e90af60ad91f7fb7de59",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |