openstack
/
tacker
Code Issues Proposed changes
tacker/250d918ff32f827e6ce24e79c14...

339 lines
10 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "172f7cb7_1b92726f",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 10
},
"lineNbr": 0,
"author": {
"id": 4149
},
"writtenOn": "2022-01-07T04:33:10Z",
"side": 1,
"message": "Thank you for the review.",
"revId": "250d918ff32f827e6ce24e79c14c824feda8aa45",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c7048d96_455f6df8",
"filename": "tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py",
"patchSetId": 10
},
"lineNbr": 129,
"author": {
"id": 31668
},
"writtenOn": "2022-01-07T02:29:44Z",
"side": 1,
"message": "It is also used in the scale test, so it is better to modify \"terminate\" to \"terminate/scale\".",
"revId": "250d918ff32f827e6ce24e79c14c824feda8aa45",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0e3c9616_8d13873f",
"filename": "tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py",
"patchSetId": 10
},
"lineNbr": 129,
"author": {
"id": 4149
},
"writtenOn": "2022-01-07T04:33:10Z",
"side": 1,
"message": "I will fix.",
"parentUuid": "c7048d96_455f6df8",
"revId": "250d918ff32f827e6ce24e79c14c824feda8aa45",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "01f42ecb_2a424cf3",
"filename": "tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py",
"patchSetId": 10
},
"lineNbr": 129,
"author": {
"id": 31668
},
"writtenOn": "2022-01-07T09:33:06Z",
"side": 1,
"message": "Done",
"parentUuid": "0e3c9616_8d13873f",
"revId": "250d918ff32f827e6ce24e79c14c824feda8aa45",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e06977b9_58158b9f",
"filename": "tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py",
"patchSetId": 10
},
"lineNbr": 132,
"author": {
"id": 31668
},
"writtenOn": "2022-01-07T02:29:44Z",
"side": 1,
"message": "ditto",
"revId": "250d918ff32f827e6ce24e79c14c824feda8aa45",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e1b932c1_960b7bdb",
"filename": "tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py",
"patchSetId": 10
},
"lineNbr": 132,
"author": {
"id": 4149
},
"writtenOn": "2022-01-07T04:33:10Z",
"side": 1,
"message": "ditto",
"parentUuid": "e06977b9_58158b9f",
"revId": "250d918ff32f827e6ce24e79c14c824feda8aa45",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "eb960ac3_0615fe3e",
"filename": "tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py",
"patchSetId": 10
},
"lineNbr": 132,
"author": {
"id": 31668
},
"writtenOn": "2022-01-07T09:33:06Z",
"side": 1,
"message": "Done",
"parentUuid": "e1b932c1_960b7bdb",
"revId": "250d918ff32f827e6ce24e79c14c824feda8aa45",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "184f4f4d_fa41c579",
"filename": "tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py",
"patchSetId": 10
},
"lineNbr": 554,
"author": {
"id": 31668
},
"writtenOn": "2022-01-07T02:29:44Z",
"side": 1,
"message": "Although not important in this test, the operationState before grant is \"STARTING\".",
"revId": "250d918ff32f827e6ce24e79c14c824feda8aa45",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "50f78a9b_c72dd70d",
"filename": "tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py",
"patchSetId": 10
},
"lineNbr": 554,
"author": {
"id": 4149
},
"writtenOn": "2022-01-07T04:33:10Z",
"side": 1,
"message": "You are right. I will fix.",
"parentUuid": "184f4f4d_fa41c579",
"revId": "250d918ff32f827e6ce24e79c14c824feda8aa45",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "10e85d09_6743c1f0",
"filename": "tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py",
"patchSetId": 10
},
"lineNbr": 554,
"author": {
"id": 31668
},
"writtenOn": "2022-01-07T09:33:06Z",
"side": 1,
"message": "Done",
"parentUuid": "50f78a9b_c72dd70d",
"revId": "250d918ff32f827e6ce24e79c14c824feda8aa45",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6fd67ef0_c2701523",
"filename": "tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py",
"patchSetId": 10
},
"lineNbr": 644,
"author": {
"id": 31668
},
"writtenOn": "2022-01-07T02:29:44Z",
"side": 1,
"message": "Although not important in this test, the operationState before grant is \"STARTING\".",
"revId": "250d918ff32f827e6ce24e79c14c824feda8aa45",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "42b9c887_88354db0",
"filename": "tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py",
"patchSetId": 10
},
"lineNbr": 644,
"author": {
"id": 4149
},
"writtenOn": "2022-01-07T04:33:10Z",
"side": 1,
"message": "I will fix.",
"parentUuid": "6fd67ef0_c2701523",
"revId": "250d918ff32f827e6ce24e79c14c824feda8aa45",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b75905d2_88b17897",
"filename": "tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py",
"patchSetId": 10
},
"lineNbr": 644,
"author": {
"id": 31668
},
"writtenOn": "2022-01-07T09:33:06Z",
"side": 1,
"message": "Done",
"parentUuid": "42b9c887_88354db0",
"revId": "250d918ff32f827e6ce24e79c14c824feda8aa45",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c8cd0b95_aa4a67fc",
"filename": "tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py",
"patchSetId": 10
},
"lineNbr": 736,
"author": {
"id": 31668
},
"writtenOn": "2022-01-07T02:29:44Z",
"side": 1,
"message": "Although not important in this test, the operationState before grant is \"STARTING\".",
"revId": "250d918ff32f827e6ce24e79c14c824feda8aa45",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4984c589_46860442",
"filename": "tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py",
"patchSetId": 10
},
"lineNbr": 736,
"author": {
"id": 4149
},
"writtenOn": "2022-01-07T04:33:10Z",
"side": 1,
"message": "I will fix.",
"parentUuid": "c8cd0b95_aa4a67fc",
"revId": "250d918ff32f827e6ce24e79c14c824feda8aa45",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f69157de_6a182429",
"filename": "tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py",
"patchSetId": 10
},
"lineNbr": 736,
"author": {
"id": 31668
},
"writtenOn": "2022-01-07T09:33:06Z",
"side": 1,
"message": "Done",
"parentUuid": "4984c589_46860442",
"revId": "250d918ff32f827e6ce24e79c14c824feda8aa45",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "537521b4_23352ecf",
"filename": "tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py",
"patchSetId": 10
},
"lineNbr": 757,
"author": {
"id": 31668
},
"writtenOn": "2022-01-07T02:29:44Z",
"side": 1,
"message": "Is it unnecessary to confirm that \"_links\" are created correctly?",
"revId": "250d918ff32f827e6ce24e79c14c824feda8aa45",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "03aca264_e51f32e1",
"filename": "tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py",
"patchSetId": 10
},
"lineNbr": 757,
"author": {
"id": 4149
},
"writtenOn": "2022-01-07T04:33:10Z",
"side": 1,
"message": "Ok, it is better to check it. I will add.",
"parentUuid": "537521b4_23352ecf",
"revId": "250d918ff32f827e6ce24e79c14c824feda8aa45",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "9641a1be_87828c5b",
"filename": "tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py",
"patchSetId": 10
},
"lineNbr": 757,
"author": {
"id": 31668
},
"writtenOn": "2022-01-07T09:33:06Z",
"side": 1,
"message": "Done",
"parentUuid": "03aca264_e51f32e1",
"revId": "250d918ff32f827e6ce24e79c14c824feda8aa45",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink