tacker/376324e9cbbf6d246a51021c741...

180 lines
5.5 KiB
Plaintext

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "06285fe4_e1516e53",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 9
},
"lineNbr": 0,
"author": {
"id": 4149
},
"writtenOn": "2022-01-06T23:29:38Z",
"side": 1,
"message": "Thank you for the review.",
"revId": "376324e9cbbf6d246a51021c741863a388b4e15b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "77bb0277_94e6e9ac",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 9
},
"lineNbr": 0,
"author": {
"id": 4149
},
"writtenOn": "2022-01-06T23:36:57Z",
"side": 1,
"message": "Thank you for the review.",
"revId": "376324e9cbbf6d246a51021c741863a388b4e15b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "bd885f14_2d3c64e5",
"filename": "tacker/sol_refactored/common/vnfd_utils.py",
"patchSetId": 9
},
"lineNbr": 370,
"author": {
"id": 31072
},
"writtenOn": "2022-01-06T08:09:30Z",
"side": 1,
"message": "I think it\u0027s better to describe that the current implementation supports only uniform deltas and not non-uniform deltas, according to the Spec.\n---\nhttps://specs.openstack.org/openstack/tacker-specs/specs/yoga/enhance-nfv-solv3-lcm-operation.html\n---\nTacker does not support non-uniform deltas defined in ETSI NFV SOL001 8. Therefore, uniform delta corresponding to “number_of_instances” can be set and “number_of_instances” is the same regardless of scale_level.",
"range": {
"startLine": 369,
"startChar": 16,
"endLine": 370,
"endChar": 48
},
"revId": "376324e9cbbf6d246a51021c741863a388b4e15b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c9070bf3_c45c574c",
"filename": "tacker/sol_refactored/common/vnfd_utils.py",
"patchSetId": 9
},
"lineNbr": 370,
"author": {
"id": 4149
},
"writtenOn": "2022-01-06T23:29:38Z",
"side": 1,
"message": "I see. I will add a comment.",
"parentUuid": "bd885f14_2d3c64e5",
"range": {
"startLine": 369,
"startChar": 16,
"endLine": 370,
"endChar": 48
},
"revId": "376324e9cbbf6d246a51021c741863a388b4e15b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "057751e0_09531d4f",
"filename": "tacker/sol_refactored/common/vnfd_utils.py",
"patchSetId": 9
},
"lineNbr": 370,
"author": {
"id": 31072
},
"writtenOn": "2022-01-11T01:40:12Z",
"side": 1,
"message": "Done",
"parentUuid": "c9070bf3_c45c574c",
"range": {
"startLine": 369,
"startChar": 16,
"endLine": 370,
"endChar": 48
},
"revId": "376324e9cbbf6d246a51021c741863a388b4e15b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "8217110d_d86ffc6c",
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
"patchSetId": 9
},
"lineNbr": 197,
"author": {
"id": 31072
},
"writtenOn": "2022-01-06T08:22:19Z",
"side": 1,
"message": "Similar to \"_make_instantiated_vnf_info\", I think this method was worth making unittests, but what do you think?",
"range": {
"startLine": 197,
"startChar": 8,
"endLine": 197,
"endChar": 17
},
"revId": "376324e9cbbf6d246a51021c741863a388b4e15b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a697a6ec_9a3f33c1",
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
"patchSetId": 9
},
"lineNbr": 197,
"author": {
"id": 4149
},
"writtenOn": "2022-01-06T23:29:38Z",
"side": 1,
"message": "I don\u0027t think UT of _make_hot has high priority because core methods for making HOT (defined in userdata_utils.py) are tested. Also the code itself is short and code review is easy.\n\n(making instantiatedVnfInfo is very complicated and hard to examine by real running and code review is hard. UT of it was necessary to do debugging the code before running.)",
"parentUuid": "8217110d_d86ffc6c",
"range": {
"startLine": 197,
"startChar": 8,
"endLine": 197,
"endChar": 17
},
"revId": "376324e9cbbf6d246a51021c741863a388b4e15b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c177ec97_bb33994e",
"filename": "tacker/sol_refactored/infra_drivers/openstack/openstack.py",
"patchSetId": 9
},
"lineNbr": 197,
"author": {
"id": 31072
},
"writtenOn": "2022-01-11T01:40:12Z",
"side": 1,
"message": "I see. No problem.",
"parentUuid": "a697a6ec_9a3f33c1",
"range": {
"startLine": 197,
"startChar": 8,
"endLine": 197,
"endChar": 17
},
"revId": "376324e9cbbf6d246a51021c741863a388b4e15b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}