tacker/3e029e698f403bd996f7994bbee...

245 lines
6.9 KiB
Plaintext

{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "e82a7723_6da4f1cf",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 31857
},
"writtenOn": "2022-01-12T09:49:47Z",
"side": 1,
"message": "Could you please follow the guideline?\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\n\u003e * The first line should be limited to 50 characters and should not end with a period.\n\u003e * Subsequent lines should be wrapped at 72 characters.",
"revId": "3e029e698f403bd996f7994bbee6a833b69ac700",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "9b64faee_ecba2279",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 31857
},
"writtenOn": "2022-01-20T05:51:20Z",
"side": 1,
"message": "I\u0027ve confirmed in PS3.",
"parentUuid": "e82a7723_6da4f1cf",
"revId": "3e029e698f403bd996f7994bbee6a833b69ac700",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f1f785d3_c5bb3255",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 31857
},
"writtenOn": "2022-01-12T09:49:47Z",
"side": 1,
"message": "Thanks for your patch, please kindly find my comments.",
"revId": "3e029e698f403bd996f7994bbee6a833b69ac700",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "72b64d54_c430bf0a",
"filename": "tacker/sol_refactored/controller/vnflcm_view.py",
"patchSetId": 2
},
"lineNbr": 96,
"author": {
"id": 31857
},
"writtenOn": "2022-01-12T09:49:47Z",
"side": 1,
"message": "There seems to be no unit test through this route. Could you add it?",
"range": {
"startLine": 96,
"startChar": 20,
"endLine": 96,
"endChar": 41
},
"revId": "3e029e698f403bd996f7994bbee6a833b69ac700",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9acb090a_1e68c8a7",
"filename": "tacker/sol_refactored/controller/vnflcm_view.py",
"patchSetId": 2
},
"lineNbr": 96,
"author": {
"id": 9200
},
"writtenOn": "2022-01-14T08:19:57Z",
"side": 1,
"message": "Added UTs for these cases.",
"parentUuid": "72b64d54_c430bf0a",
"range": {
"startLine": 96,
"startChar": 20,
"endLine": 96,
"endChar": 41
},
"revId": "3e029e698f403bd996f7994bbee6a833b69ac700",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f58bddfa_2e1e13ea",
"filename": "tacker/sol_refactored/controller/vnflcm_view.py",
"patchSetId": 2
},
"lineNbr": 96,
"author": {
"id": 31857
},
"writtenOn": "2022-01-20T05:51:20Z",
"side": 1,
"message": "I\u0027ve confirmed in PS3.",
"parentUuid": "9acb090a_1e68c8a7",
"range": {
"startLine": 96,
"startChar": 20,
"endLine": 96,
"endChar": 41
},
"revId": "3e029e698f403bd996f7994bbee6a833b69ac700",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7b6f7628_345dce37",
"filename": "tacker/sol_refactored/controller/vnflcm_view.py",
"patchSetId": 2
},
"lineNbr": 100,
"author": {
"id": 31857
},
"writtenOn": "2022-01-12T09:49:47Z",
"side": 1,
"message": "ditto.",
"range": {
"startLine": 100,
"startChar": 20,
"endLine": 100,
"endChar": 56
},
"revId": "3e029e698f403bd996f7994bbee6a833b69ac700",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2615526f_91263008",
"filename": "tacker/sol_refactored/controller/vnflcm_view.py",
"patchSetId": 2
},
"lineNbr": 100,
"author": {
"id": 31857
},
"writtenOn": "2022-01-20T05:51:20Z",
"side": 1,
"message": "I\u0027ve confirmed in PS3.",
"parentUuid": "7b6f7628_345dce37",
"range": {
"startLine": 100,
"startChar": 20,
"endLine": 100,
"endChar": 56
},
"revId": "3e029e698f403bd996f7994bbee6a833b69ac700",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1c7ebe0e_c13eb4ff",
"filename": "tacker/sol_refactored/controller/vnflcm_view.py",
"patchSetId": 2
},
"lineNbr": 176,
"author": {
"id": 31072
},
"writtenOn": "2022-01-11T08:28:32Z",
"side": 1,
"message": "Just a question.\nThis patch doesn\u0027t fix the try clause, but in what cases would this exception occur?",
"range": {
"startLine": 176,
"startChar": 30,
"endLine": 176,
"endChar": 39
},
"revId": "3e029e698f403bd996f7994bbee6a833b69ac700",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "13498d09_f5c2019a",
"filename": "tacker/sol_refactored/controller/vnflcm_view.py",
"patchSetId": 2
},
"lineNbr": 176,
"author": {
"id": 9200
},
"writtenOn": "2022-01-14T08:19:57Z",
"side": 1,
"message": "TypeError happens when val isn\u0027t a dict.\nFor example, klist\u003d[\u0027foo\u0027,\u0027bar\u0027] and odict[\u0027foo\u0027] is an integer.",
"parentUuid": "1c7ebe0e_c13eb4ff",
"range": {
"startLine": 176,
"startChar": 30,
"endLine": 176,
"endChar": 39
},
"revId": "3e029e698f403bd996f7994bbee6a833b69ac700",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "37d2eab6_2a453e2a",
"filename": "tacker/sol_refactored/controller/vnflcm_view.py",
"patchSetId": 2
},
"lineNbr": 176,
"author": {
"id": 31072
},
"writtenOn": "2022-01-17T01:57:19Z",
"side": 1,
"message": "Thank you for the answer. I see.",
"parentUuid": "13498d09_f5c2019a",
"range": {
"startLine": 176,
"startChar": 30,
"endLine": 176,
"endChar": 39
},
"revId": "3e029e698f403bd996f7994bbee6a833b69ac700",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}