openstack
/
tap-as-a-service
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(5 comments)

Patch-set: 1
Label: Code-Review=-1
This commit is contained in:
Gerrit User 6854 2016-04-19 11:29:13 +00:00 committed by Gerrit Code Review
parent 66e6d40ea0
commit 89897dd4da
1 changed files with 95 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

95
d9441339d332778160fba91282579a2d266ee164 Normal file
View File

@ -0,0 +1,95 @@
{
"comments": [
{
"key": {
"uuid": "1a122d0e_e3d9e223",
"filename": "neutron_taas/services/taas/service_drivers/taas_rpc.py",
"patchSetId": 1
},
"lineNbr": 1,
"author": {
"id": 6854
},
"writtenOn": "2016-04-19T11:29:13Z",
"side": 1,
"message": "can you preserve the original copyright notice for moved code?",
"revId": "d9441339d332778160fba91282579a2d266ee164",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_263928a5",
"filename": "neutron_taas/services/taas/service_drivers/taas_rpc.py",
"patchSetId": 1
},
"lineNbr": 32,
"author": {
"id": 6854
},
"writtenOn": "2016-04-19T11:29:13Z",
"side": 1,
"message": "is this necessary?",
"revId": "d9441339d332778160fba91282579a2d266ee164",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_66c840a9",
"filename": "neutron_taas/services/taas/service_drivers/taas_rpc.py",
"patchSetId": 1
},
"lineNbr": 33,
"author": {
"id": 6854
},
"writtenOn": "2016-04-19T11:29:13Z",
"side": 1,
"message": "where TaasDriver is?",
"range": {
"startLine": 33,
"startChar": 36,
"endLine": 33,
"endChar": 46
},
"revId": "d9441339d332778160fba91282579a2d266ee164",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_a66a58b1",
"filename": "neutron_taas/services/taas/taas_plugin.py",
"patchSetId": 1
},
"lineNbr": 63,
"author": {
"id": 6854
},
"writtenOn": "2016-04-19T11:29:13Z",
"side": 1,
"message": "the one in the base class (TaasPluginBase) isn\u0027t enough?t",
"revId": "d9441339d332778160fba91282579a2d266ee164",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_e660d0d1",
"filename": "neutron_taas/services/taas/taas_plugin.py",
"patchSetId": 1
},
"lineNbr": 66,
"author": {
"id": 6854
},
"writtenOn": "2016-04-19T11:29:13Z",
"side": 1,
"message": "ditto",
"revId": "d9441339d332778160fba91282579a2d266ee164",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}