openstack
/
tap-as-a-service
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(5 comments)

Patch-set: 1
Label: Verified=0
This commit is contained in:
Gerrit User 17147 2016-04-19 12:00:01 +00:00 committed by Gerrit Code Review
parent 4783edc8cc
commit c85a9c23ca
1 changed files with 96 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
d9441339d332778160fba91282579a2d266ee164
View File

@ -17,6 +17,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_c6715446",
"filename": "neutron_taas/services/taas/service_drivers/taas_rpc.py",
"patchSetId": 1
},
"lineNbr": 1,
"author": {
"id": 17147
},
"writtenOn": "2016-04-19T12:00:01Z",
"side": 1,
"message": "thanks, I fixed this.",
"parentUuid": "1a122d0e_e3d9e223",
"revId": "d9441339d332778160fba91282579a2d266ee164",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_263928a5",
@ -34,6 +52,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_86f75c8a",
"filename": "neutron_taas/services/taas/service_drivers/taas_rpc.py",
"patchSetId": 1
},
"lineNbr": 32,
"author": {
"id": 17147
},
"writtenOn": "2016-04-19T12:00:01Z",
"side": 1,
"message": "thanks, this is not necessary.\nI removed this.",
"parentUuid": "1a122d0e_263928a5",
"revId": "d9441339d332778160fba91282579a2d266ee164",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_66c840a9",
@ -57,6 +93,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_06bd0cb7",
"filename": "neutron_taas/services/taas/service_drivers/taas_rpc.py",
"patchSetId": 1
},
"lineNbr": 33,
"author": {
"id": 17147
},
"writtenOn": "2016-04-19T12:00:01Z",
"side": 1,
"message": "Sorry, this is my mistake.\nI added TaasDriver to __init__.py.",
"parentUuid": "1a122d0e_66c840a9",
"range": {
"startLine": 33,
"startChar": 36,
"endLine": 33,
"endChar": 46
},
"revId": "d9441339d332778160fba91282579a2d266ee164",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_a66a58b1",
@ -74,6 +134,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_a9c6a997",
"filename": "neutron_taas/services/taas/taas_plugin.py",
"patchSetId": 1
},
"lineNbr": 63,
"author": {
"id": 17147
},
"writtenOn": "2016-04-19T12:00:01Z",
"side": 1,
"message": "Thanks, you\u0027re right.\nI removed this.",
"parentUuid": "1a122d0e_a66a58b1",
"revId": "d9441339d332778160fba91282579a2d266ee164",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_e660d0d1",
@ -90,6 +168,24 @@
"revId": "d9441339d332778160fba91282579a2d266ee164",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_c91b25c9",
"filename": "neutron_taas/services/taas/taas_plugin.py",
"patchSetId": 1
},
"lineNbr": 66,
"author": {
"id": 17147
},
"writtenOn": "2016-04-19T12:00:01Z",
"side": 1,
"message": "I removed this.",
"parentUuid": "1a122d0e_e660d0d1",
"revId": "d9441339d332778160fba91282579a2d266ee164",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}