openstack/taskflow
Code Issues Proposed changes

Replace abc.abstractproperty with property and abc.abstractmethod

Browse Source 
Replace abc.abstractproperty with property and abc.abstractmethod,
as abc.abstractproperty has been deprecated since python3.3[1]

[1]https://docs.python.org/3.8/whatsnew/3.3.html?highlight=deprecated#abc

Change-Id: I1bcecd99d8856c26621a5304d9f7f01f8f111918
This commit is contained in:
ljhuang 2022-08-03 16:21:36 +08:00
parent 3bb577e338
commit 56413aa3c5
4 changed files with 20 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
taskflow/engines/base.py
View File

@ -55,11 +55,13 @@ class Engine(object, metaclass=abc.ABCMeta):
"""The options that were passed to this engine on construction.""" """The options that were passed to this engine on construction."""
return self._options return self._options
@abc.abstractproperty @property
@abc.abstractmethod
def storage(self): def storage(self):
"""The storage unit for this engine.""" """The storage unit for this engine."""
@abc.abstractproperty @property
@abc.abstractmethod
def statistics(self): def statistics(self):
"""A dictionary of runtime statistics this engine has gathered. """A dictionary of runtime statistics this engine has gathered.

3
taskflow/flow.py
View File

@ -128,6 +128,7 @@ class Flow(object, metaclass=abc.ABCMeta):
provides.update(item.provides) provides.update(item.provides)
return frozenset(provides) return frozenset(provides)
@abc.abstractproperty @property
@abc.abstractmethod
def requires(self): def requires(self):
"""Set of *unsatisfied* symbol names required by the flow.""" """Set of *unsatisfied* symbol names required by the flow."""

18
taskflow/jobs/base.py
View File

@ -142,11 +142,13 @@ class Job(object, metaclass=abc.ABCMeta):
book_data = {} book_data = {}
self._book_data = book_data self._book_data = book_data
@abc.abstractproperty @property
@abc.abstractmethod
def last_modified(self): def last_modified(self):
"""The datetime the job was last modified.""" """The datetime the job was last modified."""
@abc.abstractproperty @property
@abc.abstractmethod
def created_on(self): def created_on(self):
"""The datetime the job was created on.""" """The datetime the job was created on."""
@ -155,11 +157,13 @@ class Job(object, metaclass=abc.ABCMeta):
"""The board this job was posted on or was created from.""" """The board this job was posted on or was created from."""
return self._board return self._board
@abc.abstractproperty @property
@abc.abstractmethod
def state(self): def state(self):
"""Access the current state of this job.""" """Access the current state of this job."""
@abc.abstractproperty @property
@abc.abstractmethod
def priority(self): def priority(self):
"""The :py:class:`~.JobPriority` of this job.""" """The :py:class:`~.JobPriority` of this job."""
@ -397,7 +401,8 @@ class JobBoard(object, metaclass=abc.ABCMeta):
appear (if None then waits forever). appear (if None then waits forever).
""" """
@abc.abstractproperty @property
@abc.abstractmethod
def job_count(self): def job_count(self):
"""Returns how many jobs are on this jobboard. """Returns how many jobs are on this jobboard.
@ -516,7 +521,8 @@ class JobBoard(object, metaclass=abc.ABCMeta):
:type entity: :py:class:`~taskflow.types.entity.Entity` :type entity: :py:class:`~taskflow.types.entity.Entity`
""" """
@abc.abstractproperty @property
@abc.abstractmethod
def connected(self): def connected(self):
"""Returns if this jobboard is connected.""" """Returns if this jobboard is connected."""

3
taskflow/persistence/base.py
View File

@ -42,7 +42,8 @@ class Backend(object, metaclass=abc.ABCMeta):
class Connection(object, metaclass=abc.ABCMeta): class Connection(object, metaclass=abc.ABCMeta):
"""Base class for backend connections.""" """Base class for backend connections."""
@abc.abstractproperty @property
@abc.abstractmethod
def backend(self): def backend(self):
"""Returns the backend this connection is associated with.""" """Returns the backend this connection is associated with."""