Ensure we register & deregister conductor listeners
Instead of just registering engine listeners that were returned, make sure we also deregister them when the engine has either finished or failed. This ensures that if a listener has hold of any resources (or other) that it can clean those up and be sure that its deregister call will be made. Change-Id: Ia1420c435156362698702fed2bda11c2a0fef803
This commit is contained in:
@@ -436,6 +436,38 @@ def get_duplicate_keys(iterable, key=None):
|
||||
return duplicates
|
||||
|
||||
|
||||
class ListenerStack(object):
|
||||
"""Listeners that are deregistered on context manager exit.
|
||||
|
||||
TODO(harlowja): replace this with ``contextlib.ExitStack`` or equivalent
|
||||
in the future (that code is in python3.2+ and in a few backports that
|
||||
provide nearly equivalent functionality). When/if
|
||||
https://review.openstack.org/#/c/164222/ merges we should be able to
|
||||
remove this since listeners are already context managers.
|
||||
"""
|
||||
|
||||
def __init__(self, log):
|
||||
self._registered = []
|
||||
self._log = log
|
||||
|
||||
def register(self, listeners):
|
||||
for listener in listeners:
|
||||
listener.register()
|
||||
self._registered.append(listener)
|
||||
|
||||
def __enter__(self):
|
||||
return self
|
||||
|
||||
def __exit__(self, type, value, tb):
|
||||
while self._registered:
|
||||
listener = self._registered.pop()
|
||||
try:
|
||||
listener.deregister()
|
||||
except Exception:
|
||||
self._log.warn("Failed deregistering listener '%s'",
|
||||
listener, exc_info=True)
|
||||
|
||||
|
||||
class ExponentialBackoff(object):
|
||||
"""An iterable object that will yield back an exponential delay sequence.
|
||||
|
||||
|
||||
Reference in New Issue
Block a user