From 074dee8c76130d46a77c7d31ea5ba24d554a5217 Mon Sep 17 00:00:00 2001 From: "Andrea Frittoli (andreaf)" Date: Fri, 20 Nov 2015 06:40:54 +0000 Subject: [PATCH] Skip test that rely on creds by role The legacy credential providers raises an exception when is_role_available is invoked. This causes tests that rely on credentials by role to fail rather than skip when that credential provider is used. The wrong behaviour was introduced in change I351f86f0570070105bbf24f2d904e917feea6e57, and since than it's causing periodic and experimental jobs using the legacy credential provider to fail. Fixing that. Change-Id: I0ca0b96fc618ffe60851984a9c6d46b0507878d4 --- tempest/common/credentials_factory.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tempest/common/credentials_factory.py b/tempest/common/credentials_factory.py index 75639b22b4..38bde2e084 100644 --- a/tempest/common/credentials_factory.py +++ b/tempest/common/credentials_factory.py @@ -118,11 +118,11 @@ class LegacyCredentialProvider(cred_provider.CredentialProvider): raise exceptions.InvalidConfiguration(msg) def is_role_available(self, role): - msg = "Credentials being specified through the config file can not be"\ - " used with tests that specify using credentials by roles. "\ - "Either exclude/skip the tests doing this or use either an "\ - "test_accounts_file or dynamic credentials." - raise exceptions.InvalidConfiguration(msg) + # NOTE(andreaf) LegacyCredentialProvider does not support credentials + # by role, so returning always False. + # Test that rely on credentials by role should use this to skip + # when this is credential provider is used + return False # Return the right implementation of CredentialProvider based on config