openstack/tempest
Code Issues Proposed changes

Return complete response from tenant_networks_client

Browse Source 
Currently compute tenant_networks_client returns Response by
removing top key from Response.
For example-
 return service_client.ResponseBody(resp, body['network'])

As service clients are in direction to move to Tempest-lib, all
service clients should return Response without any truncation.
One good example is Resource pagination links which are lost with current
way of return value. Resource pagination links are present in parallel
(not inside) to top key of Response.

This patch makes compute tenant_networks_client to return
complete Response body.

Change-Id: Ie0f6e709cbb3a215752344cb39f2f7a6f5a7a91b
Implements: blueprint method-return-value-and-move-service-clients-to-lib
This commit is contained in:
ghanshyam
2015-08-24 17:52:36 +09:00
parent d4038b4f99
commit 0b84c3cf0e
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tempest/api/compute/test_tenant_networks.py
View File

@@ -25,9 +25,10 @@ class NetworksTestJSON(base.BaseV2ComputeTest):
@test.idempotent_id('edfea98e-bbe3-4c7a-9739-87b986baff26')
def test_list_show_tenant_networks(self):
tenant_networks = self.client.list_tenant_networks()
tenant_networks = self.client.list_tenant_networks()['networks']
self.assertNotEmpty(tenant_networks, "No tenant networks found.")
for net in tenant_networks:
tenant_network = self.client.show_tenant_network(net['id'])
tenant_network = (self.client.show_tenant_network(net['id'])
['network'])
self.assertEqual(net['id'], tenant_network['id'])

4
tempest/services/compute/json/tenant_networks_client.py
View File

@@ -24,10 +24,10 @@ class TenantNetworksClient(service_client.ServiceClient):
resp, body = self.get("os-tenant-networks")
body = json.loads(body)
self.validate_response(schema.list_tenant_networks, resp, body)
return service_client.ResponseBodyList(resp, body['networks'])
return service_client.ResponseBody(resp, body)
def show_tenant_network(self, network_id):
resp, body = self.get("os-tenant-networks/%s" % network_id)
body = json.loads(body)
self.validate_response(schema.get_tenant_network, resp, body)
return service_client.ResponseBody(resp, body['network'])
return service_client.ResponseBody(resp, body)