From 104e0b731a4b44e1d1f3e9092a1d1426809fb78b Mon Sep 17 00:00:00 2001 From: afazekas Date: Tue, 26 Mar 2019 12:38:29 +0100 Subject: [PATCH] Delete test_reboot_server_soft The test has been skipped for than 6 years already. Nova automatically switched to hard reboot if the guest is not responding, no way to see the difference from the API. The following alternatives were not agreed on the PTG. - Change the acpid config an all supported image before the reboot, and log the acpi event in a tempest friendly way - ssh the machine before reboot, in this case more likely a soft reboot would happen, but we are unable to distinguish it from the hard one. Take into account that the minimum scenario test uses soft reboot and the nova functional test also covers reboot. The test hasn't failed for more than 6 years (it's been skipped), so nothing prevents us from removing it by the usual removal procedure: https://docs.openstack.org/tempest/latest/test_removal.html The test deletion was also announced on ML: http://lists.openstack.org/pipermail/openstack-discuss/2020-October/017889.html Change-Id: I62b48865f5b21e55c28b8ee08ad5786473cc5ddf Related-Bug: #1014647 --- .../Remove-test_reboot_server_soft-48fa786f38cd94dc.yaml | 6 ++++++ tempest/api/compute/servers/test_server_actions.py | 9 --------- 2 files changed, 6 insertions(+), 9 deletions(-) create mode 100644 releasenotes/notes/Remove-test_reboot_server_soft-48fa786f38cd94dc.yaml diff --git a/releasenotes/notes/Remove-test_reboot_server_soft-48fa786f38cd94dc.yaml b/releasenotes/notes/Remove-test_reboot_server_soft-48fa786f38cd94dc.yaml new file mode 100644 index 0000000000..fb84d25774 --- /dev/null +++ b/releasenotes/notes/Remove-test_reboot_server_soft-48fa786f38cd94dc.yaml @@ -0,0 +1,6 @@ +--- +upgrade: + - | + The test_reboot_server_soft has been skipped for more than 6 years. + Take into account that the minimum scenario test uses soft reboot + and the nova functional test also covers reboot. diff --git a/tempest/api/compute/servers/test_server_actions.py b/tempest/api/compute/servers/test_server_actions.py index 4db6987da3..343d3eef33 100644 --- a/tempest/api/compute/servers/test_server_actions.py +++ b/tempest/api/compute/servers/test_server_actions.py @@ -160,15 +160,6 @@ class ServerActionsTestJSON(base.BaseV2ComputeTest): """ self._test_reboot_server('HARD') - @decorators.skip_because(bug="1014647") - @decorators.idempotent_id('4640e3ef-a5df-482e-95a1-ceeeb0faa84d') - def test_reboot_server_soft(self): - """Test soft rebooting server - - The server should be signaled to reboot gracefully. - """ - self._test_reboot_server('SOFT') - @decorators.idempotent_id('1d1c9104-1b0a-11e7-a3d4-fa163e65f5ce') def test_remove_server_all_security_groups(self): """Test removing all security groups from server"""