diff --git a/releasenotes/notes/os_tenant_name-3ee175763bff455b.yaml b/releasenotes/notes/os_tenant_name-3ee175763bff455b.yaml new file mode 100644 index 0000000000..936bf1ff03 --- /dev/null +++ b/releasenotes/notes/os_tenant_name-3ee175763bff455b.yaml @@ -0,0 +1,5 @@ +--- +upgrade: + - | + Remove the deprecated argument ``os-tenant-name`` or ``OS_TENANT_NAME`` in favour of + ``os-project-name`` argument. diff --git a/tempest/cmd/account_generator.py b/tempest/cmd/account_generator.py index 7ea0099ec1..1535786465 100755 --- a/tempest/cmd/account_generator.py +++ b/tempest/cmd/account_generator.py @@ -46,7 +46,6 @@ Param CLI Environment Variable Username ``--os-username`` OS_USERNAME Password ``--os-password`` OS_PASSWORD Project ``--os-project-name`` OS_PROJECT_NAME -Tenant ``--os-tenant-name`` (depr.) OS_TENANT_NAME Domain ``--os-domain-name`` OS_DOMAIN_NAME ======== ============================ ==================== @@ -75,9 +74,6 @@ Optional Arguments * ``--os-project-name `` (Optional) Project to request authorization on. Defaults to env[OS_PROJECT_NAME]. -* ``--os-tenant-name `` (Optional, deprecated) Tenant to - request authorization on. Defaults to env[OS_TENANT_NAME]. - * ``--os-domain-name `` (Optional) Domain the user and project belong to. Defaults to env[OS_DOMAIN_NAME]. @@ -139,7 +135,7 @@ def get_credential_provider(opts): 'dhcp': True} admin_creds_dict = {'username': opts.os_username, 'password': opts.os_password} - _project_name = opts.os_project_name or opts.os_tenant_name + _project_name = opts.os_project_name if opts.identity_version == 3: admin_creds_dict['project_name'] = _project_name admin_creds_dict['domain_name'] = opts.os_domain_name or 'Default' @@ -221,10 +217,6 @@ def _parser_add_args(parser): metavar='', default=os.environ.get('OS_PROJECT_NAME'), help='Defaults to env[OS_PROJECT_NAME].') - parser.add_argument('--os-tenant-name', - metavar='', - default=os.environ.get('OS_TENANT_NAME'), - help='Defaults to env[OS_TENANT_NAME].') parser.add_argument('--os-domain-name', metavar='', default=os.environ.get('OS_DOMAIN_NAME'), @@ -301,10 +293,6 @@ def main(opts=None): if log_warning: LOG.warning("Use of: 'tempest-account-generator' is deprecated, " "please use: 'tempest account-generator'") - if opts.os_tenant_name: - LOG.warning("'os-tenant-name' and 'OS_TENANT_NAME' are both " - "deprecated, please use 'os-project-name' or " - "'OS_PROJECT_NAME' instead") resources = [] for count in range(opts.concurrency): # Use N different cred_providers to obtain different sets of creds diff --git a/tempest/tests/cmd/test_account_generator.py b/tempest/tests/cmd/test_account_generator.py index b349bba242..a962e37fc3 100644 --- a/tempest/tests/cmd/test_account_generator.py +++ b/tempest/tests/cmd/test_account_generator.py @@ -28,7 +28,6 @@ class FakeOpts(object): self.os_username = 'fake_user' self.os_password = 'fake_password' self.os_project_name = 'fake_project_name' - self.os_tenant_name = None self.os_domain_name = 'fake_domain' self.tag = 'fake' self.concurrency = 2 @@ -100,15 +99,6 @@ class TestAccountGeneratorV2(base.TestCase, MockHelpersMixin): self.assertEqual(self.opts.os_password, admin_creds.password) self.assertFalse(hasattr(admin_creds, 'domain_name')) - def test_get_credential_provider_with_tenant(self): - self.opts.os_project_name = None - self.opts.os_tenant_name = 'fake_tenant' - cp = account_generator.get_credential_provider(self.opts) - admin_creds = cp.default_admin_creds - self.assertEqual(self.opts.os_tenant_name, admin_creds.tenant_name) - self.assertEqual(self.opts.os_username, admin_creds.username) - self.assertEqual(self.opts.os_password, admin_creds.password) - class TestAccountGeneratorV3(TestAccountGeneratorV2):