From 2096631932384a02a6ceb91a9fdf274862af8d87 Mon Sep 17 00:00:00 2001 From: Ghanshyam Mann Date: Tue, 16 Jul 2019 05:19:41 +0000 Subject: [PATCH] Add 'single core approve' policy for plugins sanity jobs failure We discussed in Denver PTG[1] to make plugins sanity jobs as voting which will help to mantain the active plugins and blacklist the faulty plugins. But when we get faulty plugins this job which will be voting after https://review.opendev.org/#/c/641188/ can block the Tempest gate. So adding the process of single core approve policy for mergin the patches which will fix or remove the faulty plugins to unblock the gate. [1] L196 https://etherpad.openstack.org/p/qa-train-ptg Change-Id: Id38e6270ac1bae8ba63761f9bab6f1e5d0a2252b --- REVIEWING.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/REVIEWING.rst b/REVIEWING.rst index 31fedce868..87847ae182 100644 --- a/REVIEWING.rst +++ b/REVIEWING.rst @@ -183,6 +183,9 @@ When to approve * the project's PTL +1's the change * the patch does not affect any other project's testing gates * the patch does not cause any negative side effects + * If fixing and removing the faulty plugin (which leads to fail + voting ``tempest-tox-plugin-sanity-check`` job) and unblock the + tempest gate Note that such a policy should be used judiciously, as we should strive to have two +2's on each patch set, prior to approval.