openstack
/
tempest
Code Issues Proposed changes

Rename server arg in wait_for_interface_status method 

This is very minor, but the server formal argument to the
wait_for_interface_status method is actually a server id.

This changes the name of the parameter to be clear on the
type of that object, since it could easily be confused
with a full server response body dict.

Change-Id: Id7cab21ab75092226f0784877ae55f17e880229c
This commit is contained in:
Matt Riedemann 2017-04-03 11:36:19 -04:00
parent 90d505ae75
commit 2ea48f06f2
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tempest/common/waiters.py
View File

@ -261,16 +261,16 @@ def wait_for_qos_operations(client, qos_id, operation, args=None):
time.sleep(client.build_interval)
def wait_for_interface_status(client, server, port_id, status):
def wait_for_interface_status(client, server_id, port_id, status):
"""Waits for an interface to reach a given status."""
body = (client.show_interface(server, port_id)
body = (client.show_interface(server_id, port_id)
['interfaceAttachment'])
interface_status = body['port_state']
start = int(time.time())
while(interface_status != status):
time.sleep(client.build_interval)
body = (client.show_interface(server, port_id)
body = (client.show_interface(server_id, port_id)
['interfaceAttachment'])
interface_status = body['port_state']