From 39bea7b68f362ee74b63843d8c28b0d774493738 Mon Sep 17 00:00:00 2001 From: zhufl Date: Mon, 31 Jul 2017 16:54:37 +0800 Subject: [PATCH] Remove unnecessary usage of instance variable This is to remove unnecessary usage of instance variable to keep code clean. Change-Id: Ia6aec6ddbe46ae23e9406ed1a938acd477d129a2 --- tempest/api/object_storage/test_account_quotas_negative.py | 2 +- tempest/api/object_storage/test_container_staticweb.py | 4 ++-- tempest/api/object_storage/test_object_temp_url_negative.py | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tempest/api/object_storage/test_account_quotas_negative.py b/tempest/api/object_storage/test_account_quotas_negative.py index 55a6c7ad4a..60233b4422 100644 --- a/tempest/api/object_storage/test_account_quotas_negative.py +++ b/tempest/api/object_storage/test_account_quotas_negative.py @@ -35,7 +35,7 @@ class AccountQuotasNegativeTest(base.BaseObjectTest): @classmethod def resource_setup(cls): super(AccountQuotasNegativeTest, cls).resource_setup() - cls.container_name = cls.create_container() + cls.create_container() # Retrieve a ResellerAdmin auth data and use it to set a quota # on the client's account diff --git a/tempest/api/object_storage/test_container_staticweb.py b/tempest/api/object_storage/test_container_staticweb.py index 378061a59c..943011dfb5 100644 --- a/tempest/api/object_storage/test_container_staticweb.py +++ b/tempest/api/object_storage/test_container_staticweb.py @@ -27,7 +27,7 @@ class StaticWebTest(base.BaseObjectTest): super(StaticWebTest, cls).resource_setup() # This header should be posted on the container before every test - cls.headers_public_read_acl = {'Read': '.r:*,.rlistings'} + headers_public_read_acl = {'Read': '.r:*,.rlistings'} # Create test container and create one object in it cls.container_name = cls.create_container() @@ -36,7 +36,7 @@ class StaticWebTest(base.BaseObjectTest): cls.container_client.update_container_metadata( cls.container_name, - metadata=cls.headers_public_read_acl, + metadata=headers_public_read_acl, metadata_prefix="X-Container-") @classmethod diff --git a/tempest/api/object_storage/test_object_temp_url_negative.py b/tempest/api/object_storage/test_object_temp_url_negative.py index 3edaa86658..c7d1fd5ab2 100644 --- a/tempest/api/object_storage/test_object_temp_url_negative.py +++ b/tempest/api/object_storage/test_object_temp_url_negative.py @@ -65,10 +65,10 @@ class ObjectTempUrlNegativeTest(base.BaseObjectTest): # create object self.object_name = data_utils.rand_name(name='ObjectTemp') - self.content = data_utils.arbitrary_string(size=len(self.object_name), - base_text=self.object_name) + content = data_utils.arbitrary_string(size=len(self.object_name), + base_text=self.object_name) self.object_client.create_object(self.container_name, - self.object_name, self.content) + self.object_name, content) def _get_expiry_date(self, expiration_time=1000): return int(time.time() + expiration_time)