openstack/tempest
Code Issues Proposed changes

non-admin user only able to download Active image

Browse Source 
Test case updated

This is to check that non-admin user should not able to download
deactivated image and after reactivation it should able to download
the reactive image.

Change-Id: I0a1d0f4fcb72d9d0252a86f6ee136519dac2f677
This commit is contained in:
piyush110786
2015-08-21 10:52:39 +05:30
parent 9d23f20651
commit 413994af63
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tempest/api/image/admin/v2/test_images.py
View File

@@ -20,7 +20,7 @@ import testtools
from tempest.api.image import base from tempest.api.image import base
from tempest import config from tempest import config
from tempest import test from tempest import test
from tempest_lib import exceptions as lib_exc
CONF = config.CONF CONF = config.CONF
@@ -43,13 +43,20 @@ class BasicAdminOperationsImagesTest(base.BaseV2ImageAdminTest):
image_id = body['id'] image_id = body['id']
self.addCleanup(self.client.delete_image, image_id) self.addCleanup(self.client.delete_image, image_id)
# upload an image file # upload an image file
image_file = moves.cStringIO(data_utils.random_bytes()) content = data_utils.random_bytes()
image_file = moves.cStringIO(content)
self.client.store_image_file(image_id, image_file) self.client.store_image_file(image_id, image_file)
# deactivate image # deactivate image
self.admin_client.deactivate_image(image_id) self.admin_client.deactivate_image(image_id)
body = self.client.show_image(image_id) body = self.client.show_image(image_id)
self.assertEqual("deactivated", body['status']) self.assertEqual("deactivated", body['status'])
# non-admin user unable to download deactivated image
self.assertRaises(lib_exc.Forbidden, self.client.load_image_file,
image_id)
# reactivate image # reactivate image
self.admin_client.reactivate_image(image_id) self.admin_client.reactivate_image(image_id)
body = self.client.show_image(image_id) body = self.client.show_image(image_id)
self.assertEqual("active", body['status']) self.assertEqual("active", body['status'])
# non-admin user able to download image after reactivation by admin
body = self.client.load_image_file(image_id)
self.assertEqual(content, body.data)