From 4661706f683afaeb9e0eb5d2109bb6c937d3fcfc Mon Sep 17 00:00:00 2001 From: Masayuki Igawa Date: Fri, 2 Sep 2016 16:38:56 +0900 Subject: [PATCH] Add deprecated code review guideline This commit adds a deprecated code review guideline. We have some deprecated code (e.g. stress test) now. And we sometimes wonder whether we should review a patch for deprecated code or not. So this patch tries to clear up the situation. Change-Id: I188cd9fccae9396b143fa85071387e8a5bb5f3d1 --- REVIEWING.rst | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/REVIEWING.rst b/REVIEWING.rst index 676a2172a2..7d445c2462 100644 --- a/REVIEWING.rst +++ b/REVIEWING.rst @@ -86,6 +86,12 @@ something extra. .. _reno: http://docs.openstack.org/developer/reno/ +Deprecated Code +--------------- +Sometimes we have some bugs in deprecated code. Basically, we leave it. Because +we don't need to maintain it. However, if the bug is critical, we might need to +fix it. When it will happen, we will deal with it on a case-by-case basis. + When to approve --------------- * Every patch needs two +2s before being approved.