openstack
/
tempest
Code Issues Proposed changes

Merge "Need to add kwargs for the api"

This commit is contained in:
Zuul 2020-12-09 01:15:11 +00:00 committed by Gerrit Code Review
parent d76d371e1d a078ddd7c3
commit 60258abc19
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
tempest/scenario/manager.py
View File

@ -540,14 +540,16 @@ class ScenarioTest(tempest.test.BaseTestCase):
rules.append(sg_rule) rules.append(sg_rule)
return rules return rules
def _create_security_group(self): def _create_security_group(self, **kwargs):
"""Create security group and add rules to security group""" """Create security group and add rules to security group"""
sg_name = data_utils.rand_name(self.__class__.__name__) if not kwargs.get('name'):
sg_desc = sg_name + " description" kwargs['name'] = data_utils.rand_name(self.__class__.__name__)
if not kwargs.get('description'):
kwargs['description'] = kwargs['name'] + " description"
secgroup = self.compute_security_groups_client.create_security_group( secgroup = self.compute_security_groups_client.create_security_group(
name=sg_name, description=sg_desc)['security_group'] **kwargs)['security_group']
self.assertEqual(secgroup['name'], sg_name) self.assertEqual(secgroup['name'], kwargs['name'])
self.assertEqual(secgroup['description'], sg_desc) self.assertEqual(secgroup['description'], kwargs['description'])
self.addCleanup( self.addCleanup(
test_utils.call_and_ignore_notfound_exc, test_utils.call_and_ignore_notfound_exc,
self.compute_security_groups_client.delete_security_group, self.compute_security_groups_client.delete_security_group,