diff --git a/REVIEWING.rst b/REVIEWING.rst index bf63ed2620..31fedce868 100644 --- a/REVIEWING.rst +++ b/REVIEWING.rst @@ -159,8 +159,32 @@ fix it. When it will happen, we will deal with it on a case-by-case basis. When to approve --------------- -* Every patch needs two +2s before being approved. -* It's ok to hold off on an approval until a subject matter expert reviews it -* If a patch has already been approved but requires a trivial rebase to merge, - you do not have to wait for a second +2, since the patch has already had - two +2s. +* It's OK to hold off on an approval until a subject matter expert reviews it. +* Every patch needs two +2's before being approved. +* However, a single Tempest core reviewer can approve patches without waiting + for another +2 in the following cases: + + * If a patch has already been approved but requires a trivial rebase to + merge, then there is no need to wait for a second +2, since the patch has + already had two +2's. + * If any trivial patch set fixes one of the items below: + + * Documentation or code comment typo + * Documentation ref link + * Example: `example`_ + + .. note:: + + Any other small documentation, CI job, or code change does not fall under + this category. + + * If the patch **unblocks** a failing project gate, provided that: + + * the project's PTL +1's the change + * the patch does not affect any other project's testing gates + * the patch does not cause any negative side effects + + Note that such a policy should be used judiciously, as we should strive to + have two +2's on each patch set, prior to approval. + +.. _example: https://review.openstack.org/#/c/611032/