openstack
/
tempest
Code Issues Proposed changes

Beautify assertEmpty and assertNotEmpty 

Don't use 'list' as a parameter name since this assert can be used
for any sequence or collection. Add docstring for both helpers.

Change-Id: I747507c3a5d0cf6f84915c8dd9222f4c082cbc04
This commit is contained in:
Andrea Frittoli 2017-04-07 17:45:21 +01:00
parent add0f82828
commit 71c71e9444
1 changed files with 19 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
tempest/test.py
View File

@ -642,12 +642,24 @@ class BaseTestCase(testtools.testcase.WithAttributes,
return fixed_network.get_tenant_network(
cred_provider, networks_client, CONF.compute.fixed_network_name)
def assertEmpty(self, list, msg=None):
if msg is None:
msg = "list is not empty: %s" % list
self.assertEqual(0, len(list), msg)
def assertEmpty(self, items, msg=None):
"""Asserts whether a sequence or collection is empty
def assertNotEmpty(self, list, msg=None):
:param items: sequence or collection to be tested
:param msg: message to be passed to the AssertionError
:raises AssertionError: when items is not empty
"""
if msg is None:
msg = "list is empty."
self.assertGreater(len(list), 0, msg)
msg = "sequence or collection is not empty: %s" % items
self.assertEqual(0, len(items), msg)
def assertNotEmpty(self, items, msg=None):
"""Asserts whether a sequence or collection is not empty
:param items: sequence or collection to be tested
:param msg: message to be passed to the AssertionError
:raises AssertionError: when items is empty
"""
if msg is None:
msg = "sequence or collection is empty."
self.assertGreater(len(items), 0, msg)