From 836e56bf2176b8d0a684a3b45895aa779ea755ff Mon Sep 17 00:00:00 2001 From: Matthew Treinish Date: Thu, 12 Jun 2014 13:55:19 -0400 Subject: [PATCH] Set default to false for nova v3_api config option This commit switches the default value for the nova v3 api config option from true to false. This changes the default behavior to not run the Nova v3 API tests. This is because the v3 is still marked as experimental and is able to change in a non-backwards compatible way which will cause issues when running with branchless tempest. Additionally, the nova team decided not to do a standalone v3 api so at some point this will disappear and instead become v2.1 of the api with microversions. When you couple this with the fact that tempest's gate budget is basically exhausted (tests shouldn't take over an hour to run in the gate) this should be defaulted off. For more discussion see: http://lists.openstack.org/pipermail/openstack-dev/2014-June/037370.html Change-Id: I13dbc4b433a0f6defbeebce958b2e1cbcf64ba7a --- etc/tempest.conf.sample | 2 +- tempest/config.py | 2 +- tempest/tests/cmd/test_verify_tempest_config.py | 2 ++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/etc/tempest.conf.sample b/etc/tempest.conf.sample index ef5e217d6c..23d4ebcdd5 100644 --- a/etc/tempest.conf.sample +++ b/etc/tempest.conf.sample @@ -366,7 +366,7 @@ # # If false, skip all nova v3 tests. (boolean value) -#api_v3=true +#api_v3=false # If false, skip disk config tests (boolean value) #disk_config=true diff --git a/tempest/config.py b/tempest/config.py index 6b17885b8d..136636109e 100644 --- a/tempest/config.py +++ b/tempest/config.py @@ -255,7 +255,7 @@ compute_features_group = cfg.OptGroup(name='compute-feature-enabled', ComputeFeaturesGroup = [ cfg.BoolOpt('api_v3', - default=True, + default=False, help="If false, skip all nova v3 tests."), cfg.BoolOpt('disk_config', default=True, diff --git a/tempest/tests/cmd/test_verify_tempest_config.py b/tempest/tests/cmd/test_verify_tempest_config.py index 429f56f486..d0140dd7fa 100644 --- a/tempest/tests/cmd/test_verify_tempest_config.py +++ b/tempest/tests/cmd/test_verify_tempest_config.py @@ -15,6 +15,7 @@ import json import mock +from oslo.config import cfg from tempest.cmd import verify_tempest_config from tempest import config @@ -152,6 +153,7 @@ class TestDiscovery(base.TestCase): False, True) def test_verify_nova_versions(self): + cfg.CONF.set_default('api_v3', True, 'compute-feature-enabled') self.useFixture(mockpatch.PatchObject( verify_tempest_config, '_get_unversioned_endpoint', return_value='http://fake_endpoint:5000'))