diff --git a/tempest/api/volume/admin/test_volume_types_extra_specs.py b/tempest/api/volume/admin/test_volume_types_extra_specs.py index a45bee0672..b5c5d156ab 100644 --- a/tempest/api/volume/admin/test_volume_types_extra_specs.py +++ b/tempest/api/volume/admin/test_volume_types_extra_specs.py @@ -54,20 +54,19 @@ class VolumeTypesExtraSpecsV2Test(base.BaseVolumeAdminTest): self.volume_type['id'], extra_specs)['extra_specs'] self.assertEqual(extra_specs, body, "Volume type extra spec incorrectly created") - - extra_spec = {"spec2": "val2"} + spec_key = "spec2" + extra_spec = {spec_key: "val2"} body = self.admin_volume_types_client.update_volume_type_extra_specs( - self.volume_type['id'], - extra_spec.keys()[0], - extra_spec) - self.assertIn('spec2', body) - self.assertEqual(extra_spec['spec2'], body['spec2'], + self.volume_type['id'], spec_key, extra_spec) + self.assertIn(spec_key, body) + self.assertEqual(extra_spec[spec_key], body[spec_key], "Volume type extra spec incorrectly updated") @test.idempotent_id('d4772798-601f-408a-b2a5-29e8a59d1220') def test_volume_type_extra_spec_create_get_delete(self): # Create/Get/Delete volume type extra spec. - extra_specs = {"spec3": "val1"} + spec_key = "spec3" + extra_specs = {spec_key: "val1"} body = self.admin_volume_types_client.create_volume_type_extra_specs( self.volume_type['id'], extra_specs)['extra_specs'] @@ -76,13 +75,11 @@ class VolumeTypesExtraSpecsV2Test(base.BaseVolumeAdminTest): self.admin_volume_types_client.show_volume_type_extra_specs( self.volume_type['id'], - extra_specs.keys()[0]) + spec_key) self.assertEqual(extra_specs, body, "Volume type extra spec incorrectly fetched") - self.admin_volume_types_client.delete_volume_type_extra_specs( - self.volume_type['id'], - extra_specs.keys()[0]) + self.volume_type['id'], spec_key) class VolumeTypesExtraSpecsV1Test(VolumeTypesExtraSpecsV2Test): diff --git a/tempest/api/volume/admin/test_volume_types_extra_specs_negative.py b/tempest/api/volume/admin/test_volume_types_extra_specs_negative.py index 69839742a5..c7c3e1ace3 100644 --- a/tempest/api/volume/admin/test_volume_types_extra_specs_negative.py +++ b/tempest/api/volume/admin/test_volume_types_extra_specs_negative.py @@ -38,11 +38,10 @@ class ExtraSpecsNegativeV2Test(base.BaseVolumeAdminTest): @test.idempotent_id('08961d20-5cbb-4910-ac0f-89ad6dbb2da1') def test_update_no_body(self): # Should not update volume type extra specs with no body - extra_spec = {"spec1": "val2"} self.assertRaises( lib_exc.BadRequest, self.admin_volume_types_client.update_volume_type_extra_specs, - self.volume_type['id'], extra_spec.keys()[0], None) + self.volume_type['id'], "spec1", None) @test.idempotent_id('25e5a0ee-89b3-4c53-8310-236f76c75365') def test_update_nonexistent_extra_spec_id(self): @@ -71,7 +70,7 @@ class ExtraSpecsNegativeV2Test(base.BaseVolumeAdminTest): self.assertRaises( lib_exc.BadRequest, self.admin_volume_types_client.update_volume_type_extra_specs, - self.volume_type['id'], extra_spec.keys()[0], + self.volume_type['id'], list(extra_spec)[0], extra_spec) @test.idempotent_id('49d5472c-a53d-4eab-a4d3-450c4db1c545') @@ -103,12 +102,11 @@ class ExtraSpecsNegativeV2Test(base.BaseVolumeAdminTest): @test.idempotent_id('031cda8b-7d23-4246-8bf6-bbe73fd67074') def test_delete_nonexistent_volume_type_id(self): # Should not delete volume type extra spec for nonexistent - # type id. - extra_specs = {"spec1": "val1"} + # type id. self.assertRaises( lib_exc.NotFound, self.admin_volume_types_client.delete_volume_type_extra_specs, - data_utils.rand_uuid(), extra_specs.keys()[0]) + data_utils.rand_uuid(), "spec1") @test.idempotent_id('dee5cf0c-cdd6-4353-b70c-e847050d71fb') def test_list_nonexistent_volume_type_id(self): @@ -121,11 +119,10 @@ class ExtraSpecsNegativeV2Test(base.BaseVolumeAdminTest): @test.idempotent_id('9f402cbd-1838-4eb4-9554-126a6b1908c9') def test_get_nonexistent_volume_type_id(self): # Should not get volume type extra spec for nonexistent type id. - extra_specs = {"spec1": "val1"} self.assertRaises( lib_exc.NotFound, self.admin_volume_types_client.show_volume_type_extra_specs, - data_utils.rand_uuid(), extra_specs.keys()[0]) + data_utils.rand_uuid(), "spec1") @test.idempotent_id('c881797d-12ff-4f1a-b09d-9f6212159753') def test_get_nonexistent_extra_spec_id(self): diff --git a/tempest/scenario/manager.py b/tempest/scenario/manager.py index dd6e0e50dc..69da1c9f71 100644 --- a/tempest/scenario/manager.py +++ b/tempest/scenario/manager.py @@ -1037,7 +1037,7 @@ class NetworkScenarioTest(ScenarioTest): if not tenant_id: tenant_id = client.tenant_id sgs = [ - sg for sg in client.list_security_groups().values()[0] + sg for sg in list(client.list_security_groups().values())[0] if sg['tenant_id'] == tenant_id and sg['name'] == 'default' ] msg = "No default security group for tenant %s." % (tenant_id)