openstack
/
tempest
Code Issues Proposed changes

Make test_hotplug_nic test first check the IP 

The test doesn't take into account that the interface can
already be associated with the IP address, configured by
NetworkManager. Therefore the review adds a check if the
IP is already set.

Change-Id: I4eede97c041b44d9a7bb754e5ccc1ebb194a2e4b
This commit is contained in:
Martin Kopec 2019-05-07 13:26:34 +00:00
parent 7fb6e81027
commit 925188d2d5
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tempest/scenario/test_network_basic_ops.py
View File

@ -292,10 +292,13 @@ class TestNetworkBasicOps(manager.NetworkScenarioTest):
% CONF.network.build_timeout)
_, new_nic = self.diff_list[0]
ip_output = ssh_client.exec_command('ip a')
ip_address = new_port['fixed_ips'][0]['ip_address']
ip_mask = CONF.network.project_network_mask_bits
# check if the address is not already in use, if not, set it
if ' ' + ip_address + '/' + str(ip_mask) not in ip_output:
ssh_client.exec_command("sudo ip addr add %s/%s dev %s" % (
new_port['fixed_ips'][0]['ip_address'],
CONF.network.project_network_mask_bits,
new_nic))
ip_address, ip_mask, new_nic))
ssh_client.exec_command("sudo ip link set %s up" % new_nic)
def _get_server_nics(self, ssh_client):