From 937438cb4a63704d31f384769d334978f6abaa71 Mon Sep 17 00:00:00 2001 From: Yaroslav Lobankov Date: Fri, 20 Nov 2015 11:21:11 +0300 Subject: [PATCH] [V3] Rename get_group to show_group [GET /resources] methods should be "list_s" or "show_", so this patch applies the rule to groups client. Partially implements blueprint consistent-service-method-names Change-Id: Ia6c83f9bad2684c61e694e52244ea54c98d9d070 --- tempest/api/identity/admin/v3/test_groups.py | 2 +- tempest/hacking/ignored_list_T110.txt | 1 - tempest/services/identity/v3/json/groups_client.py | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/tempest/api/identity/admin/v3/test_groups.py b/tempest/api/identity/admin/v3/test_groups.py index f25ed98f1b..82e4ec8a22 100644 --- a/tempest/api/identity/admin/v3/test_groups.py +++ b/tempest/api/identity/admin/v3/test_groups.py @@ -37,7 +37,7 @@ class GroupsV3TestJSON(base.BaseIdentityV3AdminTest): self.assertEqual(updated_group['name'], new_name) self.assertEqual(updated_group['description'], new_desc) - new_group = self.groups_client.get_group(group['id'])['group'] + new_group = self.groups_client.show_group(group['id'])['group'] self.assertEqual(group['id'], new_group['id']) self.assertEqual(new_name, new_group['name']) self.assertEqual(new_desc, new_group['description']) diff --git a/tempest/hacking/ignored_list_T110.txt b/tempest/hacking/ignored_list_T110.txt index d671616066..7c3e830608 100644 --- a/tempest/hacking/ignored_list_T110.txt +++ b/tempest/hacking/ignored_list_T110.txt @@ -1,7 +1,6 @@ ./tempest/services/compute/json/servers_client.py ./tempest/services/database/json/flavors_client.py ./tempest/services/identity/v3/json/credentials_client.py -./tempest/services/identity/v3/json/groups_client.py ./tempest/services/identity/v3/json/identity_client.py ./tempest/services/identity/v3/json/policy_client.py ./tempest/services/identity/v3/json/region_client.py diff --git a/tempest/services/identity/v3/json/groups_client.py b/tempest/services/identity/v3/json/groups_client.py index 2f302aeae8..70edd23cf6 100644 --- a/tempest/services/identity/v3/json/groups_client.py +++ b/tempest/services/identity/v3/json/groups_client.py @@ -37,7 +37,7 @@ class GroupsClient(service_client.ServiceClient): body = json.loads(body) return service_client.ResponseBody(resp, body) - def get_group(self, group_id): + def show_group(self, group_id): """Get group details.""" resp, body = self.get('groups/%s' % group_id) self.expected_success(200, resp.status)